All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] doc: libltpswap: Add kerneldoc
Date: Fri, 26 Apr 2024 20:25:57 +0200	[thread overview]
Message-ID: <20240426182557.GD6871@pevik> (raw)
In-Reply-To: <CAEemH2dzzZp5kMF5cQPQQ=Z-Eb55JkEtqvh2E8UOt6UOE7gr7w@mail.gmail.com>

Hi Li,

> > >   /**
> > > - * Macro to create minimal swapfile.
> > > + * MAKE_SMALL_SWAPFILE - create small swap file.
> > > + *
> > > + * Macro to create small small swap file. Size defined with
> > MINIMAL_SWAP_SIZE_MB.
> > "small small" sounds weird. Maybe "really small"


> +1 I guess that might be one typo.

> Otherwise looks good to me, thanks!

Thanks a lot for catching these (on 2 places, diff below). I'm travelling for a
few days, thus I'll leave it for others to see before merge.

Kind regards,
Petr

+++ include/libswap.h
@@ -30,7 +30,7 @@ int make_swapfile(const char *file, const int lineno,
 /**
  * MAKE_SMALL_SWAPFILE - create small swap file.
  *
- * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
+ * Macro to create small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
  *
  * @swapfile: swap filename.
  */
@@ -41,7 +41,7 @@ int make_swapfile(const char *file, const int lineno,
 /**
  * SAFE_MAKE_SMALL_SWAPFILE - create small swap file (safe version).
  *
- * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
+ * Macro to create small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
  * Includes safety checks to handle potential errors.
  *
  * @swapfile: swap filename.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-04-26 18:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  4:28 [LTP] [PATCH 1/1] doc: libltpswap: Add kerneldoc Petr Vorel
2024-04-26  7:43 ` Andrea Cervesato via ltp
2024-04-26  8:30   ` Li Wang
2024-04-26 18:25     ` Petr Vorel [this message]
2024-05-07  8:28       ` Andrea Cervesato via ltp
2024-05-07  8:31         ` Petr Vorel
2024-04-26 18:28   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240426182557.GD6871@pevik \
    --to=pvorel@suse.cz \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.