From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1ACCC4345F for ; Fri, 26 Apr 2024 18:29:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 817F8606BA; Fri, 26 Apr 2024 18:29:54 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id xw2kCbvkkze3; Fri, 26 Apr 2024 18:29:53 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D4E26613AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1714156193; bh=4TPrsqGa9ByEnHg6yK28CDfJ0xvKv2LKelgS5Q++4ng=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=EoluxlfGWrYbgOjcDUiZ4/gfBK1bPjSkVd9VwvwmSvrm/vUqL+ta64xmDWggdgU8+ OYqBx9brSF9ng8lx4NkmF5oWFY3GIS3xdM9SJENm2YbrJ9whLrHctCgH0Yk+ndsr6E DatooAuJp6aoNDgfI4ssotPWnprzzIhpF92DT4kvX4LkVSjYaKLdhBZ7IzxbA/h90E aQSVPWK2XeIPaWjWB/H0u3WwKPBl2+DCxhP7zvn86skq4oaq1x0gGJ1q5UL914GvHB pt4LA4nM08pMWKkKOVYQwGGtyLwyVzSXym5RG4AfhWwTCmBhBGVZRqe/3Icj8+Jyhv M/9w4q6tIKMGQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id D4E26613AA; Fri, 26 Apr 2024 18:29:53 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 1A1961BF3D2 for ; Fri, 26 Apr 2024 18:29:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 11840410A6 for ; Fri, 26 Apr 2024 18:29:52 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id F1PiQk69lael for ; Fri, 26 Apr 2024 18:29:51 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2BB4140949 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2BB4140949 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2BB4140949 for ; Fri, 26 Apr 2024 18:29:51 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id E777460F4F; Fri, 26 Apr 2024 18:29:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64D6EC113CD; Fri, 26 Apr 2024 18:29:48 +0000 (UTC) Date: Fri, 26 Apr 2024 19:29:45 +0100 From: Simon Horman To: Marcin Szycik Message-ID: <20240426182945.GC516117@kernel.org> References: <20240423143632.45086-1-marcin.szycik@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423143632.45086-1-marcin.szycik@linux.intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714156189; bh=mCu4M4go0z7z0UPv0dVxjtKKrRzycrwc/HpPtbX3gYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iohnqGd6ItTP+KRtdLxIftUIYMsrzLqw0wA6MLq9t7xKvSD3JK/R5cjwUwrhj3CJo ZUPftZrE/bwBNA8AGFWKDCUWGWuxeCSXy9x1zDj/J99c/jDdWuH7c15ENyo19bshf+ Zuqd4aYA/PgpwUECdsoG1HONwRjjY2ToO0ff1bNnRoNNe7XUeJBhEB8B0chJJpsZop Fk8l407h5O6zPRXJDnvxp2JtJjab0nDAJIk91QjtYvbEtbmHLsdDEBX/PDcMjJO+8/ J7X05iZzdAaEtHajitwjAW9HzC3cJAnd5yzqu4z4A1YC9tdBG7s4qFtYre+1sHVj7L 3a7wBVK4m+wbg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=iohnqGd6 Subject: Re: [Intel-wired-lan] [PATCH iwl-next] ice: remove correct filters during eswitch release X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wojciech Drewek , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Michal Swiatkowski Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, Apr 23, 2024 at 04:36:32PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > ice_clear_dflt_vsi() is only removing default rule. Both default RX and > TX rule should be removed during release. > > If it isn't switching to switchdev, second time results in error, because > TX filter is already there. > > Fix it by removing the correct set of rules. > > Fixes: 50d62022f455 ("ice: default Tx rule instead of to queue") > Reviewed-by: Wojciech Drewek > Signed-off-by: Michal Swiatkowski > Signed-off-by: Marcin Szycik > --- > It is targetting iwl-next with fix, because the broken patch isn't yet > in net repo. Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F15EE54755 for ; Fri, 26 Apr 2024 18:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714156190; cv=none; b=AkGlsCQlJXzhoSCyZG6oaXqL1cYCROcwqrO6zt4IeRWqQHnGgFqF4o9OlOWMo8ej6HuU2A7TXWXT5+zTkZ6VcCdJflamnn5vBp61NBjZifH5cRFWKcv4u0DHIUjy9tEQtYSO/xOOAEGuknV54KcSE1lG6mNhbNTIggxg6U+zxSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714156190; c=relaxed/simple; bh=mCu4M4go0z7z0UPv0dVxjtKKrRzycrwc/HpPtbX3gYI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BEqD7KJKhZ7sTu1/U1wD/Vm9DMzl2DweCl2kXHL90E1V0KkVQb1ymdEAbeBXvTNY3+sYZ8tOrR5bPpRnZmhn0R3t30BnCzpg4R6a4Y8qWlHZ3aR7h/K8MwaLWtC54cE2d+69D0hsabcZGSCMQD7LbNwPB1iKEualeutN2kzeTYs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iohnqGd6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iohnqGd6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64D6EC113CD; Fri, 26 Apr 2024 18:29:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714156189; bh=mCu4M4go0z7z0UPv0dVxjtKKrRzycrwc/HpPtbX3gYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iohnqGd6ItTP+KRtdLxIftUIYMsrzLqw0wA6MLq9t7xKvSD3JK/R5cjwUwrhj3CJo ZUPftZrE/bwBNA8AGFWKDCUWGWuxeCSXy9x1zDj/J99c/jDdWuH7c15ENyo19bshf+ Zuqd4aYA/PgpwUECdsoG1HONwRjjY2ToO0ff1bNnRoNNe7XUeJBhEB8B0chJJpsZop Fk8l407h5O6zPRXJDnvxp2JtJjab0nDAJIk91QjtYvbEtbmHLsdDEBX/PDcMjJO+8/ J7X05iZzdAaEtHajitwjAW9HzC3cJAnd5yzqu4z4A1YC9tdBG7s4qFtYre+1sHVj7L 3a7wBVK4m+wbg== Date: Fri, 26 Apr 2024 19:29:45 +0100 From: Simon Horman To: Marcin Szycik Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Michal Swiatkowski , Wojciech Drewek Subject: Re: [PATCH iwl-next] ice: remove correct filters during eswitch release Message-ID: <20240426182945.GC516117@kernel.org> References: <20240423143632.45086-1-marcin.szycik@linux.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240423143632.45086-1-marcin.szycik@linux.intel.com> On Tue, Apr 23, 2024 at 04:36:32PM +0200, Marcin Szycik wrote: > From: Michal Swiatkowski > > ice_clear_dflt_vsi() is only removing default rule. Both default RX and > TX rule should be removed during release. > > If it isn't switching to switchdev, second time results in error, because > TX filter is already there. > > Fix it by removing the correct set of rules. > > Fixes: 50d62022f455 ("ice: default Tx rule instead of to queue") > Reviewed-by: Wojciech Drewek > Signed-off-by: Michal Swiatkowski > Signed-off-by: Marcin Szycik > --- > It is targetting iwl-next with fix, because the broken patch isn't yet > in net repo. Reviewed-by: Simon Horman