Re: b4: use new trailers in 'b4 send --resend'

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Konstantin,

thanks for your quick feedback.

On Fri, 26 Apr 2024 11:11:29 -0400
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:

> On Fri, Apr 26, 2024 at 02:01:57PM GMT, Luca Ceresoli wrote:
> > first of all: thanks for b4, I love it when sending my patches!
> > 
> > I found a little issue when resending a patch series with unmodified
> > content, but with new trailers received after the initial sending.
> > 
> > This are the events involved:
> > 
> >  1. send a patch series (b4 send)
> >  2. receive some Reviewed-by, but patch not applied and no changes
> >     needed
> >  3. update trailers (b4 trailers -u)
> >  4. resend (b4 send --resend)
> > 
> > At step 4 I would expect b4 to prepare a [PATCH RESEND] series with
> > the new trailers added. Instead b4 resends the exact same series,
> > without any new trailers.  
> 
> This is the expected behaviour, as far as I know. There should be no 
> differences between the series, otherwise it's not really a resend.
> 
> It's not really necessary to resend a series just for trailer changes 
> anyway. The maintainer will most likely use b4 to retrieve it anyway, 
> and that will pull in any new trailers.

I cannot recall exactly when it did happen and provide a link right now,
but I clearly remember having been asked by some maintainer to do
exactly this, instead of pinging.

The rationale is that sending a new version just to add review tags was
considered bad because one can expect the patches or commit description
to have changed somewhat, which it hasn't.

OTOH resending without new trailers can lead to applying a patch
without those tags (not recognizing reviewers time), or even worse to
discard a patch because it does not show the needed tags.

It all made sense to me. Does it look reasonable to you too, with this
extra explanation?

Best regards,
Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com