From: Andreas Kemnade <andreas@kemnade.info>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Felix Kaechele <felix@kaechele.ca>,
dmitry.torokhov@gmail.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
o.rempel@pengutronix.de, u.kleine-koenig@pengutronix.de,
hdegoede@redhat.com, ye.xingchen@zte.com.cn,
p.puschmann@pironex.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
caleb.connolly@linaro.org
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426
Date: Fri, 26 Apr 2024 20:53:02 +0200 [thread overview]
Message-ID: <20240426205302.4acbdb11@aktux> (raw)
In-Reply-To: <CAHp75VdA_peJBWXFWSs-vDxA86y6MG0J7ixzXExqDxJJzfJ7mA@mail.gmail.com>
Hi,
On Fri, 26 Apr 2024 16:51:59 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > I think focaltech,ft5406 is better because it is consistent with other drivers/
> > bindings. We do not specify the display it is used on on other touchscreen
> > bindings. We do not specify the actual LEDs behind a LED interface chip.
> > And often the chip name is more easily to find out than the name of a
> > display.
>
> I'm _not_ a DT person, you should clarify this with them. I just
> pointed out the possible mistake (from Linux / DT perspective), and
> not hardware / business related one. If they are fine with focaltech
> prefix, then it's fine to me as well!
as 1/2 is Acked-by DT, I think the compatible is fine, so I will probably
just send a v3 with a sorted 2/2.
Regards,
Andreas
prev parent reply other threads:[~2024-04-26 18:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-04 22:20 [PATCH v2 0/2] Input: add ft5426 Andreas Kemnade
2024-04-04 22:20 ` [PATCH v2 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add ft5426 Andreas Kemnade
2024-04-04 22:20 ` [PATCH v2 2/2] Input: edt-ft5x06 - add ft5426 Andreas Kemnade
2024-04-05 15:13 ` Andy Shevchenko
2024-04-05 16:28 ` Andreas Kemnade
2024-04-05 17:21 ` Andy Shevchenko
2024-04-05 18:56 ` Andreas Kemnade
2024-04-25 16:54 ` Andreas Kemnade
2024-04-26 2:54 ` Felix Kaechele
2024-04-26 7:56 ` Andreas Kemnade
2024-04-26 13:51 ` Andy Shevchenko
2024-04-26 18:53 ` Andreas Kemnade [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426205302.4acbdb11@aktux \
--to=andreas@kemnade.info \
--cc=andy.shevchenko@gmail.com \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=felix@kaechele.ca \
--cc=hdegoede@redhat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=p.puschmann@pironex.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.