From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1452047F7C for ; Sat, 27 Apr 2024 10:20:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714213206; cv=none; b=gOSSigMYO31J/FV8Xqm74IKvJh/AaUgZyaxrXhpYEI9FkkFqlt6HGKKjRFI6HYdC4AK7+bZv4HvZgtb8IjmbeeIm0JUKWEaFAwX9uTcxYWuY7iTZ6r6LbY61Qh4DhmsUHi0HhmYKYZFu1Mm6w1lCplD7u9eYH+du/WjcUlyKifk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714213206; c=relaxed/simple; bh=JWA6+ZKwW4Es+WCjLsw/Bewv+NoSaEScYh68o7FE5Gc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tXbqxmEFJVMLq7X7v3zqYLJ3XrKT2m1Z2RBQFtU8+D+fyYG1dPQsA66T5YHs4bu4dcuAumuPMdaMaPHXLKemW9Nvjw8wJY/pkF0durdNxc0BZE2AG0yPDXHn3s4MNHijdEjD+ixglokqLMfIKyDQvczDUigLegdUDaV/9VsQnoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bVobT105; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bVobT105" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2a2da57ab3aso2582326a91.3 for ; Sat, 27 Apr 2024 03:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714213203; x=1714818003; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=f7+iFYpps1zeYEBYcKhOBHRNG0fMT263PpJq0n4u0EE=; b=bVobT105MOR23WJztzNbcBOJDermDa88yZnDdtNPRDpG+U/1JMuCGw1MCA7AbW3EaH QfwqM/nnbZKfDajiMyEyapSr9t92gRXXVfdlxw+2sgJs5cAAixLXBX2o6ogiW5js0v1b BOjE4aytDnCXSddi2t8ySYbs1HOw9qJfEwzOqLadYhpT2KPZdyqiKb4bxpynVeDxK0xD smt+v2JQ+vtefSknFfK608FWXCPvKyO6quQ+uXmNHDnqevBxugvkdivFvwsMixC+Y/XA 8fVSG0z9NhxejwFWzvQAL8hUiPNlbTJUBN1sG1zSyYw8yHQ/BAAWmbHkKL/kZkMmjjMi FS3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714213203; x=1714818003; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7+iFYpps1zeYEBYcKhOBHRNG0fMT263PpJq0n4u0EE=; b=o2Y7fkhUgbh9Q3Y7bu28JuRB5sExH633vmlS03M0oVAO610eNMDjsqCMZxlHncyJN2 n6SFKL6sEtpD+gHleLoIYlms4RXa6xUxlLjqZeyEec7kGfTd50Jh9DnqWwZgchTjyqGT CE8P9RF0818cYQN/UJXj3eE0zbU3B0x7zcXR84LN3hmF6zoN41Nc3Yg/46j+NN5xb5iC qWpDFFQBqErPzvMwgsUr/AR08FH2epcFL7JpsNpzZ9DEQhb849N1RAAUWOdWUHSXBjyE E8RsE3KSaBaG6AiBW757nOq/mrXgmRloER8ivmzn3pWGHpvEbydf7TMCTD+q6YUInEyk 8hqQ== X-Forwarded-Encrypted: i=1; AJvYcCUv+4OHA1lJmxZ4D01qNoi64+0zW9snK5uKMBQs4rkML/WrmRdYUUTu9StstLRzBfHDJXZ+T6LF8+91I6zKhiLvjkox X-Gm-Message-State: AOJu0Yw2bo14CP9TJW48PtZQPrwY0an/VEMQ9QTj+Fuetiysz7+iulyi 4/9Lz0NROWp4RQAa2SldA9Ql7GAGcMn2hMK3M5FI656t8dx51ox0prUUT2tfvg== X-Google-Smtp-Source: AGHT+IEYOZapJrU/m4SmvbbkI2Rqw/VHSc6hVCsBseOgu88lyFU9KKkSvde7eKI7fVNOcnbI0UpRCA== X-Received: by 2002:a17:90b:1d89:b0:2af:53c6:5fb0 with SMTP id pf9-20020a17090b1d8900b002af53c65fb0mr4651141pjb.28.1714213202995; Sat, 27 Apr 2024 03:20:02 -0700 (PDT) Received: from thinkpad ([117.213.97.210]) by smtp.gmail.com with ESMTPSA id e7-20020a17090a7c4700b002ad6b1e5b6fsm11013594pjl.56.2024.04.27.03.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 03:20:02 -0700 (PDT) Date: Sat, 27 Apr 2024 15:49:50 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback Message-ID: <20240427101950.GL1981@thinkpad> References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com> <20240402-pci2_upstream-v3-7-803414bdb430@nxp.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240402-pci2_upstream-v3-7-803414bdb430@nxp.com> On Tue, Apr 02, 2024 at 10:33:43AM -0400, Frank Li wrote: > Instead of using the switch case statement to assert/dassert the core reset > handled by this driver itself, let's introduce a new callback core_reset() > and define it for platforms that require it. This simplifies the code. > > Signed-off-by: Frank Li > --- > drivers/pci/controller/dwc/pcie-imx.c | 131 ++++++++++++++++++---------------- > 1 file changed, 68 insertions(+), 63 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-imx.c b/drivers/pci/controller/dwc/pcie-imx.c > index 77dae5c3f7057..af0f960f28757 100644 > --- a/drivers/pci/controller/dwc/pcie-imx.c > +++ b/drivers/pci/controller/dwc/pcie-imx.c > @@ -104,6 +104,7 @@ struct imx_pcie_drvdata { > const struct pci_epc_features *epc_features; > int (*init_phy)(struct imx_pcie *pcie); > int (*set_ref_clk)(struct imx_pcie *pcie, bool enable); > + int (*core_reset)(struct imx_pcie *pcie, bool assert); > }; > > struct imx_pcie { > @@ -671,35 +672,72 @@ static void imx_pcie_clk_disable(struct imx_pcie *imx_pcie) > clk_bulk_disable_unprepare(imx_pcie->drvdata->clks_cnt, imx_pcie->clks); > } > > +static int imx6sx_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > +{ > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, IMX6SX_GPR12_PCIE_TEST_POWERDOWN, > + assert ? IMX6SX_GPR12_PCIE_TEST_POWERDOWN : 0); Earlier, this register was not cleared during deassert. Is if fine? > + /* Force PCIe PHY reset */ > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR5, IMX6SX_GPR5_PCIE_BTNRST_RESET, > + assert ? IMX6SX_GPR5_PCIE_BTNRST_RESET : 0); > + return 0; > +} > + > +static int imx6qp_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > +{ > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, IMX6Q_GPR1_PCIE_SW_RST, > + assert ? IMX6Q_GPR1_PCIE_SW_RST : 0); > + if (!assert) > + usleep_range(200, 500); > + > + return 0; > +} > + > +static int imx6q_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > +{ > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, IMX6Q_GPR1_PCIE_TEST_PD, > + assert ? IMX6Q_GPR1_PCIE_TEST_PD : 0); > + > + regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, IMX6Q_GPR1_PCIE_REF_CLK_EN, > + assert ? 0 : IMX6Q_GPR1_PCIE_REF_CLK_EN); > + Same comment as above. > + return 0; > +} > + > +static int imx7d_pcie_core_reset(struct imx_pcie *imx_pcie, bool assert) > +{ > + struct dw_pcie *pci = imx_pcie->pci; > + struct device *dev = pci->dev; > + > + if (assert) > + return 0; > + > + /* > + * Workaround for ERR010728, failure of PCI-e PLL VCO to oscillate, especially when cold. What does 'especially when cold' means? I know it is an old comment, but still it is not very clear. > + * This turns off "Duty-cycle Corrector" and other mysterious undocumented things. Same comment as previous patch. > + */ > + > + if (likely(imx_pcie->phy_base)) { > + /* De-assert DCC_FB_EN */ > + writel(PCIE_PHY_CMN_REG4_DCC_FB_EN, imx_pcie->phy_base + PCIE_PHY_CMN_REG4); > + /* Assert RX_EQS and RX_EQS_SEL */ > + writel(PCIE_PHY_CMN_REG24_RX_EQ_SEL | PCIE_PHY_CMN_REG24_RX_EQ, > + imx_pcie->phy_base + PCIE_PHY_CMN_REG24); > + /* Assert ATT_MODE */ > + writel(PCIE_PHY_CMN_REG26_ATT_MODE, imx_pcie->phy_base + PCIE_PHY_CMN_REG26); Why does this workaround a part of core_reset handling? This function doesn't look like performing reset at all. - Mani > + } else { > + dev_warn(dev, "Unable to apply ERR010728 workaround. DT missing fsl,imx7d-pcie-phy phandle ?\n"); > + } > + imx7d_pcie_wait_for_phy_pll_lock(imx_pcie); > + return 0; > +} > + > static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) > { > reset_control_assert(imx_pcie->pciephy_reset); > reset_control_assert(imx_pcie->apps_reset); > > - switch (imx_pcie->drvdata->variant) { > - case IMX6SX: > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX6SX_GPR12_PCIE_TEST_POWERDOWN, > - IMX6SX_GPR12_PCIE_TEST_POWERDOWN); > - /* Force PCIe PHY reset */ > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR5, > - IMX6SX_GPR5_PCIE_BTNRST_RESET, > - IMX6SX_GPR5_PCIE_BTNRST_RESET); > - break; > - case IMX6QP: > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, > - IMX6Q_GPR1_PCIE_SW_RST, > - IMX6Q_GPR1_PCIE_SW_RST); > - break; > - case IMX6Q: > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, > - IMX6Q_GPR1_PCIE_TEST_PD, 1 << 18); > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, > - IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); > - break; > - default: > - break; > - } > + if (imx_pcie->drvdata->core_reset) > + imx_pcie->drvdata->core_reset(imx_pcie, true); > > /* Some boards don't have PCIe reset GPIO. */ > if (gpio_is_valid(imx_pcie->reset_gpio)) > @@ -709,47 +747,10 @@ static void imx_pcie_assert_core_reset(struct imx_pcie *imx_pcie) > > static int imx_pcie_deassert_core_reset(struct imx_pcie *imx_pcie) > { > - struct dw_pcie *pci = imx_pcie->pci; > - struct device *dev = pci->dev; > - > reset_control_deassert(imx_pcie->pciephy_reset); > > - switch (imx_pcie->drvdata->variant) { > - case IMX7D: > - /* Workaround for ERR010728, failure of PCI-e PLL VCO to > - * oscillate, especially when cold. This turns off "Duty-cycle > - * Corrector" and other mysterious undocumented things. > - */ > - if (likely(imx_pcie->phy_base)) { > - /* De-assert DCC_FB_EN */ > - writel(PCIE_PHY_CMN_REG4_DCC_FB_EN, > - imx_pcie->phy_base + PCIE_PHY_CMN_REG4); > - /* Assert RX_EQS and RX_EQS_SEL */ > - writel(PCIE_PHY_CMN_REG24_RX_EQ_SEL > - | PCIE_PHY_CMN_REG24_RX_EQ, > - imx_pcie->phy_base + PCIE_PHY_CMN_REG24); > - /* Assert ATT_MODE */ > - writel(PCIE_PHY_CMN_REG26_ATT_MODE, > - imx_pcie->phy_base + PCIE_PHY_CMN_REG26); > - } else { > - dev_warn(dev, "Unable to apply ERR010728 workaround. DT missing fsl,imx7d-pcie-phy phandle ?\n"); > - } > - > - imx7d_pcie_wait_for_phy_pll_lock(imx_pcie); > - break; > - case IMX6SX: > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR5, > - IMX6SX_GPR5_PCIE_BTNRST_RESET, 0); > - break; > - case IMX6QP: > - regmap_update_bits(imx_pcie->iomuxc_gpr, IOMUXC_GPR1, > - IMX6Q_GPR1_PCIE_SW_RST, 0); > - > - usleep_range(200, 500); > - break; > - default: > - break; > - } > + if (imx_pcie->drvdata->core_reset) > + imx_pcie->drvdata->core_reset(imx_pcie, false); > > /* Some boards don't have PCIe reset GPIO. */ > if (gpio_is_valid(imx_pcie->reset_gpio)) { > @@ -1447,6 +1448,7 @@ static const struct imx_pcie_drvdata drvdata[] = { > .mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE, > .init_phy = imx_pcie_init_phy, > .set_ref_clk = imx6q_pcie_set_ref_clk, > + .core_reset = imx6q_pcie_core_reset, > }, > [IMX6SX] = { > .variant = IMX6SX, > @@ -1462,6 +1464,7 @@ static const struct imx_pcie_drvdata drvdata[] = { > .mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE, > .init_phy = imx6sx_pcie_init_phy, > .set_ref_clk = imx6sx_pcie_set_ref_clk, > + .core_reset = imx6sx_pcie_core_reset, > }, > [IMX6QP] = { > .variant = IMX6QP, > @@ -1478,6 +1481,7 @@ static const struct imx_pcie_drvdata drvdata[] = { > .mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE, > .init_phy = imx_pcie_init_phy, > .set_ref_clk = imx6q_pcie_set_ref_clk, > + .core_reset = imx6qp_pcie_core_reset, > }, > [IMX7D] = { > .variant = IMX7D, > @@ -1491,6 +1495,7 @@ static const struct imx_pcie_drvdata drvdata[] = { > .mode_mask[0] = IMX6Q_GPR12_DEVICE_TYPE, > .init_phy = imx7d_pcie_init_phy, > .set_ref_clk = imx7d_pcie_set_ref_clk, > + .core_reset = imx7d_pcie_core_reset, > }, > [IMX8MQ] = { > .variant = IMX8MQ, > > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD55EC4345F for ; Sat, 27 Apr 2024 10:20:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FqVOlQB1cvVQjo9R9aYAf2ZfpATV5oCMEa5kBia35O0=; b=fOLcDKw9VXGtD9 ixrmkRx+srarroKyA6IIN7AOEdMVpuUp2PFjQF/GGCXD7EkgYoJUpB8edfGqTFLgFoMkKQVaVxGUc 3IQvKyX9iDXk/0qzCvIGGgrex+2dxFevZFcBEUQ6q+lVkILlqRfw+yU7qIktrNnvvfl3+LOYXc3om 9567GOa6QpENydqijUQqi/Nrxm3BM58KiJTlc92ltbZk17Cb9HaWfq+bK6lwQhppz+wt8r1ELeobr KWqUp7zcAfIhbxXud9/LpXgtukDVDK4nY4jMDF94noynfKZXAzecJBinOE94oxQBIu3ZfahtHM1fo b+vWVbMpCGF4xN1OY62Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0fA8-0000000FItN-0Ghp; Sat, 27 Apr 2024 10:20:08 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0fA4-0000000FIsj-2gmg for linux-arm-kernel@lists.infradead.org; Sat, 27 Apr 2024 10:20:06 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2a2da57ab3aso2582327a91.3 for ; Sat, 27 Apr 2024 03:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714213203; x=1714818003; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=f7+iFYpps1zeYEBYcKhOBHRNG0fMT263PpJq0n4u0EE=; b=hTm97f8v9dr7uUChVuPAXMn3MjgUPE5uWFh9+Q/zqZMSPHekR8FYBEmfAtYkkeYi7E X+7QmIZnYjhk/uko3zAan0Ap5zAaKoRUEQIfuYrhNYyO7U4pFDRVzjKQmih0v+N66R5R I/P4kD/cGSqjpzlUDJIDW8222Kbp9XrW+qgpL1HjbLp8eaj0Pm81X+uh/EV3vd/rHXSe lbZdkqZvul/ie6gBtMeTNaq4izWgjMAYqalYJvHlNq0Ta83UmOcPI5jvJ70d5X4KQN3V tIF7LXrUXE1ONhD31D8CbbGjSDxsJq75uVuFr8Yb7h0xuucZBDPdZcBK9czSxafcAXbJ QCIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714213203; x=1714818003; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f7+iFYpps1zeYEBYcKhOBHRNG0fMT263PpJq0n4u0EE=; b=N2PISkAqa+8E3RHP2/FQAq1YOYwOu3OGUiagz8K15zQXiWvhWd3IKh8kj8XjJpBPa1 fDz7LA+H0ypQ9LTVd257O/sB0yWrXa2IG6Nc65BDp11yE6BMF8AF/Tsn2uc4vHPOs/uE lyek+jfDdRFd6JG0Wr0PdzjO2NccHtwDZmp90Kp8GJiWnHT/ygeKaoTK86KLY3wpz3uw RaepTin9B/hOTulWq/eZJBnQfBSNPiRcjmd7Om0VEZdIHIGjgl3zF7VQFFI+YU6fs9Qr Uqszj0bNcsbZ2xspzm5kEltl0TQNueZfbhfPFVSdykbccmkAPKzWCl0/LvmHSVvxfhV0 PKJA== X-Forwarded-Encrypted: i=1; AJvYcCVuFZv4oQ9VC5oUf1XlZDZD0GtwQL9jRzPufeauORR+yj3j5WqNaQS4NKbZuJL2eP5Tv4JK/A40AfrKLMf9BrTOqatbdcii/2AA6bPQgWVokNZ6W8k= X-Gm-Message-State: AOJu0YwE/LsRXHxUnDKKEjTDVikMhIsWSn/YhKqILfsLBl9NIFv4lEE2 /gZ5T8EbtXbp1+TdLAEaOp5XYwKq0y+T/fQgaHLFVf2J1CjbXpygb6qFzC1/e8Jf45APQFR66ek = X-Google-Smtp-Source: AGHT+IEYOZapJrU/m4SmvbbkI2Rqw/VHSc6hVCsBseOgu88lyFU9KKkSvde7eKI7fVNOcnbI0UpRCA== X-Received: by 2002:a17:90b:1d89:b0:2af:53c6:5fb0 with SMTP id pf9-20020a17090b1d8900b002af53c65fb0mr4651141pjb.28.1714213202995; Sat, 27 Apr 2024 03:20:02 -0700 (PDT) Received: from thinkpad ([117.213.97.210]) by smtp.gmail.com with ESMTPSA id e7-20020a17090a7c4700b002ad6b1e5b6fsm11013594pjl.56.2024.04.27.03.19.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 27 Apr 2024 03:20:02 -0700 (PDT) Date: Sat, 27 Apr 2024 15:49:50 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Krzysztof Kozlowski , Conor Dooley , linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 07/11] PCI: imx: Simplify switch-case logic by involve core_reset callback Message-ID: <20240427101950.GL1981@thinkpad> References: <20240402-pci2_upstream-v3-0-803414bdb430@nxp.com> <20240402-pci2_upstream-v3-7-803414bdb430@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240402-pci2_upstream-v3-7-803414bdb430@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_032004_893950_42B5A3CB X-CRM114-Status: GOOD ( 31.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBcHIgMDIsIDIwMjQgYXQgMTA6MzM6NDNBTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gSW5zdGVhZCBvZiB1c2luZyB0aGUgc3dpdGNoIGNhc2Ugc3RhdGVtZW50IHRvIGFzc2VydC9k YXNzZXJ0IHRoZSBjb3JlIHJlc2V0Cj4gaGFuZGxlZCBieSB0aGlzIGRyaXZlciBpdHNlbGYsIGxl dCdzIGludHJvZHVjZSBhIG5ldyBjYWxsYmFjayBjb3JlX3Jlc2V0KCkKPiBhbmQgZGVmaW5lIGl0 IGZvciBwbGF0Zm9ybXMgdGhhdCByZXF1aXJlIGl0LiBUaGlzIHNpbXBsaWZpZXMgdGhlIGNvZGUu Cj4gCj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaWUtaW14LmMgfCAxMzEgKysrKysrKysrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNjggaW5zZXJ0aW9ucygr KSwgNjMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvZHdjL3BjaWUtaW14LmMgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWlteC5j Cj4gaW5kZXggNzdkYWU1YzNmNzA1Ny4uYWYwZjk2MGYyODc1NyAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2llLWlteC5jCj4gKysrIGIvZHJpdmVycy9wY2kvY29u dHJvbGxlci9kd2MvcGNpZS1pbXguYwo+IEBAIC0xMDQsNiArMTA0LDcgQEAgc3RydWN0IGlteF9w Y2llX2RydmRhdGEgewo+ICAJY29uc3Qgc3RydWN0IHBjaV9lcGNfZmVhdHVyZXMgKmVwY19mZWF0 dXJlczsKPiAgCWludCAoKmluaXRfcGh5KShzdHJ1Y3QgaW14X3BjaWUgKnBjaWUpOwo+ICAJaW50 ICgqc2V0X3JlZl9jbGspKHN0cnVjdCBpbXhfcGNpZSAqcGNpZSwgYm9vbCBlbmFibGUpOwo+ICsJ aW50ICgqY29yZV9yZXNldCkoc3RydWN0IGlteF9wY2llICpwY2llLCBib29sIGFzc2VydCk7Cj4g IH07Cj4gIAo+ICBzdHJ1Y3QgaW14X3BjaWUgewo+IEBAIC02NzEsMzUgKzY3Miw3MiBAQCBzdGF0 aWMgdm9pZCBpbXhfcGNpZV9jbGtfZGlzYWJsZShzdHJ1Y3QgaW14X3BjaWUgKmlteF9wY2llKQo+ ICAJY2xrX2J1bGtfZGlzYWJsZV91bnByZXBhcmUoaW14X3BjaWUtPmRydmRhdGEtPmNsa3NfY250 LCBpbXhfcGNpZS0+Y2xrcyk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgaW14NnN4X3BjaWVfY29y ZV9yZXNldChzdHJ1Y3QgaW14X3BjaWUgKmlteF9wY2llLCBib29sIGFzc2VydCkKPiArewo+ICsJ cmVnbWFwX3VwZGF0ZV9iaXRzKGlteF9wY2llLT5pb211eGNfZ3ByLCBJT01VWENfR1BSMTIsIElN WDZTWF9HUFIxMl9QQ0lFX1RFU1RfUE9XRVJET1dOLAo+ICsJCQkgICBhc3NlcnQgPyBJTVg2U1hf R1BSMTJfUENJRV9URVNUX1BPV0VSRE9XTiA6IDApOwoKRWFybGllciwgdGhpcyByZWdpc3RlciB3 YXMgbm90IGNsZWFyZWQgZHVyaW5nIGRlYXNzZXJ0LiBJcyBpZiBmaW5lPwoKPiArCS8qIEZvcmNl IFBDSWUgUEhZIHJlc2V0ICovCj4gKwlyZWdtYXBfdXBkYXRlX2JpdHMoaW14X3BjaWUtPmlvbXV4 Y19ncHIsIElPTVVYQ19HUFI1LCBJTVg2U1hfR1BSNV9QQ0lFX0JUTlJTVF9SRVNFVCwKPiArCQkJ ICAgYXNzZXJ0ID8gSU1YNlNYX0dQUjVfUENJRV9CVE5SU1RfUkVTRVQgOiAwKTsKPiArCXJldHVy biAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50IGlteDZxcF9wY2llX2NvcmVfcmVzZXQoc3RydWN0 IGlteF9wY2llICppbXhfcGNpZSwgYm9vbCBhc3NlcnQpCj4gK3sKPiArCXJlZ21hcF91cGRhdGVf Yml0cyhpbXhfcGNpZS0+aW9tdXhjX2dwciwgSU9NVVhDX0dQUjEsIElNWDZRX0dQUjFfUENJRV9T V19SU1QsCj4gKwkJCSAgIGFzc2VydCA/IElNWDZRX0dQUjFfUENJRV9TV19SU1QgOiAwKTsKPiAr CWlmICghYXNzZXJ0KQo+ICsJCXVzbGVlcF9yYW5nZSgyMDAsIDUwMCk7Cj4gKwo+ICsJcmV0dXJu IDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgaW14NnFfcGNpZV9jb3JlX3Jlc2V0KHN0cnVjdCBp bXhfcGNpZSAqaW14X3BjaWUsIGJvb2wgYXNzZXJ0KQo+ICt7Cj4gKwlyZWdtYXBfdXBkYXRlX2Jp dHMoaW14X3BjaWUtPmlvbXV4Y19ncHIsIElPTVVYQ19HUFIxLCBJTVg2UV9HUFIxX1BDSUVfVEVT VF9QRCwKPiArCQkJICAgYXNzZXJ0ID8gSU1YNlFfR1BSMV9QQ0lFX1RFU1RfUEQgOiAwKTsKPiAr Cj4gKwlyZWdtYXBfdXBkYXRlX2JpdHMoaW14X3BjaWUtPmlvbXV4Y19ncHIsIElPTVVYQ19HUFIx LCBJTVg2UV9HUFIxX1BDSUVfUkVGX0NMS19FTiwKPiArCQkJICAgYXNzZXJ0ID8gMCA6IElNWDZR X0dQUjFfUENJRV9SRUZfQ0xLX0VOKTsKPiArCgpTYW1lIGNvbW1lbnQgYXMgYWJvdmUuCgo+ICsJ cmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgaW14N2RfcGNpZV9jb3JlX3Jlc2V0KHN0 cnVjdCBpbXhfcGNpZSAqaW14X3BjaWUsIGJvb2wgYXNzZXJ0KQo+ICt7Cj4gKwlzdHJ1Y3QgZHdf cGNpZSAqcGNpID0gaW14X3BjaWUtPnBjaTsKPiArCXN0cnVjdCBkZXZpY2UgKmRldiA9IHBjaS0+ ZGV2Owo+ICsKPiArCWlmIChhc3NlcnQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJLyoKPiArCSAq IFdvcmthcm91bmQgZm9yIEVSUjAxMDcyOCwgZmFpbHVyZSBvZiBQQ0ktZSBQTEwgVkNPIHRvIG9z Y2lsbGF0ZSwgZXNwZWNpYWxseSB3aGVuIGNvbGQuCgpXaGF0IGRvZXMgJ2VzcGVjaWFsbHkgd2hl biBjb2xkJyBtZWFucz8gSSBrbm93IGl0IGlzIGFuIG9sZCBjb21tZW50LCBidXQgc3RpbGwKaXQg aXMgbm90IHZlcnkgY2xlYXIuCgo+ICsJICogVGhpcyB0dXJucyBvZmYgIkR1dHktY3ljbGUgQ29y cmVjdG9yIiBhbmQgb3RoZXIgbXlzdGVyaW91cyB1bmRvY3VtZW50ZWQgdGhpbmdzLgoKU2FtZSBj b21tZW50IGFzIHByZXZpb3VzIHBhdGNoLgoKPiArCSAqLwo+ICsKPiArCWlmIChsaWtlbHkoaW14 X3BjaWUtPnBoeV9iYXNlKSkgewo+ICsJCS8qIERlLWFzc2VydCBEQ0NfRkJfRU4gKi8KPiArCQl3 cml0ZWwoUENJRV9QSFlfQ01OX1JFRzRfRENDX0ZCX0VOLCBpbXhfcGNpZS0+cGh5X2Jhc2UgKyBQ Q0lFX1BIWV9DTU5fUkVHNCk7Cj4gKwkJLyogQXNzZXJ0IFJYX0VRUyBhbmQgUlhfRVFTX1NFTCAq Lwo+ICsJCXdyaXRlbChQQ0lFX1BIWV9DTU5fUkVHMjRfUlhfRVFfU0VMIHwgUENJRV9QSFlfQ01O X1JFRzI0X1JYX0VRLAo+ICsJCSAgICAgICBpbXhfcGNpZS0+cGh5X2Jhc2UgKyBQQ0lFX1BIWV9D TU5fUkVHMjQpOwo+ICsJCS8qIEFzc2VydCBBVFRfTU9ERSAqLwo+ICsJCXdyaXRlbChQQ0lFX1BI WV9DTU5fUkVHMjZfQVRUX01PREUsIGlteF9wY2llLT5waHlfYmFzZSArIFBDSUVfUEhZX0NNTl9S RUcyNik7CgpXaHkgZG9lcyB0aGlzIHdvcmthcm91bmQgYSBwYXJ0IG9mIGNvcmVfcmVzZXQgaGFu ZGxpbmc/IFRoaXMgZnVuY3Rpb24gZG9lc24ndApsb29rIGxpa2UgcGVyZm9ybWluZyByZXNldCBh dCBhbGwuCgotIE1hbmkKCj4gKwl9IGVsc2Ugewo+ICsJCWRldl93YXJuKGRldiwgIlVuYWJsZSB0 byBhcHBseSBFUlIwMTA3Mjggd29ya2Fyb3VuZC4gRFQgbWlzc2luZyBmc2wsaW14N2QtcGNpZS1w aHkgcGhhbmRsZSA/XG4iKTsKPiArCX0KPiArCWlteDdkX3BjaWVfd2FpdF9mb3JfcGh5X3BsbF9s b2NrKGlteF9wY2llKTsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBpbXhf cGNpZV9hc3NlcnRfY29yZV9yZXNldChzdHJ1Y3QgaW14X3BjaWUgKmlteF9wY2llKQo+ICB7Cj4g IAlyZXNldF9jb250cm9sX2Fzc2VydChpbXhfcGNpZS0+cGNpZXBoeV9yZXNldCk7Cj4gIAlyZXNl dF9jb250cm9sX2Fzc2VydChpbXhfcGNpZS0+YXBwc19yZXNldCk7Cj4gIAo+IC0Jc3dpdGNoIChp bXhfcGNpZS0+ZHJ2ZGF0YS0+dmFyaWFudCkgewo+IC0JY2FzZSBJTVg2U1g6Cj4gLQkJcmVnbWFw X3VwZGF0ZV9iaXRzKGlteF9wY2llLT5pb211eGNfZ3ByLCBJT01VWENfR1BSMTIsCj4gLQkJCQkg ICBJTVg2U1hfR1BSMTJfUENJRV9URVNUX1BPV0VSRE9XTiwKPiAtCQkJCSAgIElNWDZTWF9HUFIx Ml9QQ0lFX1RFU1RfUE9XRVJET1dOKTsKPiAtCQkvKiBGb3JjZSBQQ0llIFBIWSByZXNldCAqLwo+ IC0JCXJlZ21hcF91cGRhdGVfYml0cyhpbXhfcGNpZS0+aW9tdXhjX2dwciwgSU9NVVhDX0dQUjUs Cj4gLQkJCQkgICBJTVg2U1hfR1BSNV9QQ0lFX0JUTlJTVF9SRVNFVCwKPiAtCQkJCSAgIElNWDZT WF9HUFI1X1BDSUVfQlROUlNUX1JFU0VUKTsKPiAtCQlicmVhazsKPiAtCWNhc2UgSU1YNlFQOgo+ IC0JCXJlZ21hcF91cGRhdGVfYml0cyhpbXhfcGNpZS0+aW9tdXhjX2dwciwgSU9NVVhDX0dQUjEs Cj4gLQkJCQkgICBJTVg2UV9HUFIxX1BDSUVfU1dfUlNULAo+IC0JCQkJICAgSU1YNlFfR1BSMV9Q Q0lFX1NXX1JTVCk7Cj4gLQkJYnJlYWs7Cj4gLQljYXNlIElNWDZROgo+IC0JCXJlZ21hcF91cGRh dGVfYml0cyhpbXhfcGNpZS0+aW9tdXhjX2dwciwgSU9NVVhDX0dQUjEsCj4gLQkJCQkgICBJTVg2 UV9HUFIxX1BDSUVfVEVTVF9QRCwgMSA8PCAxOCk7Cj4gLQkJcmVnbWFwX3VwZGF0ZV9iaXRzKGlt eF9wY2llLT5pb211eGNfZ3ByLCBJT01VWENfR1BSMSwKPiAtCQkJCSAgIElNWDZRX0dQUjFfUENJ RV9SRUZfQ0xLX0VOLCAwIDw8IDE2KTsKPiAtCQlicmVhazsKPiAtCWRlZmF1bHQ6Cj4gLQkJYnJl YWs7Cj4gLQl9Cj4gKwlpZiAoaW14X3BjaWUtPmRydmRhdGEtPmNvcmVfcmVzZXQpCj4gKwkJaW14 X3BjaWUtPmRydmRhdGEtPmNvcmVfcmVzZXQoaW14X3BjaWUsIHRydWUpOwo+ICAKPiAgCS8qIFNv bWUgYm9hcmRzIGRvbid0IGhhdmUgUENJZSByZXNldCBHUElPLiAqLwo+ICAJaWYgKGdwaW9faXNf dmFsaWQoaW14X3BjaWUtPnJlc2V0X2dwaW8pKQo+IEBAIC03MDksNDcgKzc0NywxMCBAQCBzdGF0 aWMgdm9pZCBpbXhfcGNpZV9hc3NlcnRfY29yZV9yZXNldChzdHJ1Y3QgaW14X3BjaWUgKmlteF9w Y2llKQo+ICAKPiAgc3RhdGljIGludCBpbXhfcGNpZV9kZWFzc2VydF9jb3JlX3Jlc2V0KHN0cnVj dCBpbXhfcGNpZSAqaW14X3BjaWUpCj4gIHsKPiAtCXN0cnVjdCBkd19wY2llICpwY2kgPSBpbXhf cGNpZS0+cGNpOwo+IC0Jc3RydWN0IGRldmljZSAqZGV2ID0gcGNpLT5kZXY7Cj4gLQo+ICAJcmVz ZXRfY29udHJvbF9kZWFzc2VydChpbXhfcGNpZS0+cGNpZXBoeV9yZXNldCk7Cj4gIAo+IC0Jc3dp dGNoIChpbXhfcGNpZS0+ZHJ2ZGF0YS0+dmFyaWFudCkgewo+IC0JY2FzZSBJTVg3RDoKPiAtCQkv KiBXb3JrYXJvdW5kIGZvciBFUlIwMTA3MjgsIGZhaWx1cmUgb2YgUENJLWUgUExMIFZDTyB0bwo+ IC0JCSAqIG9zY2lsbGF0ZSwgZXNwZWNpYWxseSB3aGVuIGNvbGQuICBUaGlzIHR1cm5zIG9mZiAi RHV0eS1jeWNsZQo+IC0JCSAqIENvcnJlY3RvciIgYW5kIG90aGVyIG15c3RlcmlvdXMgdW5kb2N1 bWVudGVkIHRoaW5ncy4KPiAtCQkgKi8KPiAtCQlpZiAobGlrZWx5KGlteF9wY2llLT5waHlfYmFz ZSkpIHsKPiAtCQkJLyogRGUtYXNzZXJ0IERDQ19GQl9FTiAqLwo+IC0JCQl3cml0ZWwoUENJRV9Q SFlfQ01OX1JFRzRfRENDX0ZCX0VOLAo+IC0JCQkgICAgICAgaW14X3BjaWUtPnBoeV9iYXNlICsg UENJRV9QSFlfQ01OX1JFRzQpOwo+IC0JCQkvKiBBc3NlcnQgUlhfRVFTIGFuZCBSWF9FUVNfU0VM ICovCj4gLQkJCXdyaXRlbChQQ0lFX1BIWV9DTU5fUkVHMjRfUlhfRVFfU0VMCj4gLQkJCQl8IFBD SUVfUEhZX0NNTl9SRUcyNF9SWF9FUSwKPiAtCQkJICAgICAgIGlteF9wY2llLT5waHlfYmFzZSAr IFBDSUVfUEhZX0NNTl9SRUcyNCk7Cj4gLQkJCS8qIEFzc2VydCBBVFRfTU9ERSAqLwo+IC0JCQl3 cml0ZWwoUENJRV9QSFlfQ01OX1JFRzI2X0FUVF9NT0RFLAo+IC0JCQkgICAgICAgaW14X3BjaWUt PnBoeV9iYXNlICsgUENJRV9QSFlfQ01OX1JFRzI2KTsKPiAtCQl9IGVsc2Ugewo+IC0JCQlkZXZf d2FybihkZXYsICJVbmFibGUgdG8gYXBwbHkgRVJSMDEwNzI4IHdvcmthcm91bmQuIERUIG1pc3Np bmcgZnNsLGlteDdkLXBjaWUtcGh5IHBoYW5kbGUgP1xuIik7Cj4gLQkJfQo+IC0KPiAtCQlpbXg3 ZF9wY2llX3dhaXRfZm9yX3BoeV9wbGxfbG9jayhpbXhfcGNpZSk7Cj4gLQkJYnJlYWs7Cj4gLQlj YXNlIElNWDZTWDoKPiAtCQlyZWdtYXBfdXBkYXRlX2JpdHMoaW14X3BjaWUtPmlvbXV4Y19ncHIs IElPTVVYQ19HUFI1LAo+IC0JCQkJICAgSU1YNlNYX0dQUjVfUENJRV9CVE5SU1RfUkVTRVQsIDAp Owo+IC0JCWJyZWFrOwo+IC0JY2FzZSBJTVg2UVA6Cj4gLQkJcmVnbWFwX3VwZGF0ZV9iaXRzKGlt eF9wY2llLT5pb211eGNfZ3ByLCBJT01VWENfR1BSMSwKPiAtCQkJCSAgIElNWDZRX0dQUjFfUENJ RV9TV19SU1QsIDApOwo+IC0KPiAtCQl1c2xlZXBfcmFuZ2UoMjAwLCA1MDApOwo+IC0JCWJyZWFr Owo+IC0JZGVmYXVsdDoKPiAtCQlicmVhazsKPiAtCX0KPiArCWlmIChpbXhfcGNpZS0+ZHJ2ZGF0 YS0+Y29yZV9yZXNldCkKPiArCQlpbXhfcGNpZS0+ZHJ2ZGF0YS0+Y29yZV9yZXNldChpbXhfcGNp ZSwgZmFsc2UpOwo+ICAKPiAgCS8qIFNvbWUgYm9hcmRzIGRvbid0IGhhdmUgUENJZSByZXNldCBH UElPLiAqLwo+ICAJaWYgKGdwaW9faXNfdmFsaWQoaW14X3BjaWUtPnJlc2V0X2dwaW8pKSB7Cj4g QEAgLTE0NDcsNiArMTQ0OCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW14X3BjaWVfZHJ2ZGF0 YSBkcnZkYXRhW10gPSB7Cj4gIAkJLm1vZGVfbWFza1swXSA9IElNWDZRX0dQUjEyX0RFVklDRV9U WVBFLAo+ICAJCS5pbml0X3BoeSA9IGlteF9wY2llX2luaXRfcGh5LAo+ICAJCS5zZXRfcmVmX2Ns ayA9IGlteDZxX3BjaWVfc2V0X3JlZl9jbGssCj4gKwkJLmNvcmVfcmVzZXQgPSBpbXg2cV9wY2ll X2NvcmVfcmVzZXQsCj4gIAl9LAo+ICAJW0lNWDZTWF0gPSB7Cj4gIAkJLnZhcmlhbnQgPSBJTVg2 U1gsCj4gQEAgLTE0NjIsNiArMTQ2NCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgaW14X3BjaWVf ZHJ2ZGF0YSBkcnZkYXRhW10gPSB7Cj4gIAkJLm1vZGVfbWFza1swXSA9IElNWDZRX0dQUjEyX0RF VklDRV9UWVBFLAo+ICAJCS5pbml0X3BoeSA9IGlteDZzeF9wY2llX2luaXRfcGh5LAo+ICAJCS5z ZXRfcmVmX2NsayA9IGlteDZzeF9wY2llX3NldF9yZWZfY2xrLAo+ICsJCS5jb3JlX3Jlc2V0ID0g aW14NnN4X3BjaWVfY29yZV9yZXNldCwKPiAgCX0sCj4gIAlbSU1YNlFQXSA9IHsKPiAgCQkudmFy aWFudCA9IElNWDZRUCwKPiBAQCAtMTQ3OCw2ICsxNDgxLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVj dCBpbXhfcGNpZV9kcnZkYXRhIGRydmRhdGFbXSA9IHsKPiAgCQkubW9kZV9tYXNrWzBdID0gSU1Y NlFfR1BSMTJfREVWSUNFX1RZUEUsCj4gIAkJLmluaXRfcGh5ID0gaW14X3BjaWVfaW5pdF9waHks Cj4gIAkJLnNldF9yZWZfY2xrID0gaW14NnFfcGNpZV9zZXRfcmVmX2NsaywKPiArCQkuY29yZV9y ZXNldCA9IGlteDZxcF9wY2llX2NvcmVfcmVzZXQsCj4gIAl9LAo+ICAJW0lNWDdEXSA9IHsKPiAg CQkudmFyaWFudCA9IElNWDdELAo+IEBAIC0xNDkxLDYgKzE0OTUsNyBAQCBzdGF0aWMgY29uc3Qg c3RydWN0IGlteF9wY2llX2RydmRhdGEgZHJ2ZGF0YVtdID0gewo+ICAJCS5tb2RlX21hc2tbMF0g PSBJTVg2UV9HUFIxMl9ERVZJQ0VfVFlQRSwKPiAgCQkuaW5pdF9waHkgPSBpbXg3ZF9wY2llX2lu aXRfcGh5LAo+ICAJCS5zZXRfcmVmX2NsayA9IGlteDdkX3BjaWVfc2V0X3JlZl9jbGssCj4gKwkJ LmNvcmVfcmVzZXQgPSBpbXg3ZF9wY2llX2NvcmVfcmVzZXQsCj4gIAl9LAo+ICAJW0lNWDhNUV0g PSB7Cj4gIAkJLnZhcmlhbnQgPSBJTVg4TVEsCj4gCj4gLS0gCj4gMi4zNC4xCj4gCgotLSAK4K6u 4K6j4K6/4K614K6j4K+N4K6j4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=