From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D622C4345F for ; Sat, 27 Apr 2024 14:56:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 15A0960772; Sat, 27 Apr 2024 14:56:32 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Seiqf6yHljAt; Sat, 27 Apr 2024 14:56:30 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org BA0A06076C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1714229790; bh=amB1hYPTQMfz40I+7JQXi5CGkpHsd144kXjd3wF8N4k=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ArhdgDBpE95hu+tFT2f12qp0iKqpdmtWf89Qb5iz3vwwwvvNslPVFf+qRPPi4R5v5 8WGmIkDlCjico+8QawgqzTG2p3RwzmQqonZkEOzgTYG6fbUzZTwtiaU0Mr1jkPbcTh Kyx/YLhptDHkYHlLw1KpFhIhe9VbckoGuWIoA8hSV/bfvi304LT5HRaMlIDXyB7ykj iQI28MHzbSJoFkcHIvEzQDgVX4XTthtM6oIqlLF1z50yf/R7L1W8cylwLadVbLz64P Hg5Nx5nfztkIlbybGqfDFGfwVxwoG1fylsWMgJl/SPbBZIEGOg+Y+ho2PTjNbWIBjl 5jPJnHJ1kmJ9w== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id BA0A06076C; Sat, 27 Apr 2024 14:56:30 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 693F91BF3DD for ; Sat, 27 Apr 2024 14:56:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6054C40726 for ; Sat, 27 Apr 2024 14:56:29 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id egatyN2zpnbp for ; Sat, 27 Apr 2024 14:56:28 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 588034070B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 588034070B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id 588034070B for ; Sat, 27 Apr 2024 14:56:27 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4C363CE098F; Sat, 27 Apr 2024 14:56:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D17CEC113CE; Sat, 27 Apr 2024 14:56:21 +0000 (UTC) Date: Sat, 27 Apr 2024 15:56:19 +0100 From: Simon Horman To: Ivan Vecera Message-ID: <20240427145619.GO516117@kernel.org> References: <20240427072615.226151-1-ivecera@redhat.com> <20240427072615.226151-3-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427072615.226151-3-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714229784; bh=tKS6xrGJ1Q6azSgyWQazosphPUvdjtA4NX2ju1bSK74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHoB1BdoceXwUmEQxyX8i+4FOzlX0LepVXbv26RufCYZn9aNw/ZhaguAkeRIbZzKr t1JblNpvmPFewskVT8w/AEgsPXdYn31KDpHgf5byGjR3WK4CQb4CHaJX4p75l9bd8l /wuUY4MFSb5oZglQLz7167uE/3bJjgkK/htMj/m/87LgwM6JqcrBd1YJHBBaZOWxGh d26O8DIW1aROZbytZERsS53yvqmMX26AmrDsaCedxvHIpAykm85ugrXXjZHh/Fv3JM 6CvEXbbkRf7TMescpl/BXFPXYIxwoRe+3GDfvqOhKAzyV/2b3hty1vJbG25e1yJFUZ hQFjiUdBss/9A== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=EHoB1Bdo Subject: Re: [Intel-wired-lan] [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pucha Himasekhar Reddy , netdev@vger.kernel.org, open list , Eric Dumazet , Tony Nguyen , "moderated list:INTEL ETHERNET DRIVERS" , Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Apr 27, 2024 at 09:26:03AM +0200, Ivan Vecera wrote: > Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified > the client interface so in practice it supports only one client > per i40e netdev. But we have still 2 notification functions that > uses as parameter a pointer to VSI of netdevice associated with > the client. After the mentioned commit only possible and used > VSI is the main (LAN) VSI. > So refactor these functions so they are called with PF pointer argument > and the associated VSI (LAN) is taken inside them. > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98275817; Sat, 27 Apr 2024 14:56:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229784; cv=none; b=RujzZ0rDQzAkUmnm63byl/uWvDGeUx6v3eWTvYuVPDdeABWR5i7zk5dBpeJYlfs85nxtyUvcip36TD4oVKy7OgyAzobIk3AFsxLZ+pyJXyfNGANpkRlcbotDsGvfXUkGOxLyK4ctau6hE+I5B63IpUkk6RIY52wv+hsyN6guj54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229784; c=relaxed/simple; bh=tKS6xrGJ1Q6azSgyWQazosphPUvdjtA4NX2ju1bSK74=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=m0zi/dfwezcVLpJH5qEDEM1Vx00mJWVFuEE17Aq21sjJrDZC7QgYiYik+y6Wlc9hlE9pCbvGxb1uJ9XN2+X1gZqxrfA+feDEc1QRm9k6cayPbsdavWtVt+ATn8zjN2oDQ5l2shH2VjXIGYOfzJxacIbbxbcAMPiNZ4+i1nodGgA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=EHoB1Bdo; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="EHoB1Bdo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D17CEC113CE; Sat, 27 Apr 2024 14:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714229784; bh=tKS6xrGJ1Q6azSgyWQazosphPUvdjtA4NX2ju1bSK74=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EHoB1BdoceXwUmEQxyX8i+4FOzlX0LepVXbv26RufCYZn9aNw/ZhaguAkeRIbZzKr t1JblNpvmPFewskVT8w/AEgsPXdYn31KDpHgf5byGjR3WK4CQb4CHaJX4p75l9bd8l /wuUY4MFSb5oZglQLz7167uE/3bJjgkK/htMj/m/87LgwM6JqcrBd1YJHBBaZOWxGh d26O8DIW1aROZbytZERsS53yvqmMX26AmrDsaCedxvHIpAykm85ugrXXjZHh/Fv3JM 6CvEXbbkRf7TMescpl/BXFPXYIxwoRe+3GDfvqOhKAzyV/2b3hty1vJbG25e1yJFUZ hQFjiUdBss/9A== Date: Sat, 27 Apr 2024 15:56:19 +0100 From: Simon Horman To: Ivan Vecera Cc: netdev@vger.kernel.org, Michal Schmidt , Tony Nguyen , Pucha Himasekhar Reddy , Jesse Brandeburg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net-next v4 2/7] i40e: Refactor argument of several client notification functions Message-ID: <20240427145619.GO516117@kernel.org> References: <20240427072615.226151-1-ivecera@redhat.com> <20240427072615.226151-3-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427072615.226151-3-ivecera@redhat.com> On Sat, Apr 27, 2024 at 09:26:03AM +0200, Ivan Vecera wrote: > Commit 0ef2d5afb12d ("i40e: KISS the client interface") simplified > the client interface so in practice it supports only one client > per i40e netdev. But we have still 2 notification functions that > uses as parameter a pointer to VSI of netdevice associated with > the client. After the mentioned commit only possible and used > VSI is the main (LAN) VSI. > So refactor these functions so they are called with PF pointer argument > and the associated VSI (LAN) is taken inside them. > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman