From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4A9BC10F16 for ; Sat, 27 Apr 2024 14:56:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A04A4607D3; Sat, 27 Apr 2024 14:56:56 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id aKmT4pWeQcL4; Sat, 27 Apr 2024 14:56:56 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1A6756076C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1714229816; bh=SAvWi28tS9Fzn0xXe26WIQie+hHDCS4rBZm/RVjXBGw=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=PHpvy/xQyk0/BeJuMhhn+Io7UHBrMCrZhvgdXsmh2rAx1ya8qkadYMimldauAImSE GdEYGadIoQfzsFatrmw0DI/J9JD/wSlVif38Ig/jdenysA/MT6ChR7oawgdYsFk7ZO ngD9w87vIup0KQw4uKbeM+g0dTvPE1cBurIBWJzTFFv5JzzZ23HGMXMnhlIIG8iJrN E4VQdPHQ/+fncfrEHr+VLZGmDWwwCnNXfvYiR/v3YO1wTqccAUQcW0Tm9QRDsMhx2X C2loy5FQV4BFhW9kK2waIkwo7Do/eAZ3DqaYAqDhoeWIsTkvKETHChHW7eyMS826u6 9FrhPGz9Rin2Q== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 1A6756076C; Sat, 27 Apr 2024 14:56:56 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 110581BF3DD for ; Sat, 27 Apr 2024 14:56:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id F0EF760772 for ; Sat, 27 Apr 2024 14:56:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id TPWewOKmqz6M for ; Sat, 27 Apr 2024 14:56:53 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=145.40.73.55; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 3F7C4606E9 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3F7C4606E9 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3F7C4606E9 for ; Sat, 27 Apr 2024 14:56:53 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0133BCE1A4A; Sat, 27 Apr 2024 14:56:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DF92C2BD10; Sat, 27 Apr 2024 14:56:47 +0000 (UTC) Date: Sat, 27 Apr 2024 15:56:45 +0100 From: Simon Horman To: Ivan Vecera Message-ID: <20240427145645.GQ516117@kernel.org> References: <20240427072615.226151-1-ivecera@redhat.com> <20240427072615.226151-6-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427072615.226151-6-ivecera@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714229810; bh=f75jXn+JImVzW04XSBfpbAqM9Xc3DVOREU6CXnC59uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cv6mmH0FaySGo8/F3+Qfou1j8kxBPCoudQ1Xqj6l1pidEVhFDbr/Zgl8NBaJbUlCh uBMbKw3l/dtFsX9tgChPvU/l2vy1pnr0WbY1HY2uGaZ082qWYeKbUDQg5lkZdUcugq 0uCPJGoe3JbRAVm4KNBb5UjdkdCq7L/9mrxTJqK3n4gzjIAqqAa1V8AelfmkwJFsQS Q5bk4nw8RaTiz3vUK7cPD85qs2/OmYUAMVSGNJAHrqqLnHGdZferHqu3sjCkZDhStd TvvQ4vpuDJAo7MhIDgkO+3xzQVkIwDnVD+yWIoGTKL8Qq2wm03SLfIeXwvMkJ75mMx ispyGRaEb03/Q== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=cv6mmH0F Subject: Re: [Intel-wired-lan] [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pucha Himasekhar Reddy , netdev@vger.kernel.org, open list , Eric Dumazet , Tony Nguyen , "moderated list:INTEL ETHERNET DRIVERS" , Jakub Kicinski , Paolo Abeni , "David S. Miller" Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, Apr 27, 2024 at 09:26:06AM +0200, Ivan Vecera wrote: > In the driver code there are 3 types of checks whether given > VSI is main or not: > 1. vsi->type ==/!= I40E_VSI_MAIN > 2. vsi ==/!= pf->vsi[pf->lan_vsi] > 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid > > All of them are equivalent and can be consolidated. Convert cases > 2 and 3 to case 1. > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93E1C5660; Sat, 27 Apr 2024 14:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229810; cv=none; b=r4ufM4R23cKD3b1h6MBXqM3C5Bx2FV5J+ZD0rFm+jFosZkYvkTv5vP2K7/ZHdeCTdQVIK1GgfrIgFlsmVlwqFDPXNcZxXIPiv6NyFKqeV31dd22EV7EFn49W3ogDX6H0OHXArVADLXnqv1l/q64yvOYmBjTQJKgRMUf4pNmM/k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714229810; c=relaxed/simple; bh=f75jXn+JImVzW04XSBfpbAqM9Xc3DVOREU6CXnC59uY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Eey0OAQlzfGvAO75m1tr+KQ/mnkPYaiXZv52k9CioWBRZPnowqN339n19gIu/4cH1kOoirYekGOsfDdhKVWuojuFA9dQuzHbTqqUVUOjpdiHDPJoMtakc0XR7uUeeT6S6P5g2cvuq7XIfmpjWkoAJH6myAciktPN9L0ShBbTcS8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cv6mmH0F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cv6mmH0F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DF92C2BD10; Sat, 27 Apr 2024 14:56:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1714229810; bh=f75jXn+JImVzW04XSBfpbAqM9Xc3DVOREU6CXnC59uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cv6mmH0FaySGo8/F3+Qfou1j8kxBPCoudQ1Xqj6l1pidEVhFDbr/Zgl8NBaJbUlCh uBMbKw3l/dtFsX9tgChPvU/l2vy1pnr0WbY1HY2uGaZ082qWYeKbUDQg5lkZdUcugq 0uCPJGoe3JbRAVm4KNBb5UjdkdCq7L/9mrxTJqK3n4gzjIAqqAa1V8AelfmkwJFsQS Q5bk4nw8RaTiz3vUK7cPD85qs2/OmYUAMVSGNJAHrqqLnHGdZferHqu3sjCkZDhStd TvvQ4vpuDJAo7MhIDgkO+3xzQVkIwDnVD+yWIoGTKL8Qq2wm03SLfIeXwvMkJ75mMx ispyGRaEb03/Q== Date: Sat, 27 Apr 2024 15:56:45 +0100 From: Simon Horman To: Ivan Vecera Cc: netdev@vger.kernel.org, Michal Schmidt , Tony Nguyen , Pucha Himasekhar Reddy , Jesse Brandeburg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net-next v4 5/7] i40e: Consolidate checks whether given VSI is main Message-ID: <20240427145645.GQ516117@kernel.org> References: <20240427072615.226151-1-ivecera@redhat.com> <20240427072615.226151-6-ivecera@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240427072615.226151-6-ivecera@redhat.com> On Sat, Apr 27, 2024 at 09:26:06AM +0200, Ivan Vecera wrote: > In the driver code there are 3 types of checks whether given > VSI is main or not: > 1. vsi->type ==/!= I40E_VSI_MAIN > 2. vsi ==/!= pf->vsi[pf->lan_vsi] > 3. vsi->seid ==/!= pf->vsi[pf->lan_vsi]->seid > > All of them are equivalent and can be consolidated. Convert cases > 2 and 3 to case 1. > > Reviewed-by: Michal Schmidt > Reviewed-by: Tony Nguyen > Tested-by: Pucha Himasekhar Reddy > Signed-off-by: Ivan Vecera Reviewed-by: Simon Horman