From: Stephen Hemminger <stephen@networkplumber.org>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "Mattias Rönnblom" <hofors@lysator.liu.se>,
"Ferruh Yigit" <ferruh.yigit@amd.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org, stable@dpdk.org,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe
Date: Mon, 29 Apr 2024 08:33:45 -0700 [thread overview]
Message-ID: <20240429083345.4a2be5af@hermes.local> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3FF@smartserver.smartshare.dk>
On Mon, 29 Apr 2024 08:20:13 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> > turn talk the control plane, which in turn would talk to the data plane
> > (including <rte_ethdev.h>).
> >
> > Either the control plane or the O&M layer could keep track of a reset
> > offset. Doesn't have to be on the PMD level.
>
> Exactly.
>
> Snapshotting the "reset" offset in the control plane has many advantages.
>
> Let's promote that design pattern, rather than trying to work around different quirks required by different drivers.
>
The other thing that can help in software drivers is keeping per-queue stats.
next prev parent reply other threads:[~2024-04-29 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 16:53 [PATCH] ethdev: document that stats reset APIs are not thread-safe Ferruh Yigit
2024-04-26 12:20 ` Morten Brørup
2024-04-26 15:13 ` Stephen Hemminger
2024-04-26 15:17 ` Morten Brørup
2024-04-26 22:57 ` Stephen Hemminger
2024-04-28 15:52 ` Mattias Rönnblom
2024-04-29 6:20 ` Morten Brørup
2024-04-29 15:33 ` Stephen Hemminger [this message]
2024-04-28 15:48 ` Mattias Rönnblom
2024-04-29 7:57 ` Morten Brørup
2024-04-29 9:30 ` Mattias Rönnblom
2024-04-26 21:33 ` Patrick Robb
2024-10-04 22:27 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429083345.4a2be5af@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hofors@lysator.liu.se \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.