From: Kees Cook <keescook@chromium.org>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: "Christian Brauner" <brauner@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Shengyu Li" <shengyu.li.evgeny@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Günther Noack" <gnoack@google.com>,
"Will Drewry" <wad@chromium.org>,
"kernel test robot" <oliver.sang@intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 7/9] selftests/pidfd: Fix wrong expectation
Date: Mon, 29 Apr 2024 08:56:19 -0700 [thread overview]
Message-ID: <202404290855.34806C9@keescook> (raw)
In-Reply-To: <20240429130931.2394118-8-mic@digikod.net>
On Mon, Apr 29, 2024 at 03:09:29PM +0200, Mickaël Salaün wrote:
> Replace a wrong EXPECT_GT(self->child_pid_exited, 0) with EXPECT_GE(),
> which will be actually tested on the parent and child sides with a
> following commit.
>
> Cc: Christian Brauner <brauner@kernel.org>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Shuah Khan <skhan@linuxfoundation.org>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
I had to take a closer look at this one -- but yes, this should be just
checking for failure (negative). The parent/child separation is
afterwards.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2024-04-29 15:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 13:09 [PATCH v2 0/5] Fix Kselftest's vfork() side effects Mickaël Salaün
2024-04-29 13:09 ` [PATCH v2 1/9] selftests/pidfd: Fix config for pidfd_setns_test Mickaël Salaün
2024-04-29 13:09 ` [PATCH v2 2/9] selftests/landlock: Fix FS tests when run on a private mount point Mickaël Salaün
2024-04-29 13:09 ` [PATCH v2 3/9] selftests/harness: Fix fixture teardown Mickaël Salaün
2024-04-29 13:09 ` [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions Mickaël Salaün
2024-04-29 15:52 ` Kees Cook
2024-04-29 17:16 ` Jakub Kicinski
2024-04-29 19:18 ` Mickaël Salaün
2024-04-29 13:09 ` [PATCH v2 5/9] selftests/landlock: Do not allocate memory in fixture data Mickaël Salaün
2024-04-29 15:52 ` Kees Cook
2024-04-29 13:09 ` [PATCH v2 6/9] selftests/harness: Constify fixture variants Mickaël Salaün
2024-04-29 15:53 ` Kees Cook
2024-04-29 13:09 ` [PATCH v2 7/9] selftests/pidfd: Fix wrong expectation Mickaël Salaün
2024-04-29 15:56 ` Kees Cook [this message]
2024-04-29 13:09 ` [PATCH v2 8/9] selftests/harness: Share _metadata between forked processes Mickaël Salaün
2024-04-29 15:56 ` Kees Cook
2024-04-29 13:09 ` [PATCH v2 9/9] selftests/harness: Fix vfork() side effects Mickaël Salaün
2024-04-29 15:57 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404290855.34806C9@keescook \
--to=keescook@chromium.org \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=gnoack@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mic@digikod.net \
--cc=oliver.sang@intel.com \
--cc=shengyu.li.evgeny@gmail.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=wad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.