From: Ian Rogers <irogers@google.com>
To: Kan Liang <kan.liang@linux.intel.com>,
Thomas Richter <tmricht@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <rdunlap@infradead.org>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
James Clark <james.clark@arm.com>,
Ravi Bangoria <ravi.bangoria@amd.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org
Cc: Ian Rogers <irogers@google.com>
Subject: [PATCH v3 0/6] Assume sysfs event names are always the same case
Date: Mon, 29 Apr 2024 13:02:19 -0700 [thread overview]
Message-ID: <20240429200225.1271876-1-irogers@google.com> (raw)
By assuming sysfs events are either upper or lower case, the case
insensitive event parsing can probe for the existence of files rather
then loading all events in a directory. When the event is a json event
like inst_retired.any on Intel, this reduces the number of openat
calls on a Tigerlake laptop from 325 down to 255.
v1 sent as an RFC:
https://lore.kernel.org/lkml/20240413040812.4042051-1-irogers@google.com/
v2: addresses review feedback from Kan Liang, by updating
documentation and adding tests.
v3: incorporate feedback from Thomas Richter <tmricht@linux.ibm.com>
that s390 event names are all upper case. Do a lower case probe
then an upper case probe, make documentation and tests also agree.
Ian Rogers (6):
perf test pmu-events: Make it clearer that pmu-events tests json
events
perf Document: Sysfs event names must be lower or upper case
perf test pmu: Refactor format test and exposed test APIs
perf test pmu: Add an eagerly loaded event test
perf test pmu: Test all sysfs PMU event names are the same case
perf pmu: Assume sysfs events are always the same case
.../sysfs-bus-event_source-devices-events | 6 +
tools/perf/tests/pmu-events.c | 2 +-
tools/perf/tests/pmu.c | 457 ++++++++++++------
tools/perf/util/parse-events.c | 2 +-
tools/perf/util/parse-events.h | 2 +-
tools/perf/util/pmu.c | 111 +++--
tools/perf/util/pmu.h | 4 +-
tools/perf/util/pmus.c | 16 +-
tools/perf/util/pmus.h | 2 +
9 files changed, 405 insertions(+), 197 deletions(-)
--
2.44.0.769.g3c40516874-goog
next reply other threads:[~2024-04-29 20:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 20:02 Ian Rogers [this message]
2024-04-29 20:02 ` [PATCH v3 1/6] perf test pmu-events: Make it clearer that pmu-events tests json events Ian Rogers
2024-04-29 20:02 ` [PATCH v3 2/6] perf Document: Sysfs event names must be lower or upper case Ian Rogers
2024-04-29 20:02 ` [PATCH v3 3/6] perf test pmu: Refactor format test and exposed test APIs Ian Rogers
2024-05-01 3:06 ` kernel test robot
2024-04-29 20:02 ` [PATCH v3 4/6] perf test pmu: Add an eagerly loaded event test Ian Rogers
2024-05-01 3:05 ` kernel test robot
2024-04-29 20:02 ` [PATCH v3 5/6] perf test pmu: Test all sysfs PMU event names are the same case Ian Rogers
2024-04-29 20:02 ` [PATCH v3 6/6] perf pmu: Assume sysfs events are always " Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429200225.1271876-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=james.clark@arm.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@amd.com \
--cc=rdunlap@infradead.org \
--cc=renyu.zj@linux.alibaba.com \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.