From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91BF0770F5; Tue, 30 Apr 2024 15:40:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714491657; cv=none; b=VoAODF7EX3AK9dANg3177nulZfnEh1YTMkIpkGuolaInGhz3CoKSPW2CElQK/zqbptvcEZ2IBGBtdjSenwXnQpXjjiaKgLH+zPoTmuOOHUm7BZtEbRCrn4n7OPeCke8EyM9os229vyZqQLuacjsLxgQlf8yFrkBEFV4WBQbL23I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714491657; c=relaxed/simple; bh=Bqw3IsZ8vcRPqDodfPPnFBRWgVK31l21uLdf4lwzVEM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=j/Y6zyQ+mC9p6bbQ1rgnDjGPKrDpzJrD0nCDSouu1Yp8EUZhkfVKaQviGMXp/skd6tPmgIZo5hQd4PGZdcijHfGj45r1c2s4wEGd7ZzwWqCa6ZtCEM6B14FFn8VyARi3bzU6e3Mbu/SD1Muqxn5mDn3ucmuYwcM3DXrblM1DC0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=VMh3nULY; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="VMh3nULY" Received: by mail.gandi.net (Postfix) with ESMTPSA id 4733C1C0003; Tue, 30 Apr 2024 15:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1714491647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G0CBebPXkOcJbQJyeGur7JrerjS7KJc+NjEpyOTbDoI=; b=VMh3nULYKBzJIBVAFVTlMWkdIcZ+reJKsiZ0V0jPi72UTrWXlChhWgDXg3eE9SIA85Wl2j VczEh72WUPIYeF0/qlHU2dA5NvL58G4x10XgWKFuBVBxgqnhvAx3fJAYfak1fX9mOVzqma L7tkgp4biVVl6gyO5P1TGLI0XlALQkbEGUnoOlgZ75P4ycMfbBUnS/dXCjpkbfIylprdWs Mma8zxDmSadEn9l2NsiYXyRcHBL04zgrkRe9hKDVtVCGPYKW5y4rQeCXDLq6S9+Yxc8jAY V4mP/TKsCe04bwwjflLmyosk8vsxalY7bsE5QxkVnIQdgLYzGaiJZ7WmN8fb5Q== Date: Tue, 30 Apr 2024 17:40:44 +0200 From: Herve Codina To: Andrew Lunn Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset Message-ID: <20240430174044.606c2ed4@bootlin.com> In-Reply-To: <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-8-herve.codina@bootlin.com> <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Andrew, On Tue, 30 Apr 2024 15:46:18 +0200 Andrew Lunn wrote: > On Tue, Apr 30, 2024 at 10:37:16AM +0200, Herve Codina wrote: > > The mscc-miim device can be impacted by the switch reset, at least when > > this device is part of the LAN966x PCI device. > > Just to be sure i understand this correctly. The MDIO bus master can > be reset using the "switch" reset. So you are adding code to ensure > the "switch" reset is out of reset state, so the MDIO bus master > works. Exactly. > > Given that this is a new property, maybe give it a better name to > indicate it resets both the switch and the MDIO bus master? > Replied in the patch in the same series introducing the property [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property Thanks for the feedback. Best regards, Hervé From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FB56C4345F for ; Tue, 30 Apr 2024 15:41:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/O8fb8C9FE0t0SBEfK7wtBCtacC6YYRg38ukbml2yEk=; b=RAs39vbf9uhJJk Etc5fmI05eeL974nLCWuRyq8oT9LYb5RBaTV75iPnC3XOEaGaKaZLTR69LCWFzcGvnjva5ryiXsEK CmGJcfIbDuIHjyuPVz9jJ6F1kzN0wWj9Zi6/iHVookKD7/eqLybMqQ75X8v07dOFacVCqn2eks3hP T0X66W2RruboWYzBV4FmGdEcsPPD0PX3jmqxQcSrJlD6by428EcVYLvUdL4U7tQOPifb1tWHi1QdB fN1Veqj6if8wPY+HoA4v+s7y2RiSN0oufaATauExhQYuoWMycW1pGe21+mHnjXwtm1unz/pGB1IfC KQc5iC4a4gAuFGCcnQdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1pbE-000000075QW-008q; Tue, 30 Apr 2024 15:40:56 +0000 Received: from relay5-d.mail.gandi.net ([2001:4b98:dc4:8::225]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s1pbA-000000075Mb-3In1 for linux-arm-kernel@lists.infradead.org; Tue, 30 Apr 2024 15:40:54 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4733C1C0003; Tue, 30 Apr 2024 15:40:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1714491647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G0CBebPXkOcJbQJyeGur7JrerjS7KJc+NjEpyOTbDoI=; b=VMh3nULYKBzJIBVAFVTlMWkdIcZ+reJKsiZ0V0jPi72UTrWXlChhWgDXg3eE9SIA85Wl2j VczEh72WUPIYeF0/qlHU2dA5NvL58G4x10XgWKFuBVBxgqnhvAx3fJAYfak1fX9mOVzqma L7tkgp4biVVl6gyO5P1TGLI0XlALQkbEGUnoOlgZ75P4ycMfbBUnS/dXCjpkbfIylprdWs Mma8zxDmSadEn9l2NsiYXyRcHBL04zgrkRe9hKDVtVCGPYKW5y4rQeCXDLq6S9+Yxc8jAY V4mP/TKsCe04bwwjflLmyosk8vsxalY7bsE5QxkVnIQdgLYzGaiJZ7WmN8fb5Q== Date: Tue, 30 Apr 2024 17:40:44 +0200 From: Herve Codina To: Andrew Lunn Cc: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 07/17] net: mdio: mscc-miim: Handle the switch reset Message-ID: <20240430174044.606c2ed4@bootlin.com> In-Reply-To: <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-8-herve.codina@bootlin.com> <74e40e5d-e71f-4909-811e-7e9fc1120360@lunn.ch> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240430_084053_278438_85C4E75E X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQW5kcmV3LAoKT24gVHVlLCAzMCBBcHIgMjAyNCAxNTo0NjoxOCArMDIwMApBbmRyZXcgTHVu biA8YW5kcmV3QGx1bm4uY2g+IHdyb3RlOgoKPiBPbiBUdWUsIEFwciAzMCwgMjAyNCBhdCAxMDoz NzoxNkFNICswMjAwLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBUaGUgbXNjYy1taWltIGRldmlj ZSBjYW4gYmUgaW1wYWN0ZWQgYnkgdGhlIHN3aXRjaCByZXNldCwgYXQgbGVhc3Qgd2hlbgo+ID4g dGhpcyBkZXZpY2UgaXMgcGFydCBvZiB0aGUgTEFOOTY2eCBQQ0kgZGV2aWNlLiAgCj4gCj4gSnVz dCB0byBiZSBzdXJlIGkgdW5kZXJzdGFuZCB0aGlzIGNvcnJlY3RseS4gVGhlIE1ESU8gYnVzIG1h c3RlciBjYW4KPiBiZSByZXNldCB1c2luZyB0aGUgInN3aXRjaCIgcmVzZXQuIFNvIHlvdSBhcmUg YWRkaW5nIGNvZGUgdG8gZW5zdXJlCj4gdGhlICJzd2l0Y2giIHJlc2V0IGlzIG91dCBvZiByZXNl dCBzdGF0ZSwgc28gdGhlIE1ESU8gYnVzIG1hc3Rlcgo+IHdvcmtzLgoKRXhhY3RseS4KCj4gCj4g R2l2ZW4gdGhhdCB0aGlzIGlzIGEgbmV3IHByb3BlcnR5LCBtYXliZSBnaXZlIGl0IGEgYmV0dGVy IG5hbWUgdG8KPiBpbmRpY2F0ZSBpdCByZXNldHMgYm90aCB0aGUgc3dpdGNoIGFuZCB0aGUgTURJ TyBidXMgbWFzdGVyPwo+IAoKUmVwbGllZCBpbiB0aGUgcGF0Y2ggaW4gdGhlIHNhbWUgc2VyaWVz IGludHJvZHVjaW5nIHRoZSBwcm9wZXJ0eQogIFtQQVRDSCAwNi8xN10gZHQtYmluZGluZ3M6IG5l dDogbXNjYy1taWltOiBBZGQgcmVzZXRzIHByb3BlcnR5CgpUaGFua3MgZm9yIHRoZSBmZWVkYmFj ay4KQmVzdCByZWdhcmRzLApIZXJ2w6kKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK