From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Shailend Chand <shailend@google.com>
Cc: <netdev@vger.kernel.org>, <almasrymina@google.com>,
<davem@davemloft.net>, <edumazet@google.com>,
<hramamurthy@google.com>, <jeroendb@google.com>,
<kuba@kernel.org>, <pabeni@redhat.com>, <pkaligineedi@google.com>,
<willemb@google.com>
Subject: Re: [PATCH net-next 03/10] gve: Add adminq funcs to add/remove a single Rx queue
Date: Wed, 1 May 2024 09:49:30 +0530 [thread overview]
Message-ID: <20240501041930.GA72628@maili.marvell.com> (raw)
In-Reply-To: <20240430231420.699177-4-shailend@google.com>
On 2024-05-01 at 04:44:12, Shailend Chand (shailend@google.com) wrote:
> +int gve_adminq_destroy_single_rx_queue(struct gve_priv *priv, u32 queue_index)
> +{
> + union gve_adminq_command cmd;
> + int err;
> +
> + gve_adminq_make_destroy_rx_queue_cmd(&cmd, queue_index);
> + err = gve_adminq_execute_cmd(priv, &cmd);
> + if (err)
why can't you return err directly ? no need of if statement.
> + return err;
> +
> + return 0;
>
next prev parent reply other threads:[~2024-05-01 4:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 23:14 [PATCH net-next 00/10] gve: Implement queue api Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 01/10] queue_api: define " Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 02/10] gve: Make the GQ RX free queue funcs idempotent Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 03/10] gve: Add adminq funcs to add/remove a single Rx queue Shailend Chand
2024-05-01 4:19 ` Ratheesh Kannoth [this message]
2024-05-01 13:50 ` Willem de Bruijn
2024-05-01 23:27 ` Shailend Chand
2024-05-02 1:39 ` Willem de Bruijn
2024-04-30 23:14 ` [PATCH net-next 04/10] gve: Make gve_turn(up|down) ignore stopped queues Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 05/10] gve: Make gve_turnup work for nonempty queues Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 06/10] gve: Avoid rescheduling napi if on wrong cpu Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 07/10] gve: Reset Rx ring state in the ring-stop funcs Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 08/10] gve: Account for stopped queues when reading NIC stats Shailend Chand
2024-04-30 23:14 ` [PATCH net-next 09/10] gve: Alloc and free QPLs with the rings Shailend Chand
2024-05-01 15:31 ` Jakub Kicinski
2024-04-30 23:14 ` [PATCH net-next 10/10] gve: Implement queue api Shailend Chand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240501041930.GA72628@maili.marvell.com \
--to=rkannoth@marvell.com \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.