From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D5D284D0B for ; Wed, 1 May 2024 12:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714568263; cv=none; b=LXnfjqpbsrxrS1s5YEOwqpELgEPGKPdYCqGV03YWSVUWzSClWQfKL+pKfoG+KzReT/uXcpPFOfOVYpEKv5KGCjb1HfbDlpP3zVv8drW8ggAzanJh4EKfWno7Yfca7tzySAciN2ruQ2yuAtO4xqBttJFQoqq8xmD0O8VVPEIUHV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714568263; c=relaxed/simple; bh=Gty58OEYHWq+ungpIU5F4T5rC8meaTaxxxFRAaapLwE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xz8i7AJfd2PkR2b4tHcE6T0W2HrNER7/tEXVXupNydd12DlTLzuq/3qbWxNR+0lnEA0HP26vAImAvjZJ13KM5DLexJPnagB3405pHALf5hHaVvdJciCoHw6SZ38giHAyQ/+qXxksQKuY7d1Kld8poFrZNj667lJUEXGmHJpvb6E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=h834PQ7H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="h834PQ7H" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA8A1C113CC; Wed, 1 May 2024 12:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1714568263; bh=Gty58OEYHWq+ungpIU5F4T5rC8meaTaxxxFRAaapLwE=; h=From:To:Cc:Subject:Date:Reply-to:From; b=h834PQ7H7GlGtqLC0TJw0LtkfXRThWVr107qpkBGYxgdiHtH61aJbbdvF2nNlTW2h MKPA6kxNLagsXm3eePApd+3EXhGnibG+cTe2XigY7I4AeJOQgjLVccsnA8oW1zQdkL YktZX2hqfnJSpddTaXu21yZYJiOCXIAXNuJ1m2hw= From: Greg Kroah-Hartman To: linux-cve-announce@vger.kernel.org Cc: Greg Kroah-Hartman Subject: CVE-2024-27040: drm/amd/display: Add 'replay' NULL check in 'edp_set_replay_allow_active()' Date: Wed, 1 May 2024 14:57:25 +0200 Message-ID: <2024050112-CVE-2024-27040-e45b@gregkh> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-cve-announce@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Reply-to: , X-Developer-Signature: v=1; a=openpgp-sha256; l=2843; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=Gty58OEYHWq+ungpIU5F4T5rC8meaTaxxxFRAaapLwE=; b=owGbwMvMwCRo6H6F97bub03G02pJDGlGNhpBk4/KCgacvctu+efZ00iRZ3kv+HSOeXMvNDPdK mlT8HVfRywLgyATg6yYIsuXbTxH91ccUvQytD0NM4eVCWQIAxenAEykw4dhfvGV729nvpM9c33N uX5Lnyvtaz59j2JYsJbx135NBc0lXfzJ1QneX9umi+68CQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit Description =========== In the Linux kernel, the following vulnerability has been resolved: drm/amd/display: Add 'replay' NULL check in 'edp_set_replay_allow_active()' In the first if statement, we're checking if 'replay' is NULL. But in the second if statement, we're not checking if 'replay' is NULL again before calling replay->funcs->replay_set_power_opt(). if (replay == NULL && force_static) return false; ... if (link->replay_settings.replay_feature_enabled && replay->funcs->replay_set_power_opt) { replay->funcs->replay_set_power_opt(replay, *power_opts, panel_inst); link->replay_settings.replay_power_opt_active = *power_opts; } If 'replay' is NULL, this will cause a null pointer dereference. Fixes the below found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/link/protocols/link_edp_panel_control.c:895 edp_set_replay_allow_active() error: we previously assumed 'replay' could be null (see line 887) The Linux kernel CVE team has assigned CVE-2024-27040 to this issue. Affected and fixed versions =========================== Issue introduced in 6.6 with commit c7ddc0a800bc and fixed in 6.6.23 with commit f610c46771ef Issue introduced in 6.6 with commit c7ddc0a800bc and fixed in 6.7.11 with commit e7cadd5d3a8f Issue introduced in 6.6 with commit c7ddc0a800bc and fixed in 6.8.2 with commit d0e94f4807ff Issue introduced in 6.6 with commit c7ddc0a800bc and fixed in 6.9-rc1 with commit f6aed043ee5d Please see https://www.kernel.org for a full list of currently supported kernel versions by the kernel community. Unaffected versions might change over time as fixes are backported to older supported kernel versions. The official CVE entry at https://cve.org/CVERecord/?id=CVE-2024-27040 will be updated if fixes are backported, please check that for the most up to date information about this issue. Affected files ============== The file(s) affected by this issue are: drivers/gpu/drm/amd/display/dc/link/protocols/link_edp_panel_control.c Mitigation ========== The Linux kernel CVE team recommends that you update to the latest stable kernel version for this, and many other bugfixes. Individual changes are never tested alone, but rather are part of a larger kernel release. Cherry-picking individual commits is not recommended or supported by the Linux kernel community at all. If however, updating to the latest release is impossible, the individual changes to resolve this issue can be found at these commits: https://git.kernel.org/stable/c/f610c46771ef1047e46d61807aa7c69cd29e63d8 https://git.kernel.org/stable/c/e7cadd5d3a8ffe334d0229ba9eda4290138d56e7 https://git.kernel.org/stable/c/d0e94f4807ff0df66cf447d6b4bbb8ac830e99c3 https://git.kernel.org/stable/c/f6aed043ee5d75b3d1bfc452b1a9584b63c8f76b