From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90DA91304BD for ; Wed, 1 May 2024 16:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714579632; cv=none; b=SR4/KL6YF6x5W6+FckUy0FPRyeRYpySkGqj5CmOMC2CpmkJD125MN7recEHYVlgHibGM2U7UpwceSxJQvjbkT4rzx8ZUj2V8zrwoJ/k9bzt0CKib7RAP00O1+9P0a2KxFlBLp7mykkO5P3uq3FE5XeiVUu+XxgmtQqGvTu9CBG4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714579632; c=relaxed/simple; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8GKhzRQEIC1YazjQ/Z5rE/XQixfrqhTJhnC0bsqkq8nlB0vZ07NNpVAPEpd6KF3zjb0czYgy82sj1FkL5VJT89vsXlsZfhnAcwXeFAP9TPcir+yv7LqPdA7P1roNbyAApVuMDDIwP23MQoPZlu5H57CczsMhz7jXFGrUE/arXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=B+pqLwCl; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="B+pqLwCl" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-790c36dcee9so347940185a.2 for ; Wed, 01 May 2024 09:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1714579629; x=1715184429; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=B+pqLwCl9vfFvjVaX0dPOZmRcQAwYKrl4Yn7pWZiVwJSXYFp73xrk/HgHrgud8/xQV /4ZBWfU8iBV9JmoJTNk4/56Sb2mJg9BXLbEbeNUMQ1mYALqIrmta5XVDQZ/b4gfX0ydi tAZYGjOrzTY9EjRb7KnPjrykrNOzMM2fTsik8zGhlHEzmY7yTYGUo9bTC2WeQ/wOTEwc n3DygqsYnpxKOB9fRzccvx5cJiYWeOLeGNFeQJ4buUXcaEWtCHtkZL/Tb9K6eHc6yUwd MWdUk3ms0b21KLDwVDyY6niMrL287lVoUN6OfCAT+uwK2i+lHpV0zdoGQDASTUcOGrqu Y2YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714579629; x=1715184429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=XjTP466tWBcmTpdRfjICvX0LexPkR8PT7L7W5UB3XG30P8CE2CnlDF0Y1C2rtnGIKc AOiGXdN6QaSmgcw8OZQXBw6PKNr+mp7Cez5J4IJ2dL0TShWhv7zx6oamn6QZXUPYmp6A B0M+3Rl3jy2mAFAEFh0s7CCmg/Lyevo5jX8TfF4sGDm5ojp9sh7Eu8mOmyUWnbF6I3vH GTiyLStTxniX2Lve7JutxrYbWmQHj/EE8BTGNN4XgPx94LZ6NeM5tkkShZ4VlxtcmPKn +2r2ZpCW2k3bF9pSKjTK5hQi7SyhBvJZj+0vNLAiEBgJ9zZp4bA5OJx1ZMkPUnB2T9TI hg6Q== X-Forwarded-Encrypted: i=1; AJvYcCX5N3B8v7mKLTVD1pbnxqKx8z/dGowhSMLGvx7JyHdW7O60gr2oiBXC/X3SohuboR0Be4zs8xkNM+MedNz7q7AEPk+Lwc8= X-Gm-Message-State: AOJu0Yw3sLZ1mjRUNVNr09iK9PACZL15Hbdstyyzaq9JV0WFCRFiYMJM TNmr2uW7WSpOE2sz3qvxRi4r8/iu8+NQkSFIoMRgfyWP+R/MmcXtUi++9V5yxbI= X-Google-Smtp-Source: AGHT+IEIToKXo0oiLD8614cnvRWTKlqp8YbwZyKQg7eanOTB8s3Hn6dt4BqjP2UpzNxDw9ZcGXsFhg== X-Received: by 2002:a05:620a:2059:b0:78e:e7dc:fd3b with SMTP id d25-20020a05620a205900b0078ee7dcfd3bmr2822573qka.73.1714579629470; Wed, 01 May 2024 09:07:09 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id n6-20020a05620a294600b00790eb55fd58sm3512214qkp.129.2024.05.01.09.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:07:08 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1s2CU8-00DuqC-5D; Wed, 01 May 2024 13:07:08 -0300 Date: Wed, 1 May 2024 13:07:08 -0300 From: Jason Gunthorpe To: Tomasz Jeznach Cc: Joerg Roedel , Will Deacon , Robin Murphy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Sunil V L , Nick Kossifidis , Sebastien Boeuf , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, iommu@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux@rivosinc.com Subject: Re: [PATCH v3 0/7] Linux RISC-V IOMMU Support Message-ID: <20240501160708.GF1723318@ziepe.ca> References: Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 30, 2024 at 01:01:50PM -0700, Tomasz Jeznach wrote: > This patch series introduces support for RISC-V IOMMU architected > hardware into the Linux kernel. It seems in reasonable shape now, at least in terms of implementing the domain logic. It would be nice if you'd run it through clang-format and correct some of the minor misformatting it will point out. We still like to have a 80 col line limit in most cases. There are many overages here that aren't well justified. And you could consider the nitpicky style advice to use 'reverse christmas tree' for the variable declarations like most of the subsystem is trending toward. Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F48DC4345F for ; Wed, 1 May 2024 16:07:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OmBrBKLyJAfV3pWKVaxodnwf1/+d5zgCEWx/uyMFDZc=; b=P6cxkoKtdq+ifn +gntHDiy/qQzeVYGtHLir87SORSmyEyHObmIjTDQt93XVxLcpmj9QLbDdiqmBHLVkXmGy22Gk+UnL Foa8Lk0EJuEEgxOcM51Uq1RnWsLsnCrVAZRCk2uHc9eieggD6o/dqnl85aoDv4t1Eb072s1G7fZ5r 3PI//zOGRWGjxJYjfr1eXhOCWj0afMtjCGUEJZLUsftKZVBEK1mW/E384kYC8ifmP4VrlyeUO0Tfr m1deuKN0w5/mgJ0TTysHRI8wOh3G4y97xNwxDhHPwymUcjo3e+qsYYWtHDrsxbbZIwU7VVhOjMrF0 DY/rwRbhI1HY3XJCd23A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2CUH-0000000A5AU-3OFS; Wed, 01 May 2024 16:07:17 +0000 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2CUE-0000000A57r-2C81 for linux-riscv@lists.infradead.org; Wed, 01 May 2024 16:07:15 +0000 Received: by mail-qk1-x732.google.com with SMTP id af79cd13be357-790f699eb2cso304169985a.1 for ; Wed, 01 May 2024 09:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1714579629; x=1715184429; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=QhzzBkP0eMP+xAJU22kAOiPPzlcz7ersnNDCwpfSZ2GTQHjcxOnaDFqLYqJAhKFWW0 3Jf+ZmMdTHBA0BNAzyRDgQyML816baN017809Ft8ymEkWKIa/XZutjN2w4PGPrk6JKZf NU1nCJQ2yVfFgYEhoDLIdBy8fDpG8wBHrbpeCCXB2x4KMsybk93tIvDPvFcKpel7Db7i kDoMyyAYaQH3tGKTQtkeKLzP2CdTLImDid4QAz+RhK6/61V2tEJ652oOQzI0npfJeuuA AT8mvQQyhoKAHuihUdMNKpbdtkhCxDjKQAw9U6m5mz+qoZCmITKNdzeeSytkumfJFu7T rYZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714579629; x=1715184429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=KPJquGpvrCNmMu/tZqdiMnaj2T21peFepgCGkGVkmXIR3lwC/mEYUBgdpi2atArPYG 1mLhtBW+S0alDIGGQfUGouxMOa8UvlOlKKM8ERCsFBevZFS3T0c2qBtJg3GnmXyN/luk sFxoc660a6JNr3qTMz00sXNJ00xB8N1x2R+UkVwVOhA0iGQhoaUX4CT89l8oB4EFCoVQ e2OItbCxImhDmcBAA/iI8DZrGl/2QgqccKz1r2KWzSKXbejXXdUsJyzgaLh6W5O/lULO nvFNNE3yr4RwKWL9VrACc2lkSQIEH5zogI1U2DaXT8mEO0sb3nTMCZ76OLzsM6cnqd2H VoiA== X-Forwarded-Encrypted: i=1; AJvYcCUROvj+D1lSjWi1okUdpYtgNH2AVABs3tQsIE/WrOuIwc3dHXt6Q8LqiJpNq+cpIw17/QWQ3QGITp3ICyvRDNPkAedS8mi0GFjay3cJwHJm X-Gm-Message-State: AOJu0YxJwIEgKu4LS097T79CRIYSdFLmJyer0oY7gznnA1Xi7CLCLRpu kbcglJm5gVuITgGWe/JaGwGqso52ie00AFGCt0LJ9fcfRA6TMWLNLoxBCWWT0fA= X-Google-Smtp-Source: AGHT+IEIToKXo0oiLD8614cnvRWTKlqp8YbwZyKQg7eanOTB8s3Hn6dt4BqjP2UpzNxDw9ZcGXsFhg== X-Received: by 2002:a05:620a:2059:b0:78e:e7dc:fd3b with SMTP id d25-20020a05620a205900b0078ee7dcfd3bmr2822573qka.73.1714579629470; Wed, 01 May 2024 09:07:09 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id n6-20020a05620a294600b00790eb55fd58sm3512214qkp.129.2024.05.01.09.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:07:08 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1s2CU8-00DuqC-5D; Wed, 01 May 2024 13:07:08 -0300 Date: Wed, 1 May 2024 13:07:08 -0300 From: Jason Gunthorpe To: Tomasz Jeznach Subject: Re: [PATCH v3 0/7] Linux RISC-V IOMMU Support Message-ID: <20240501160708.GF1723318@ziepe.ca> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240501_090714_684185_D1D1B071 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anup Patel , devicetree@vger.kernel.org, Conor Dooley , Albert Ou , linux@rivosinc.com, Will Deacon , Joerg Roedel , linux-kernel@vger.kernel.org, Rob Herring , Sebastien Boeuf , iommu@lists.linux.dev, Palmer Dabbelt , Paul Walmsley , Nick Kossifidis , Krzysztof Kozlowski , Robin Murphy , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Apr 30, 2024 at 01:01:50PM -0700, Tomasz Jeznach wrote: > This patch series introduces support for RISC-V IOMMU architected > hardware into the Linux kernel. It seems in reasonable shape now, at least in terms of implementing the domain logic. It would be nice if you'd run it through clang-format and correct some of the minor misformatting it will point out. We still like to have a 80 col line limit in most cases. There are many overages here that aren't well justified. And you could consider the nitpicky style advice to use 'reverse christmas tree' for the variable declarations like most of the subsystem is trending toward. Jason _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv