All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [PATCH net-next] selftests: netfilter: nft_concat_range.sh: reduce debug kernel run time
Date: Wed, 1 May 2024 21:09:17 +0100	[thread overview]
Message-ID: <20240501200917.GL516117@kernel.org> (raw)
In-Reply-To: <20240501194153.GA8667@breakpoint.cc>

On Wed, May 01, 2024 at 09:41:53PM +0200, Florian Westphal wrote:
> Simon Horman <horms@kernel.org> wrote:
> > On Tue, Apr 30, 2024 at 04:58:07PM +0200, Florian Westphal wrote:
> > 
> > ...
> > 
> > > diff --git a/tools/testing/selftests/net/netfilter/nft_concat_range.sh b/tools/testing/selftests/net/netfilter/nft_concat_range.sh
> > 
> > ...
> > 
> > > @@ -1584,10 +1594,16 @@ for name in ${TESTS}; do
> > >  			continue
> > >  		fi
> > >  
> > > -		printf "  %-60s  " "${display}"
> > > +		[ "$KSFT_MACHINE_SLOW" = "yes" ] && count=1
> > > +
> > > +		printf "  %-32s  " "${display}"
> > > +		tthen=$(date +%s)
> > >  		eval test_"${name}"
> > >  		ret=$?
> > >  
> > > +		tnow=$(date +%s)
> > > +		printf "%5ds%-30s" $((tnow-tthen))
> > > + 
> > 
> > Hi Florian,
> > 
> > A minor nit: the format string above expects two variables, but only one
> > is passed.
> 
> Its intentional, I thought this was better than "%5ds                 "
> or similar.

Understood, thanks.

  reply	other threads:[~2024-05-01 20:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30 14:58 [PATCH net-next] selftests: netfilter: nft_concat_range.sh: reduce debug kernel run time Florian Westphal
2024-05-01 15:59 ` Simon Horman
2024-05-01 19:41   ` Florian Westphal
2024-05-01 20:09     ` Simon Horman [this message]
2024-05-01 22:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240501200917.GL516117@kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.