Re: [PATCH net-next] octeontx2-pf: Treat truncation of IRQ name as an error

[Simon Horman <horms@kernel.org>]

On Wed, May 01, 2024 at 09:46:15PM +0200, Andrew Lunn wrote:
> On Wed, May 01, 2024 at 07:27:09PM +0100, Simon Horman wrote:
> > According to GCC, the constriction of irq_name in otx2_open()
> > may, theoretically, be truncated.
> > 
> > This patch takes the approach of treating such a situation as an error
> > which it detects by making use of the return value of snprintf, which is
> > the total number of bytes, including the trailing '\0', that would have
> > been written.
> > +		name_len = snprintf(irq_name, NAME_SIZE, "%s-rxtx-%d",
> > +				    pf->netdev->name, qidx);
> > +		if (name_len >= NAME_SIZE) {
> 
> You say name_len includes the trailing \0. So you should be able to
> get NAME_SIZE bytes into an NAME_SIZE length array? So i think this
> can be >, not >= ?

Sorry, I misspoke.
name_len excludes the trailing \0.

-- 
pw-bot: changes-requested