From: kernel test robot <lkp@intel.com>
To: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
"Rob Herring (Arm)" <robh@kernel.org>
Subject: [linux-next:master 9793/10134] drivers/of/of_reserved_mem.c:465:6: warning: variable 'nomap' is uninitialized when used here
Date: Wed, 1 May 2024 21:45:15 +0800 [thread overview]
Message-ID: <202405012148.1dCXzomq-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: f68868ba718e30594165879cc3020607165b0761
commit: 2acef04ad57cab44b33001542791fc93f81cadf1 [9793/10134] of: reserved_mem: Remove the use of phandle from the reserved_mem APIs
config: arm-allnoconfig (https://download.01.org/0day-ci/archive/20240501/202405012148.1dCXzomq-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 37ae4ad0eef338776c7e2cffb3896153d43dcd90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240501/202405012148.1dCXzomq-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405012148.1dCXzomq-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/of/of_reserved_mem.c:19:
In file included from include/linux/mm.h:2208:
include/linux/vmstat.h:522:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
522 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/of/of_reserved_mem.c:465:6: warning: variable 'nomap' is uninitialized when used here [-Wuninitialized]
465 | nomap ? "nomap" : "map",
| ^~~~~
include/linux/printk.h:530:34: note: expanded from macro 'pr_info'
530 | printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:457:60: note: expanded from macro 'printk'
457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
| ^~~~~~~~~~~
include/linux/printk.h:429:19: note: expanded from macro 'printk_index_wrap'
429 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
drivers/of/of_reserved_mem.c:441:13: note: initialize the variable 'nomap' to silence this warning
441 | bool nomap;
| ^
| = 0
2 warnings generated.
vim +/nomap +465 drivers/of/of_reserved_mem.c
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 426
3f0c8206644836 Marek Szyprowski 2014-02-28 427 /**
c8813f7ec01c67 chenqiwu 2020-05-11 428 * fdt_init_reserved_mem() - allocate and init all saved reserved memory regions
3f0c8206644836 Marek Szyprowski 2014-02-28 429 */
3f0c8206644836 Marek Szyprowski 2014-02-28 430 void __init fdt_init_reserved_mem(void)
3f0c8206644836 Marek Szyprowski 2014-02-28 431 {
3f0c8206644836 Marek Szyprowski 2014-02-28 432 int i;
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 433
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 434 /* check for overlapping reserved regions */
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 435 __rmem_check_for_overlap();
ae1add247bf8c2 Mitchel Humpherys 2015-09-15 436
3f0c8206644836 Marek Szyprowski 2014-02-28 437 for (i = 0; i < reserved_mem_count; i++) {
3f0c8206644836 Marek Szyprowski 2014-02-28 438 struct reserved_mem *rmem = &reserved_mem[i];
3f0c8206644836 Marek Szyprowski 2014-02-28 439 unsigned long node = rmem->fdt_node;
3f0c8206644836 Marek Szyprowski 2014-02-28 440 int err = 0;
6f1188b4ac7577 Yue Hu 2020-07-30 441 bool nomap;
3f0c8206644836 Marek Szyprowski 2014-02-28 442
3f0c8206644836 Marek Szyprowski 2014-02-28 443 if (rmem->size == 0)
3f0c8206644836 Marek Szyprowski 2014-02-28 444 err = __reserved_mem_alloc_size(node, rmem->name,
3f0c8206644836 Marek Szyprowski 2014-02-28 445 &rmem->base, &rmem->size);
d0b8ed47e83a22 pierre Kuo 2019-02-19 446 if (err == 0) {
d0b8ed47e83a22 pierre Kuo 2019-02-19 447 err = __reserved_mem_init_node(rmem);
d0b8ed47e83a22 pierre Kuo 2019-02-19 448 if (err != 0 && err != -ENOENT) {
d0b8ed47e83a22 pierre Kuo 2019-02-19 449 pr_info("node %s compatible matching fail\n",
d0b8ed47e83a22 pierre Kuo 2019-02-19 450 rmem->name);
2acef04ad57cab Oreoluwa Babatunde 2024-04-22 451
2acef04ad57cab Oreoluwa Babatunde 2024-04-22 452 nomap = of_get_flat_dt_prop(node, "no-map", NULL) != NULL;
d0b8ed47e83a22 pierre Kuo 2019-02-19 453 if (nomap)
7b25995f5319ad Dong Aisheng 2021-06-11 454 memblock_clear_nomap(rmem->base, rmem->size);
3c6867a12a224d Dong Aisheng 2021-06-11 455 else
3ecc68349bbab6 Mike Rapoport 2021-11-05 456 memblock_phys_free(rmem->base,
3ecc68349bbab6 Mike Rapoport 2021-11-05 457 rmem->size);
aeb9267eb6b1df Martin Liu 2023-02-10 458 } else {
aeb9267eb6b1df Martin Liu 2023-02-10 459 phys_addr_t end = rmem->base + rmem->size - 1;
aeb9267eb6b1df Martin Liu 2023-02-10 460 bool reusable =
aeb9267eb6b1df Martin Liu 2023-02-10 461 (of_get_flat_dt_prop(node, "reusable", NULL)) != NULL;
aeb9267eb6b1df Martin Liu 2023-02-10 462
6ee7afbabcee4d Geert Uytterhoeven 2023-02-16 463 pr_info("%pa..%pa (%lu KiB) %s %s %s\n",
aeb9267eb6b1df Martin Liu 2023-02-10 464 &rmem->base, &end, (unsigned long)(rmem->size / SZ_1K),
aeb9267eb6b1df Martin Liu 2023-02-10 @465 nomap ? "nomap" : "map",
aeb9267eb6b1df Martin Liu 2023-02-10 466 reusable ? "reusable" : "non-reusable",
aeb9267eb6b1df Martin Liu 2023-02-10 467 rmem->name ? rmem->name : "unknown");
d0b8ed47e83a22 pierre Kuo 2019-02-19 468 }
d0b8ed47e83a22 pierre Kuo 2019-02-19 469 }
3f0c8206644836 Marek Szyprowski 2014-02-28 470 }
3f0c8206644836 Marek Szyprowski 2014-02-28 471 }
9dcfee01930e6c Marek Szyprowski 2014-07-14 472
:::::: The code at line 465 was first introduced by commit
:::::: aeb9267eb6b1df992e39467a620da8fdf434df54 of: reserved-mem: print out reserved-mem details during boot
:::::: TO: Martin Liu <liumartin@google.com>
:::::: CC: Rob Herring <robh@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-05-01 13:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 13:45 kernel test robot [this message]
2024-05-01 17:05 ` [linux-next:master 9793/10134] drivers/of/of_reserved_mem.c:465:6: warning: variable 'nomap' is uninitialized when used here Oreoluwa Babatunde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405012148.1dCXzomq-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=quic_obabatun@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.