From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Måns Rullgård" <mans@mansr.com>
Cc: Johan Hovold <johan@kernel.org>, linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB: serial: use tty_port_register_device_serdev
Date: Thu, 2 May 2024 12:54:39 +0200 [thread overview]
Message-ID: <2024050204-recreate-exerciser-bd62@gregkh> (raw)
In-Reply-To: <yw1xmsp8big7.fsf@mansr.com>
On Thu, May 02, 2024 at 11:45:44AM +0100, Måns Rullgård wrote:
> Johan Hovold <johan@kernel.org> writes:
>
> > On Thu, May 02, 2024 at 11:07:28AM +0100, Mans Rullgard wrote:
> >> Use tty_port_register_device_serdev() so that usb-serial devices
> >> can be used as serdev controllers.
> >
> > I'm afraid it's not that easy. The reason serdev is not enabled for
> > usb-serial is that there's currently no support for handling hotplug in
> > serdev. The device can go away from under you at any time and then you'd
> > crash the kernel.
>
> Oh, that's unfortunate. Regular serial ports can go away too, though,
> and that seems to be handled fine. What am I missing?
How is it handled? Normal serial ports can go away but in practice,
it's a rare occurance, and usually people use serdev for devices where
the ports can not be removed (i.e. internal connections).
thanks,
greg k-h
next prev parent reply other threads:[~2024-05-02 10:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 10:07 [PATCH] USB: serial: use tty_port_register_device_serdev Mans Rullgard
2024-05-02 10:18 ` Johan Hovold
2024-05-02 10:45 ` Måns Rullgård
2024-05-02 10:54 ` Greg Kroah-Hartman [this message]
2024-05-02 13:24 ` Måns Rullgård
2024-05-02 13:57 ` Greg Kroah-Hartman
2024-05-02 14:32 ` Måns Rullgård
2024-05-02 23:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024050204-recreate-exerciser-bd62@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.