From: Jakub Kicinski <kuba@kernel.org>
To: Mina Almasry <almasrymina@google.com>
Cc: David Wei <dw@davidwei.uk>,
netdev@vger.kernel.org, Michael Chan <michael.chan@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Shailend Chand <shailend@google.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [RFC PATCH net-next v1 3/3] netdev: add netdev_rx_queue_restart()
Date: Thu, 2 May 2024 17:22:41 -0700 [thread overview]
Message-ID: <20240502172241.363ba5a0@kernel.org> (raw)
In-Reply-To: <CAHS8izMzakPfORQ9FX8nh0u0V7awtjUufswCc0Gf3fxxXWX0WA@mail.gmail.com>
On Thu, 2 May 2024 09:46:46 -0700 Mina Almasry wrote:
> Sorry, I think if we don't need the EXPORT, then I think don't export
> in the first place. Removing an EXPORT is, AFAIU, tricky. Because if
> something is exported and then you unexport it could break an out of
> tree module/driver that developed a dependency on it. Not sure how
> much of a concern it really is.
FWIW don't worry about out of tree code, it's not a concern.
next prev parent reply other threads:[~2024-05-03 0:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-30 1:07 [RFC PATCH net-next v1 0/3] bnxt: implement queue api David Wei
2024-04-30 1:07 ` [RFC PATCH net-next v1 1/3] queue_api: define " David Wei
2024-04-30 18:00 ` Mina Almasry
2024-05-02 1:00 ` David Wei
2024-05-02 16:58 ` Mina Almasry
2024-05-02 2:44 ` David Wei
2024-05-02 17:15 ` Mina Almasry
2024-04-30 1:07 ` [RFC PATCH net-next v1 2/3] bnxt: implement " David Wei
2024-04-30 1:07 ` [RFC PATCH net-next v1 3/3] netdev: add netdev_rx_queue_restart() David Wei
2024-04-30 18:15 ` Mina Almasry
2024-05-02 1:04 ` David Wei
2024-05-02 16:46 ` Mina Almasry
2024-05-03 0:22 ` Jakub Kicinski [this message]
2024-05-03 0:49 ` Jakub Kicinski
2024-05-03 1:19 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240502172241.363ba5a0@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=shailend@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.