From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C7641552F7; Fri, 3 May 2024 14:21:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714746120; cv=none; b=eD7fHQt+Vd9pd0um7QgeUE2hO1jTfiWtIdgPveTpkmTAbnwKikiIcrCnv5tVjFVJHNSEI/cKynp6z3i8qABTfzzXp7Qq/Y/C3ptG/afSb0uOuwWLqC4TsHWLfRVHtF4B+z13fGNo2TIS/gaiv0DD0Tjv2itBKz+rAkfLcWyVYLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714746120; c=relaxed/simple; bh=bLnPfADEwEwkOX0WWN6OPsmdt+pl5f8Iuzuh935QVFQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vBY1Reo0cts8a2B/OjB2UAUW7j5On9T9LdWVXFwiKhV/rms8C2at0q1exb0E2rEKi+QLPkkU0aBqo/8gYPM7cFyvYESiskVIcsdOao9qyU2WF87o+nZ7uRiqjMddK+j2WnhJgnYAIvpuJbkZA/Ij+4dhCa1qEr+WLXERxIRYzA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Z0xYgguv; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Z0xYgguv" Received: by mail.gandi.net (Postfix) with ESMTPSA id BA8B01C000C; Fri, 3 May 2024 14:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1714746111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aHh6D+ByoS0ChKmmLmwD9Yo2EL46j5O9IJF8s7BAGCM=; b=Z0xYgguvPb0niup9/7f1RVaaaXWIlXmRSf4CLDnZw2sG2oGbBxXy04KWfQKOrTKhsVP5PI Y5vjBKqArd7ea8kg6QmMWfW1ZHRi1Dd05z/hMq7IVwg+7dc54meeFYNZlovfV2HYg5qzpx 5JWe/vKXETX4WtXi/zRU9NnF13ipf3kIkDoTjsQ5foUmeBnkYBIk8VfI9DqFqN3NDPCRhL mxCEWumgcFxzrUd5+1fNfa8LJyYR7broXXxQefbcwq0nneXfmEv9KrsottgUm4ytzg+LrT kBNCefmAtTEknF1b+rdHBqy2+4HMNsiiCyoWIprA3iLE8FgrCCcS+L+DzUYTYg== Date: Fri, 3 May 2024 16:21:48 +0200 From: Herve Codina To: Alexandre Belloni Cc: Andrew Lunn , Conor Dooley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property Message-ID: <20240503162148.1dc64b9a@bootlin.com> In-Reply-To: <202405021322091c565595@mail.local> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-7-herve.codina@bootlin.com> <5d899584-38ed-4eee-9ba5-befdedbc5734@lunn.ch> <20240430174023.4d15a8a4@bootlin.com> <2b01ed8a-1169-4928-952e-1645935aca2f@lunn.ch> <20240502115043.37a1a33a@bootlin.com> <20240502-petted-dork-20eb02e5a8e3@wendy> <4f9fd16b-773d-40e7-86d8-db19e2f6da16@lunn.ch> <202405021322091c565595@mail.local> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi, On Thu, 2 May 2024 15:22:09 +0200 Alexandre Belloni wrote: > On 02/05/2024 14:26:36+0200, Andrew Lunn wrote: > > On Thu, May 02, 2024 at 11:31:00AM +0100, Conor Dooley wrote: > > > On Thu, May 02, 2024 at 11:50:43AM +0200, Herve Codina wrote: > > > > Hi Andrew, > > > > > > > > On Tue, 30 Apr 2024 18:31:46 +0200 > > > > Andrew Lunn wrote: > > > > > > > > > > We have the same construction with the pinctrl driver used in the LAN966x > > > > > > Documentation/devicetree/bindings/pinctrl/mscc,ocelot-pinctrl.yaml > > > > > > > > > > > > The reset name is 'switch' in the pinctrl binding. > > > > > > I can use the same description here as the one present in the pinctrl binding: > > > > > > description: Optional shared switch reset. > > > > > > and keep 'switch' as reset name here (consistent with pinctrl reset name). > > > > > > > > > > > > What do you think about that ? > > > > > > > > > > It would be good to document what it is shared with. So it seems to be > > > > > the switch itself, pinctl and MDIO? Anything else? > > > > > > > > > > > > > To be honest, I know that the GPIO controller (microchip,sparx5-sgpio) is > > > > impacted but I don't know if anything else is impacted by this reset. > > > > I can update the description with: > > > > description: > > > > Optional shared switch reset. > > > > This reset is shared with at least pinctrl, GPIO, MDIO and the switch > > > > itself. > > > > > > > > Does it sound better ? > > > > > > $dayjob hat off, bindings hat on: If you don't know, can we get someone > > > from Microchip (there's some and a list in CC) to figure it out? > > > > That is probably a good idea, there is potential for hard to find bugs > > here, when a device gets an unexpected reset. Change the order things > > probe, or an unexpected EPRODE_DEFER could be interesting. > > > > > The datasheet states: > "The VCore system comprises all the blocks attached to the VCore Shared > Bus (SBA), including the PCIe, DDR, frame DMA, SI slave, and MIIM slave > blocks. The device includes all the blocks attached to the Switch Core > Register Bus (CSR) including the VRAP slave. For more information about > the VCore System blocks, see Figure 5-1." > > However, the reset driver protects the VCORE itself by setting bit 5. > Everything else is going to be reset. > Right, I will update the reset description with: description: Optional shared switch reset. This reset is shared with all blocks attached to the Switch Core Register Bus (CSR) including VRAP slave. Is that better ? Best regards, Hervé -- Hervé Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3B00C4345F for ; Fri, 3 May 2024 14:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DpFjZF2Dg8kdsLk5XTTGs5P8OEGG6cUENwt0p3nc0NM=; b=nmKcVcYeZH10je TqVfYhLFuUkLCsmgxPOIoBteEd6s+YcMdn8Mk1jZkzctmDIMeW21DmWLvAs1jFKCtOPZx8+Kw3gZx CSNZRbgMhCq0gvRqqgKULV3C3FbQ48L50GorvaTcnFj30qrNS2MRaGEFyHh9dJi4dEpOa6HYZ6SeO iIrDik2s1q0sf764cgStRweB5h5TndrdmcqmeAMs3onG+SE3A3gpcIlmWaXeFlFVqunjpI9kWawkQ 6zoAtOXgTPLkV83CNNKURnsz83B4XR0DcoH1HLpdURHqRjsx9OOnDSXcZKq2V7zBUeKA9fRm9yWcQ tiMN/GxhizHIhvaWqYdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2tnV-0000000Gq83-0ZXT; Fri, 03 May 2024 14:22:01 +0000 Received: from relay5-d.mail.gandi.net ([217.70.183.197]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s2tnR-0000000Gq5z-18yX for linux-arm-kernel@lists.infradead.org; Fri, 03 May 2024 14:21:59 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id BA8B01C000C; Fri, 3 May 2024 14:21:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1714746111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aHh6D+ByoS0ChKmmLmwD9Yo2EL46j5O9IJF8s7BAGCM=; b=Z0xYgguvPb0niup9/7f1RVaaaXWIlXmRSf4CLDnZw2sG2oGbBxXy04KWfQKOrTKhsVP5PI Y5vjBKqArd7ea8kg6QmMWfW1ZHRi1Dd05z/hMq7IVwg+7dc54meeFYNZlovfV2HYg5qzpx 5JWe/vKXETX4WtXi/zRU9NnF13ipf3kIkDoTjsQ5foUmeBnkYBIk8VfI9DqFqN3NDPCRhL mxCEWumgcFxzrUd5+1fNfa8LJyYR7broXXxQefbcwq0nneXfmEv9KrsottgUm4ytzg+LrT kBNCefmAtTEknF1b+rdHBqy2+4HMNsiiCyoWIprA3iLE8FgrCCcS+L+DzUYTYg== Date: Fri, 3 May 2024 16:21:48 +0200 From: Herve Codina To: Alexandre Belloni Cc: Andrew Lunn , Conor Dooley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH 06/17] dt-bindings: net: mscc-miim: Add resets property Message-ID: <20240503162148.1dc64b9a@bootlin.com> In-Reply-To: <202405021322091c565595@mail.local> References: <20240430083730.134918-1-herve.codina@bootlin.com> <20240430083730.134918-7-herve.codina@bootlin.com> <5d899584-38ed-4eee-9ba5-befdedbc5734@lunn.ch> <20240430174023.4d15a8a4@bootlin.com> <2b01ed8a-1169-4928-952e-1645935aca2f@lunn.ch> <20240502115043.37a1a33a@bootlin.com> <20240502-petted-dork-20eb02e5a8e3@wendy> <4f9fd16b-773d-40e7-86d8-db19e2f6da16@lunn.ch> <202405021322091c565595@mail.local> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: herve.codina@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240503_072157_602466_C1C04C28 X-CRM114-Status: GOOD ( 33.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGksCgpPbiBUaHUsIDIgTWF5IDIwMjQgMTU6MjI6MDkgKzAyMDAKQWxleGFuZHJlIEJlbGxvbmkg PGFsZXhhbmRyZS5iZWxsb25pQGJvb3RsaW4uY29tPiB3cm90ZToKCj4gT24gMDIvMDUvMjAyNCAx NDoyNjozNiswMjAwLCBBbmRyZXcgTHVubiB3cm90ZToKPiA+IE9uIFRodSwgTWF5IDAyLCAyMDI0 IGF0IDExOjMxOjAwQU0gKzAxMDAsIENvbm9yIERvb2xleSB3cm90ZTogIAo+ID4gPiBPbiBUaHUs IE1heSAwMiwgMjAyNCBhdCAxMTo1MDo0M0FNICswMjAwLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6ICAK PiA+ID4gPiBIaSBBbmRyZXcsCj4gPiA+ID4gCj4gPiA+ID4gT24gVHVlLCAzMCBBcHIgMjAyNCAx ODozMTo0NiArMDIwMAo+ID4gPiA+IEFuZHJldyBMdW5uIDxhbmRyZXdAbHVubi5jaD4gd3JvdGU6 Cj4gPiA+ID4gICAKPiA+ID4gPiA+ID4gV2UgaGF2ZSB0aGUgc2FtZSBjb25zdHJ1Y3Rpb24gd2l0 aCB0aGUgcGluY3RybCBkcml2ZXIgdXNlZCBpbiB0aGUgTEFOOTY2eAo+ID4gPiA+ID4gPiAgIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waW5jdHJsL21zY2Msb2NlbG90LXBpbmN0 cmwueWFtbAo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gVGhlIHJlc2V0IG5hbWUgaXMgJ3N3aXRj aCcgaW4gdGhlIHBpbmN0cmwgYmluZGluZy4KPiA+ID4gPiA+ID4gSSBjYW4gdXNlIHRoZSBzYW1l IGRlc2NyaXB0aW9uIGhlcmUgYXMgdGhlIG9uZSBwcmVzZW50IGluIHRoZSBwaW5jdHJsIGJpbmRp bmc6Cj4gPiA+ID4gPiA+ICAgZGVzY3JpcHRpb246IE9wdGlvbmFsIHNoYXJlZCBzd2l0Y2ggcmVz ZXQuCj4gPiA+ID4gPiA+IGFuZCBrZWVwICdzd2l0Y2gnIGFzIHJlc2V0IG5hbWUgaGVyZSAoY29u c2lzdGVudCB3aXRoIHBpbmN0cmwgcmVzZXQgbmFtZSkuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4g PiBXaGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGF0ID8gICAgCj4gPiA+ID4gPiAKPiA+ID4gPiA+ IEl0IHdvdWxkIGJlIGdvb2QgdG8gZG9jdW1lbnQgd2hhdCBpdCBpcyBzaGFyZWQgd2l0aC4gU28g aXQgc2VlbXMgdG8gYmUKPiA+ID4gPiA+IHRoZSBzd2l0Y2ggaXRzZWxmLCBwaW5jdGwgYW5kIE1E SU8/IEFueXRoaW5nIGVsc2U/Cj4gPiA+ID4gPiAgIAo+ID4gPiA+IAo+ID4gPiA+IFRvIGJlIGhv bmVzdCwgSSBrbm93IHRoYXQgdGhlIEdQSU8gY29udHJvbGxlciAobWljcm9jaGlwLHNwYXJ4NS1z Z3BpbykgaXMKPiA+ID4gPiBpbXBhY3RlZCBidXQgSSBkb24ndCBrbm93IGlmIGFueXRoaW5nIGVs c2UgaXMgaW1wYWN0ZWQgYnkgdGhpcyByZXNldC4KPiA+ID4gPiBJIGNhbiB1cGRhdGUgdGhlIGRl c2NyaXB0aW9uIHdpdGg6Cj4gPiA+ID4gICBkZXNjcmlwdGlvbjoKPiA+ID4gPiAgICAgT3B0aW9u YWwgc2hhcmVkIHN3aXRjaCByZXNldC4KPiA+ID4gPiAgICAgVGhpcyByZXNldCBpcyBzaGFyZWQg d2l0aCBhdCBsZWFzdCBwaW5jdHJsLCBHUElPLCBNRElPIGFuZCB0aGUgc3dpdGNoCj4gPiA+ID4g ICAgIGl0c2VsZi4KPiA+ID4gPiAKPiA+ID4gPiBEb2VzIGl0IHNvdW5kIGJldHRlciA/ICAKPiA+ ID4gCj4gPiA+ICRkYXlqb2IgaGF0IG9mZiwgYmluZGluZ3MgaGF0IG9uOiBJZiB5b3UgZG9uJ3Qg a25vdywgY2FuIHdlIGdldCBzb21lb25lCj4gPiA+IGZyb20gTWljcm9jaGlwICh0aGVyZSdzIHNv bWUgYW5kIGEgbGlzdCBpbiBDQykgdG8gZmlndXJlIGl0IG91dD8gIAo+ID4gCj4gPiBUaGF0IGlz IHByb2JhYmx5IGEgZ29vZCBpZGVhLCB0aGVyZSBpcyBwb3RlbnRpYWwgZm9yIGhhcmQgdG8gZmlu ZCBidWdzCj4gPiBoZXJlLCB3aGVuIGEgZGV2aWNlIGdldHMgYW4gdW5leHBlY3RlZCByZXNldC4g Q2hhbmdlIHRoZSBvcmRlciB0aGluZ3MKPiA+IHByb2JlLCBvciBhbiB1bmV4cGVjdGVkIEVQUk9E RV9ERUZFUiBjb3VsZCBiZSBpbnRlcmVzdGluZy4KPiA+ICAgCj4gCj4gCj4gVGhlIGRhdGFzaGVl dCBzdGF0ZXM6Cj4gIlRoZSBWQ29yZSBzeXN0ZW0gY29tcHJpc2VzIGFsbCB0aGUgYmxvY2tzIGF0 dGFjaGVkIHRvIHRoZSBWQ29yZSBTaGFyZWQKPiBCdXMgKFNCQSksIGluY2x1ZGluZyB0aGUgUENJ ZSwgRERSLCBmcmFtZSBETUEsIFNJIHNsYXZlLCBhbmQgTUlJTSBzbGF2ZQo+IGJsb2Nrcy4gVGhl IGRldmljZSBpbmNsdWRlcyBhbGwgdGhlIGJsb2NrcyBhdHRhY2hlZCB0byB0aGUgU3dpdGNoIENv cmUKPiBSZWdpc3RlciBCdXMgKENTUikgaW5jbHVkaW5nIHRoZSBWUkFQIHNsYXZlLiBGb3IgbW9y ZSBpbmZvcm1hdGlvbiBhYm91dAo+IHRoZSBWQ29yZSBTeXN0ZW0gYmxvY2tzLCBzZWUgRmlndXJl IDUtMS4iCj4gCj4gSG93ZXZlciwgdGhlIHJlc2V0IGRyaXZlciBwcm90ZWN0cyB0aGUgVkNPUkUg aXRzZWxmIGJ5IHNldHRpbmcgYml0IDUuCj4gRXZlcnl0aGluZyBlbHNlIGlzIGdvaW5nIHRvIGJl IHJlc2V0Lgo+IAoKUmlnaHQsCkkgd2lsbCB1cGRhdGUgdGhlIHJlc2V0IGRlc2NyaXB0aW9uIHdp dGg6CiAgZGVzY3JpcHRpb246CiAgICBPcHRpb25hbCBzaGFyZWQgc3dpdGNoIHJlc2V0LgogICAg VGhpcyByZXNldCBpcyBzaGFyZWQgd2l0aCBhbGwgYmxvY2tzIGF0dGFjaGVkIHRvIHRoZSBTd2l0 Y2ggQ29yZSBSZWdpc3RlcgogICAgQnVzIChDU1IpIGluY2x1ZGluZyBWUkFQIHNsYXZlLgoKSXMg dGhhdCBiZXR0ZXIgPwoKQmVzdCByZWdhcmRzLApIZXJ2w6kKLS0gCkhlcnbDqSBDb2RpbmEsIEJv b3RsaW4KRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3Rs aW4uY29tCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==