All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Love Kumar <love.kumar@amd.com>
Cc: u-boot@lists.denx.de, michal.simek@amd.com, git@xilinx.com
Subject: Re: [PATCH v4] test/py: net_boot: Add test cases for net boot
Date: Fri, 3 May 2024 14:07:20 -0600	[thread overview]
Message-ID: <20240503200720.GA2559049@bill-the-cat> (raw)
In-Reply-To: <d08d45f50dcdfb70e22a27cf13a990bcc2c020fc.1714738132.git.love.kumar@amd.com>

[-- Attachment #1: Type: text/plain, Size: 1726 bytes --]

On Fri, May 03, 2024 at 05:39:46PM +0530, Love Kumar wrote:

> Add tests for booting image using tftpboot/pxe boot commands, tftpboot
> boot case loads the FIT image into DDR and boots using bootm command
> whereas pxe boot cases downloads the pxe configuration file from the
> TFTP server and interprets it to boot the images mentioned in the pxe
> configurations file.
> This test relies on boardenv_* containing configuration values including
> the parameter 'pattern'. tftpboot/pxe boot cases boots the Linux till the
> boot log pattern value is matched. For example, if the parameter
> 'pattern' is defined as 'login:', it will boot till login prompt.
> 
> Signed-off-by: Love Kumar <love.kumar@amd.com>
> ---
> Changes in v2:
>  - Expand commit message
> Changes in v3:
>  - Add the config option to skip the test
>  - Remove imi command to check FIT image config
>  - Configure static networking only if DHCP fails
> Changes in v4:
>  - Use configured timeout for tftpboot

Getting closer! Can we make this more robust and check for failure strings too?
For example:
U-Boot> tftpboot 200000 v6.6/image.fit.nocomp
Waiting for Ethernet connection... done.
Using smsc95xx_eth device
TFTP from server 192.168.1.10; our IP address is 192.168.1.100
Filename 'v6.6/image.fit.nocomp'.
Load address: 0x200000
Loading: ##################################################  82 MiB
         2.7 MiB/s
done
Bytes transferred = 85984256 (5200400 hex)
U-Boot> U-Boot> crc32 200000 $filesize
CRC32 for 00200000 ... 054003ff ==> 754c839a
U-Boot> U-Boot> bootm 200000
Wrong Image Type for bootm command
ERROR -91: can't get kernel image!
U-Boot>

This only fails when we hit timeout.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2024-05-03 20:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03 12:09 [PATCH v4] test/py: net_boot: Add test cases for net boot Love Kumar
2024-05-03 20:07 ` Tom Rini [this message]
2024-05-03 20:18 ` Tom Rini
2024-05-07  5:52   ` Love Kumar
2024-05-07 13:20     ` Tom Rini
2024-05-07 13:26       ` Michal Simek
2024-05-07 14:35         ` Tom Rini
2024-05-07 13:26     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240503200720.GA2559049@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=git@xilinx.com \
    --cc=love.kumar@amd.com \
    --cc=michal.simek@amd.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.