From: Simon Horman <horms@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Manish Chopra <manishc@marvell.com>
Subject: Re: [PATCH net-next 3/3] net: qede: use return from qede_flow_parse_ports()
Date: Sat, 4 May 2024 15:59:44 +0100 [thread overview]
Message-ID: <20240504145944.GF2279@kernel.org> (raw)
In-Reply-To: <20240503105505.839342-4-ast@fiberby.net>
On Fri, May 03, 2024 at 10:55:03AM +0000, Asbjørn Sloth Tønnesen wrote:
> When calling qede_flow_parse_ports(), then the
> return code was only used for a non-zero check,
> and then -EINVAL was returned.
>
> qede_flow_parse_ports() can currently fail with:
> * -EINVAL
>
> This patch changes qede_flow_parse_v{4,6}_common() to
> use the actual return code from qede_flow_parse_ports(),
> so it's no longer assumed that all errors are -EINVAL.
>
> Only compile tested.
>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-04 14:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 10:55 [PATCH net-next 0/3] net: qede: don't restrict error codes Asbjørn Sloth Tønnesen
2024-05-03 10:55 ` [PATCH net-next 1/3] net: qede: use return from qede_parse_actions() for flow_spec Asbjørn Sloth Tønnesen
2024-05-04 14:59 ` Simon Horman
2024-05-03 10:55 ` [PATCH net-next 2/3] net: qede: use return from qede_flow_spec_validate_unused() Asbjørn Sloth Tønnesen
2024-05-04 14:59 ` Simon Horman
2024-05-03 10:55 ` [PATCH net-next 3/3] net: qede: use return from qede_flow_parse_ports() Asbjørn Sloth Tønnesen
2024-05-04 14:59 ` Simon Horman [this message]
2024-05-07 9:20 ` [PATCH net-next 0/3] net: qede: don't restrict error codes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504145944.GF2279@kernel.org \
--to=horms@kernel.org \
--cc=ast@fiberby.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.