From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Woodrow Douglass <wdouglass@carnegierobotics.com>,
Rahul Bedarkar <rahulbedarkar89@gmail.com>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/glog: needs gcc >= 6
Date: Sun, 5 May 2024 16:28:39 +0200 [thread overview]
Message-ID: <20240505162839.10ee98c9@windsurf> (raw)
In-Reply-To: <20240411173855.583816-1-fontaine.fabrice@gmail.com>
On Thu, 11 Apr 2024 19:38:55 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> C++14 is mandatory since bump to version 0.7.0 in commit
> 2e9f161d4a7a68a041860e5855e98bee9d3a1498 and
> https://github.com/google/glog/commit/674283420118bb919f83ceb3d9dee31ef43ff3aa
> and
> https://github.com/google/glog/commit/42a185cd888439d500a35191cd31a605b7c5bd20
> resulting in the following build failure with gcc 5:
>
> In file included from /home/buildroot/autobuild/run/instance-2/output-1/build/glog-0.7.0/src/demangle.cc:43:0:
> /home/buildroot/autobuild/run/instance-2/output-1/build/glog-0.7.0/src/utilities.h:210:22: error: enclosing class of constexpr non-static member function 'google::glog_internal_namespace_::FileDescriptor::operator bool() const' is not a literal type
> constexpr explicit operator bool() const noexcept {
> ^
>
> Fixes: 2e9f161d4a7a68a041860e5855e98bee9d3a1498
> - http://autobuild.buildroot.org/results/8d5e105283ead1057545b46726385f4ba4dff29e
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/glog/Config.in | 6 ++++--
> package/opencv4-contrib/Config.in | 4 ++++
> 2 files changed, 8 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-05 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 17:38 [Buildroot] [PATCH 1/1] package/glog: needs gcc >= 6 Fabrice Fontaine
2024-05-05 14:28 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240505162839.10ee98c9@windsurf \
--to=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=rahulbedarkar89@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.