From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6DA2A6116 for ; Mon, 6 May 2024 00:44:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714956259; cv=none; b=ZSzO3m2wMndfGFNXPGc0Ol8zwI+SEH0TFgH7Dmwrttg22ALBYR1ThOV+gftdaHH6GiuoBIOzxl75qpHCfMCermBF2nFqbkIem7d1bX6udvg8afjxL/xl07YlMleyn6yBkkhJYsc4A2WnbEkGItQFQgyNlp/rRNSTGENVFwJpmY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714956259; c=relaxed/simple; bh=GBd0kTlfb2pvMARvm/VXwpJAhbMrebnhIvnXnaXt7jg=; h=Date:To:From:Subject:Message-Id; b=F1o4hxW9+kx3i2PjBG9J5BTrJ9wQxbv2U7oemA67qvhLTF4q5pMftnt4YIkNa0uMF84w3snSw1rBVQQMzXczO4JuWwcoM7+z55v2GSUsPxfzfmQetDy00opq4eqr5lwijtmQFoMlBEWje36a1BoxqzmCKV6ayxSfe5VGYXvRSq8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=hNxto0hv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="hNxto0hv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED363C113CC; Mon, 6 May 2024 00:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1714956259; bh=GBd0kTlfb2pvMARvm/VXwpJAhbMrebnhIvnXnaXt7jg=; h=Date:To:From:Subject:From; b=hNxto0hv7dfZ6ZPDeJClikbSSASlOGmpRaC1pfeYm35k3V26ifC0zyPJzSrvlmZgK 8d4xzkU68vFo+b6PDgtkfljJgC3Wo3fYQLLN6OlT8y99REre/F575MCT5hESqwnEVF 2yyqPjJ5iug9Z+ek70DJiVef92YBUnJ2AAx4qWow= Date: Sun, 05 May 2024 17:44:18 -0700 To: mm-commits@vger.kernel.org,nphamcs@gmail.com,mail@maciej.szmigiero.name,hannes@cmpxchg.org,chengming.zhou@linux.dev,yosryahmed@google.com,akpm@linux-foundation.org From: Andrew Morton Subject: [folded-merged] mm-zswap-remove-same_filled-module-params-fix.patch removed from -mm tree Message-Id: <20240506004418.ED363C113CC@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm: zswap: remove same_filled_pages from docs has been removed from the -mm tree. Its filename was mm-zswap-remove-same_filled-module-params-fix.patch This patch was dropped because it was folded into mm-zswap-remove-same_filled-module-params.patch ------------------------------------------------------ From: Yosry Ahmed Subject: mm: zswap: remove same_filled_pages from docs Date: Sun, 14 Apr 2024 21:03:43 +0000 The module parameters are now removed, remove all references from kernel docs. Link: https://lkml.kernel.org/r/ZhxFVggdyvCo79jc@google.com Signed-off-by: Yosry Ahmed Cc: Chengming Zhou Cc: Johannes Weiner Cc: "Maciej S. Szmigiero" Cc: Nhat Pham Signed-off-by: Andrew Morton --- Documentation/admin-guide/mm/zswap.rst | 29 ----------- Documentation/driver-api/crypto/iaa/iaa-crypto.rst | 2 2 files changed, 31 deletions(-) --- a/Documentation/admin-guide/mm/zswap.rst~mm-zswap-remove-same_filled-module-params-fix +++ a/Documentation/admin-guide/mm/zswap.rst @@ -111,35 +111,6 @@ checked if it is a same-value filled pag compressed length of the page is set to zero and the pattern or same-filled value is stored. -Same-value filled pages identification feature is enabled by default and can be -disabled at boot time by setting the ``same_filled_pages_enabled`` attribute -to 0, e.g. ``zswap.same_filled_pages_enabled=0``. It can also be enabled and -disabled at runtime using the sysfs ``same_filled_pages_enabled`` -attribute, e.g.:: - - echo 1 > /sys/module/zswap/parameters/same_filled_pages_enabled - -When zswap same-filled page identification is disabled at runtime, it will stop -checking for the same-value filled pages during store operation. -In other words, every page will be then considered non-same-value filled. -However, the existing pages which are marked as same-value filled pages remain -stored unchanged in zswap until they are either loaded or invalidated. - -In some circumstances it might be advantageous to make use of just the zswap -ability to efficiently store same-filled pages without enabling the whole -compressed page storage. -In this case the handling of non-same-value pages by zswap (enabled by default) -can be disabled by setting the ``non_same_filled_pages_enabled`` attribute -to 0, e.g. ``zswap.non_same_filled_pages_enabled=0``. -It can also be enabled and disabled at runtime using the sysfs -``non_same_filled_pages_enabled`` attribute, e.g.:: - - echo 1 > /sys/module/zswap/parameters/non_same_filled_pages_enabled - -Disabling both ``zswap.same_filled_pages_enabled`` and -``zswap.non_same_filled_pages_enabled`` effectively disables accepting any new -pages by zswap. - To prevent zswap from shrinking pool when zswap is full and there's a high pressure on swap (this will result in flipping pages in and out zswap pool without any real benefit but with a performance drop for the system), a --- a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst~mm-zswap-remove-same_filled-module-params-fix +++ a/Documentation/driver-api/crypto/iaa/iaa-crypto.rst @@ -457,7 +457,6 @@ Use the following commands to enable zsw # echo deflate-iaa > /sys/module/zswap/parameters/compressor # echo zsmalloc > /sys/module/zswap/parameters/zpool # echo 1 > /sys/module/zswap/parameters/enabled - # echo 0 > /sys/module/zswap/parameters/same_filled_pages_enabled # echo 100 > /proc/sys/vm/swappiness # echo never > /sys/kernel/mm/transparent_hugepage/enabled # echo 1 > /proc/sys/vm/overcommit_memory @@ -599,7 +598,6 @@ the 'fixed' compression mode:: echo deflate-iaa > /sys/module/zswap/parameters/compressor echo zsmalloc > /sys/module/zswap/parameters/zpool echo 1 > /sys/module/zswap/parameters/enabled - echo 0 > /sys/module/zswap/parameters/same_filled_pages_enabled echo 100 > /proc/sys/vm/swappiness echo never > /sys/kernel/mm/transparent_hugepage/enabled _ Patches currently in -mm which might be from yosryahmed@google.com are mm-zswap-always-shrink-in-zswap_store-if-zswap_pool_reached_full.patch mm-zswap-refactor-limit-checking-from-zswap_store.patch mm-zswap-move-more-same-filled-pages-checks-outside-of-zswap_store.patch mm-zswap-remove-same_filled-module-params.patch