From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Subject: Re: [PATCH] nvmet: make nvmet_wq unbound
Date: Mon, 6 May 2024 07:33:08 +0200 [thread overview]
Message-ID: <20240506053308.GA5030@lst.de> (raw)
In-Reply-To: <20240505103951.52413-1-sagi@grimberg.me>
On Sun, May 05, 2024 at 01:39:51PM +0300, Sagi Grimberg wrote:
> From: Sagi Grimberg <sagi.grimberg@vastdata.com>
>
> When deleting many controllers one-by-one, it takes a very
> long time as these work elements may serialize as they are
> scheduled on the executing cpu instead of spreading. In general
> nvmet_wq can definitely be used for long standing work elements
> so its better to make it unbound regardless.
This looks sensible, thanks.
> While we are at it, expose it via sysfs to allow cpumask
> control of this workqueue if a user wants to modify it.
This on the other looks very questionable to me. It needs a way better
justification and should be split into a separate patch if we really
need it.
next prev parent reply other threads:[~2024-05-06 5:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 10:39 [PATCH] nvmet: make nvmet_wq unbound Sagi Grimberg
2024-05-06 5:33 ` Christoph Hellwig [this message]
2024-05-06 7:50 ` Sagi Grimberg
2024-05-06 12:08 ` Christoph Hellwig
2024-05-06 14:05 ` Sagi Grimberg
2024-05-06 14:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506053308.GA5030@lst.de \
--to=hch@lst.de \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.