From: Bjorn Helgaas <helgaas@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
bhelgaas@google.com, dave.hansen@linux.intel.com, x86@kernel.org,
linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op'
Date: Mon, 6 May 2024 10:23:04 -0500 [thread overview]
Message-ID: <20240506152304.GA1699729@bhelgaas> (raw)
In-Reply-To: <ZjjsiO33y08dJLPX@gallifrey>
On Mon, May 06, 2024 at 02:43:20PM +0000, Dr. David Alan Gilbert wrote:
> * Ilpo Järvinen (ilpo.jarvinen@linux.intel.com) wrote:
> > On Mon, 6 May 2024, linux@treblig.org wrote:
> >
> > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > >
> > > This doesn't look like it was ever used.
> >
> > Don't start with "This" but spell what you're talking about out so it
> > can be read and understood without shortlog in Subject (or looking into
> > the code change).
>
> I'm of course happy to rework that if it helps you, although
> I thought the subject line was sufficient.
It's a minor point, to be sure. The way I think about this is "an
essay title is not part of the essay itself," so the essay (commit
log) should make sense all by itself.
Bjorn
next prev parent reply other threads:[~2024-05-06 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:46 [PATCH] x86: ce4100: Remove unused struct 'sim_reg_op' linux
2024-05-06 14:17 ` Ilpo Järvinen
2024-05-06 14:43 ` Dr. David Alan Gilbert
2024-05-06 15:23 ` Bjorn Helgaas [this message]
2024-05-07 23:24 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506152304.GA1699729@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@treblig.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.