From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87EF6C25B5F for ; Mon, 6 May 2024 13:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/3uVlZBrQkZvFzhISCXxybsONzTl54vA9PlT79HQghU=; b=nE5DrLRR0SkDoW BfR9lcnMD8q5Mi5j8QP1iA4NRZ6bw9TFwzNsG3+ZZqRg1WLz/EHRDp01utUHykmATZSQbbopVGoFm RCyQe2bCcXTlUnRSclKSj6JvwgVQex3N4O2FU5DfWXC2vaTgfqsofAKSPJBwV0HQgWICWfGoQEHsd Bqfcs+javYKNOwovHmjGgsZJb1krebcYHbnIG54JKmuiVNgwmH7HZNAct5sQRqVkTtedYhdjszfjL kEAMRVoy9XsfcMU34ol4y91UwcRZ+wZibkN/2dkO4FYFfDkU+u5Eb7SNnU9BM8zm6r8hY0U0OHELo V2M9O6jn/Rrw9BW5NdUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymc-00000007Y54-19gt; Mon, 06 May 2024 13:53:34 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymZ-00000007Y4F-09Jn; Mon, 06 May 2024 13:53:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id CFD9C60002; Mon, 6 May 2024 13:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715003606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rl4J4sIVm+WsZbjOlT+E1mrylIFIWJ8bHbGao9o7iXw=; b=oo8780SlEJkCVOPPXFOPXAqPxufjs+dTIjDui17WFF/ls4iGGmMYvS8ZmJlz0Ph+EhTCmV 9Dmitav+5z38uU64tHCsETTex1QgZnE2ipeEHFHy1cpMaMnQuqDDt//UKA6dS8B01odvtH shs2EgcW1RgDT71l3ESfZnostdVzXOtWK/uSZ1GOEt5wjWudIuWCy8Xe2wUIeZbWzz5q4x RTt5L43U1Bxoobv7ifVBN1iSOXKbgXAYMlLFjNWqhRrrZYKYrs8dHNukALuVTWi0/hwKHN QCg9mcVvrd8QYy8kGZkskUKV7wSveAf/nw85zKkyHHkZYrhf56GUTdDGxUzFJA== Date: Mon, 6 May 2024 15:53:22 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [PATCH v5 2/2] mtd: rawnand: meson: support R/W mode for boot ROM Message-ID: <20240506155322.002346d0@xps-13> In-Reply-To: <20240416085101.740458-3-avkrasnov@salutedevices.com> References: <20240416085101.740458-1-avkrasnov@salutedevices.com> <20240416085101.740458-3-avkrasnov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240506_065331_395315_D7194AC3 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYWx1dGVkZXZpY2VzLmNvbSB3cm90ZSBvbiBUdWUsIDE2 IEFwciAyMDI0IDExOjUxOjAxICswMzAwOgoKPiBCb290IFJPTSBjb2RlIG9uIE1lc29uIHJlcXVp cmVzIHRoYXQgc29tZSBwYWdlcyBvbiBOQU5EIG11c3QgYmUgd3JpdHRlbgo+IGluIHNwZWNpYWwg bW9kZTogInNob3J0IiBFQ0MgbW9kZSB3aGVyZSBlYWNoIGJsb2NrIGlzIDM4NCBieXRlcyBhbmQK PiBzY3JhbWJsaW5nIG1vZGUgaXMgb24uIFN1Y2ggcGFnZXMgbG9jYXRlZCB3aXRoIHRoZSBzcGVj aWZpZWQgaW50ZXJ2YWwKPiB3aXRoaW4gc3BlY2lmaWVkIG9mZnNldC4gQm90aCBpbnRlcnZhbCBh bmQgb2Zmc2V0IGFyZSBsb2NhdGVkIGluIHRoZQo+IGRldmljZSB0cmVlIGFuZCB1c2VkIGJ5IGRy aXZlciBpZiAnbmFuZC1pcy1ib290LW1lZGl1bScgaXMgc2V0IGZvcgo+IE5BTkQgY2hpcC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPGF2a3Jhc25vdkBzYWx1dGVkZXZpY2Vz LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgODggKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0 aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25h bmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ IGluZGV4IDAwY2UwZTViYjk3MC4uOWVlMTEyNDNiMjU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IEBAIC0zNSw2ICszNSw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9SQgkJQklU KDIwKQo+ICAjZGVmaW5lIE5GQ19DTURfU0NSQU1CTEVSX0VOQUJMRQlCSVQoMTkpCj4gICNkZWZp bmUgTkZDX0NNRF9TQ1JBTUJMRVJfRElTQUJMRQkwCj4gKyNkZWZpbmUgTkZDX0NNRF9TSE9SVE1P REVfRU5BQkxFCTEKPiAgI2RlZmluZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAgI2Rl ZmluZSBORkNfQ01EX1JCX0lOVAkJQklUKDE0KQo+ICAjZGVmaW5lIE5GQ19DTURfUkJfSU5UX05P X1BJTgkoKDB4YiA8PCAxMCkgfCBCSVQoMTgpIHwgQklUKDE2KSkKPiBAQCAtNzgsNiArNzksOCBA QAo+ICAjZGVmaW5lIERNQV9ESVIoZGlyKQkJKChkaXIpID8gTkZDX0NNRF9OMk0gOiBORkNfQ01E X00yTikKPiAgI2RlZmluZSBETUFfQUREUl9BTElHTgkJOAo+ICAKPiArI2RlZmluZSBORkNfU0hP UlRfTU9ERV9FQ0NfU1oJMzg0Cj4gKwo+ICAjZGVmaW5lIEVDQ19DSEVDS19SRVRVUk5fRkYJKC0x KQo+ICAKPiAgI2RlZmluZSBOQU5EX0NFMAkJKDB4ZSA8PCAxMCkKPiBAQCAtMTI1LDYgKzEyOCw4 IEBAIHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwIHsKPiAgCXUzMiB0d2I7Cj4gIAl1MzIgdGFk bDsKPiAgCXUzMiB0YmVyc19tYXg7Cj4gKwl1MzIgYm9vdF9wYWdlczsKPiArCXUzMiBib290X3Bh Z2Vfc3RlcDsKPiAgCj4gIAl1MzIgYmNoX21vZGU7Cj4gIAl1OCAqZGF0YV9idWY7Cj4gQEAgLTI5 OCwyOCArMzAzLDQ5IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfc2VlZChzdHJ1Y3QgbWVz b25fbmZjICpuZmMsIHUzMiBzZWVkKQo+ICAJICAgICAgIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVH X0NNRCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVj dCBuYW5kX2NoaXAgKm5hbmQsIGludCByYXcsIGJvb2wgZGlyLAo+IC0JCQkJIGludCBzY3JhbWJs ZXIpCj4gK3N0YXRpYyBpbnQgbWVzb25fbmZjX3BhZ2VfaXNfYm9vdChzdHJ1Y3QgbmFuZF9jaGlw ICpuYW5kLCBpbnQgcGFnZSkKCm1lc29uX25mY19pc19ib290X3BhZ2UoKSBpcyBlYXNpZXIgdG8g cmVhZAoKPiArewo+ICsJY29uc3Qgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2No aXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ICsKPiArCXJldHVybiAobmFuZC0+b3B0aW9ucyAm IE5BTkRfSVNfQk9PVF9NRURJVU0pICYmCj4gKwkgICAgICAgIShwYWdlICUgbWVzb25fY2hpcC0+ Ym9vdF9wYWdlX3N0ZXApICYmCgpJIHdvdWxkIGRlZGljYXRlIGFsbCB0aGUgc3BhY2UgYmVsb3cg LT5ib290X3BhZ2VzIHRvIHRoZSBib290cm9tLCBubz8KVXNpbmcgc3BhY2UgaW4gYmV0d2VlbiBz b3VuZHMgc2lsbHkuCgo+ICsJICAgICAgIChwYWdlIDwgbWVzb25fY2hpcC0+Ym9vdF9wYWdlcyk7 Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQsIGJvb2wgcmF3LCBib29sIGRpciwgaW50IHBhZ2UpCj4gIHsKPiArCWNvbnN0 IHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVzb25fbmFuZChu YW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAlz dHJ1Y3QgbWVzb25fbmZjICpuZmMgPSBuYW5kX2dldF9jb250cm9sbGVyX2RhdGEobXRkX3RvX25h bmQobXRkKSk7Cj4gLQlzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCAqbWVzb25fY2hpcCA9IHRv X21lc29uX25hbmQobmFuZCk7Cj4gLQl1MzIgYmNoID0gbWVzb25fY2hpcC0+YmNoX21vZGUsIGNt ZDsKPiAgCWludCBsZW4gPSBtdGQtPndyaXRlc2l6ZSwgcGFnZXNpemUsIHBhZ2VzOwo+ICsJaW50 IHNjcmFtYmxlcjsKPiArCXUzMiBjbWQ7Cj4gIAo+IC0JcGFnZXNpemUgPSBuYW5kLT5lY2Muc2l6 ZTsKPiArCWlmIChuYW5kLT5vcHRpb25zICYgTkFORF9ORUVEX1NDUkFNQkxJTkcpCj4gKwkJc2Ny YW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxFOwo+ICsJZWxzZQo+ICsJCXNjcmFtYmxl ciA9IE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEU7CgpUaGF0IGlzIGEgc2VwYXJhdGUgZmVhdHVy ZT8KCj4gIAo+ICAJaWYgKHJhdykgewo+ICAJCWxlbiA9IG10ZC0+d3JpdGVzaXplICsgbXRkLT5v b2JzaXplOwo+ICAJCWNtZCA9IGxlbiB8IHNjcmFtYmxlciB8IERNQV9ESVIoZGlyKTsKPiAtCQl3 cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQpOwo+IC0JCXJldHVybjsKPiAt CX0KPiArCX0gZWxzZSBpZiAobWVzb25fbmZjX3BhZ2VfaXNfYm9vdChuYW5kLCBwYWdlKSkgewo+ ICsJCXBhZ2VzaXplID0gTkZDX1NIT1JUX01PREVfRUNDX1NaID4+IDM7Cj4gKwkJcGFnZXMgPSBt dGQtPndyaXRlc2l6ZSAvIDUxMjsKPiArCj4gKwkJc2NyYW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJM RVJfRU5BQkxFOwo+ICsJCWNtZCA9IENNRFJXR0VOKERNQV9ESVIoZGlyKSwgc2NyYW1ibGVyLCBO RkNfRUNDX0JDSDhfMUssCj4gKwkJCSAgICAgICBORkNfQ01EX1NIT1JUTU9ERV9FTkFCTEUsIHBh Z2VzaXplLCBwYWdlcyk7Cj4gKwl9IGVsc2Ugewo+ICsJCXBhZ2VzaXplID0gbmFuZC0+ZWNjLnNp emUgPj4gMzsKPiArCQlwYWdlcyA9IGxlbiAvIG5hbmQtPmVjYy5zaXplOwo+ICAKPiAtCXBhZ2Vz ID0gbGVuIC8gbmFuZC0+ZWNjLnNpemU7Cj4gKwkJY21kID0gQ01EUldHRU4oRE1BX0RJUihkaXIp LCBzY3JhbWJsZXIsIG1lc29uX2NoaXAtPmJjaF9tb2RlLAo+ICsJCQkgICAgICAgTkZDX0NNRF9T SE9SVE1PREVfRElTQUJMRSwgcGFnZXNpemUsIHBhZ2VzKTsKPiArCX0KPiAgCj4gLQljbWQgPSBD TURSV0dFTihETUFfRElSKGRpciksIHNjcmFtYmxlciwgYmNoLAo+IC0JCSAgICAgICBORkNfQ01E X1NIT1JUTU9ERV9ESVNBQkxFLCBwYWdlc2l6ZSwgcGFnZXMpOwo+ICsJaWYgKHNjcmFtYmxlciA9 PSBORkNfQ01EX1NDUkFNQkxFUl9FTkFCTEUpCj4gKwkJbWVzb25fbmZjX2NtZF9zZWVkKG5mYywg cGFnZSk7Cj4gIAo+ICAJd3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsK PiAgfQo+IEBAIC03NDMsMTUgKzc2OSw3IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3dyaXRlX3Bh Z2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiBy ZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NSQU1CTElORykgewo+ IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29uX25mY19jbWRfYWNj ZXNzKG5hbmQsIHJhdywgRElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0VO QUJMRSk7Cj4gLQl9IGVsc2Ugewo+IC0JCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywg RElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEUpOwo+IC0JfQo+ IC0KCk9rIEkgZ2V0IGl0LCB0aGUgZmVhdHVyZSBhbHJlYWR5IGV4aXN0IGJ1dCBpcyBoYW5kbGVk IGRpZmZlcmVudGx5LgpQbGVhc2Ugc3BsaXQgdGhpcyBwYXRjaDoKLSBpbXByb3ZlIHNjcmFtYmxl ciBoYW5kbGluZyB0byBmYWNpbGl0YXRlIGJvb3QgcGFnZSBzdXBwb3J0Ci0gYWRkIGJvb3QgcGFn ZXMgc3VwcG9ydAoKPiArCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSV1JJVEUs IHBhZ2UpOwo+ICAJY21kID0gbmZjLT5wYXJhbS5jaGlwX3NlbGVjdCB8IE5GQ19DTURfQ0xFIHwg TkFORF9DTURfUEFHRVBST0c7Cj4gIAl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JF R19DTUQpOwo+ICAJbWVzb25fbmZjX3F1ZXVlX3JiKG5hbmQsIFBTRUNfVE9fTVNFQyhzZHItPnRQ Uk9HX21heCksIGZhbHNlKTsKPiBAQCAtODI5LDE1ICs4NDcsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NS QU1CTElORykgewo+IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29u X25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSUkVBRCwKPiAtCQkJCSAgICAgTkZDX0NNRF9T Q1JBTUJMRVJfRU5BQkxFKTsKPiAtCX0gZWxzZSB7Cj4gLQkJbWVzb25fbmZjX2NtZF9hY2Nlc3Mo bmFuZCwgcmF3LCBESVJSRUFELAo+IC0JCQkJICAgICBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxF KTsKPiAtCX0KPiAtCj4gKwltZXNvbl9uZmNfY21kX2FjY2VzcyhuYW5kLCByYXcsIERJUlJFQUQs IHBhZ2UpOwo+ICAJcmV0ID0gbWVzb25fbmZjX3dhaXRfZG1hX2ZpbmlzaChuZmMpOwo+ICAJbWVz b25fbmZjX2NoZWNrX2VjY19wYWdlc192YWxpZChuZmMsIG5hbmQsIHJhdyk7Cj4gIAo+IEBAIC0x NDM2LDYgKzE0NDYsMjYgQEAgbWVzb25fbmZjX25hbmRfY2hpcF9pbml0KHN0cnVjdCBkZXZpY2Ug KmRldiwKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlpZiAobmFuZC0+b3B0 aW9ucyAmIE5BTkRfSVNfQk9PVF9NRURJVU0pIHsKPiArCQlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFk X3UzMihucCwgImFtbG9naWMsYm9vdC1wYWdlcyIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJv b3RfcGFnZXMpOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2VycihkZXYsICJjb3VsZCBub3Qg cmV0cmlldmUgJ2FtbG9naWMsYm9vdC1wYWdlcycgcHJvcGVydHk6ICVkIiwKPiArCQkJCXJldCk7 Cj4gKwkJCW5hbmRfY2xlYW51cChuYW5kKTsKPiArCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwo+ ICsJCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAiYW1sb2dpYyxib290LXBhZ2Utc3Rl cCIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJvb3RfcGFnZV9zdGVwKTsKPiArCQlpZiAocmV0 KSB7Cj4gKwkJCWRldl9lcnIoZGV2LCAiY291bGQgbm90IHJldHJpZXZlICdhbWxvZ2ljLGJvb3Qt cGFnZS1zdGVwJyBwcm9wZXJ0eTogJWQiLAo+ICsJCQkJcmV0KTsKPiArCQkJbmFuZF9jbGVhbnVw KG5hbmQpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0KPiArCj4gIAlyZXQgPSBtdGRf ZGV2aWNlX3JlZ2lzdGVyKG10ZCwgTlVMTCwgMCk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2Vy cihkZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIgTVREIGRldmljZTogJWRcbiIsIHJldCk7CgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FABFC10F16 for ; Mon, 6 May 2024 13:53:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oQuqOwvWNN7Sq5UjXBcJuoDkMgb2QjAsAWV2+KitI/Y=; b=nt6eeLue/ID1h6 2uEdpN526A0veWZdZfZe0Bteptx3tH/SFF34zI/FBwr8093KB16AKQb0/JrFJFzxzF/j610Psl//p M+kyIkoimIHBmWMafDGLJNHLUz0HfnArMq7RB2GnnMokIhU9sMwDI+4O/gVgdpssuo234ZUih9/pd n7H/imoHYVHgVJUfTXSPxw42pdOTyKDyuNdFQDFihfI3t/ftp9i3UVZSKAnFWiyJ1woSalil6mWv+ +lYMXUKA19dVq1HMTy2iVLewy4sySvUcQNtnou1XLF8toqtyxErzmbnwTMXBrzV7aRL4iP0yZMSqP tWylaClbL3u2smOhoSFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymd-00000007Y5E-0zpp; Mon, 06 May 2024 13:53:35 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymZ-00000007Y4F-09Jn; Mon, 06 May 2024 13:53:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id CFD9C60002; Mon, 6 May 2024 13:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715003606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rl4J4sIVm+WsZbjOlT+E1mrylIFIWJ8bHbGao9o7iXw=; b=oo8780SlEJkCVOPPXFOPXAqPxufjs+dTIjDui17WFF/ls4iGGmMYvS8ZmJlz0Ph+EhTCmV 9Dmitav+5z38uU64tHCsETTex1QgZnE2ipeEHFHy1cpMaMnQuqDDt//UKA6dS8B01odvtH shs2EgcW1RgDT71l3ESfZnostdVzXOtWK/uSZ1GOEt5wjWudIuWCy8Xe2wUIeZbWzz5q4x RTt5L43U1Bxoobv7ifVBN1iSOXKbgXAYMlLFjNWqhRrrZYKYrs8dHNukALuVTWi0/hwKHN QCg9mcVvrd8QYy8kGZkskUKV7wSveAf/nw85zKkyHHkZYrhf56GUTdDGxUzFJA== Date: Mon, 6 May 2024 15:53:22 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [PATCH v5 2/2] mtd: rawnand: meson: support R/W mode for boot ROM Message-ID: <20240506155322.002346d0@xps-13> In-Reply-To: <20240416085101.740458-3-avkrasnov@salutedevices.com> References: <20240416085101.740458-1-avkrasnov@salutedevices.com> <20240416085101.740458-3-avkrasnov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240506_065331_395315_D7194AC3 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYWx1dGVkZXZpY2VzLmNvbSB3cm90ZSBvbiBUdWUsIDE2 IEFwciAyMDI0IDExOjUxOjAxICswMzAwOgoKPiBCb290IFJPTSBjb2RlIG9uIE1lc29uIHJlcXVp cmVzIHRoYXQgc29tZSBwYWdlcyBvbiBOQU5EIG11c3QgYmUgd3JpdHRlbgo+IGluIHNwZWNpYWwg bW9kZTogInNob3J0IiBFQ0MgbW9kZSB3aGVyZSBlYWNoIGJsb2NrIGlzIDM4NCBieXRlcyBhbmQK PiBzY3JhbWJsaW5nIG1vZGUgaXMgb24uIFN1Y2ggcGFnZXMgbG9jYXRlZCB3aXRoIHRoZSBzcGVj aWZpZWQgaW50ZXJ2YWwKPiB3aXRoaW4gc3BlY2lmaWVkIG9mZnNldC4gQm90aCBpbnRlcnZhbCBh bmQgb2Zmc2V0IGFyZSBsb2NhdGVkIGluIHRoZQo+IGRldmljZSB0cmVlIGFuZCB1c2VkIGJ5IGRy aXZlciBpZiAnbmFuZC1pcy1ib290LW1lZGl1bScgaXMgc2V0IGZvcgo+IE5BTkQgY2hpcC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPGF2a3Jhc25vdkBzYWx1dGVkZXZpY2Vz LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgODggKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0 aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25h bmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ IGluZGV4IDAwY2UwZTViYjk3MC4uOWVlMTEyNDNiMjU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IEBAIC0zNSw2ICszNSw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9SQgkJQklU KDIwKQo+ICAjZGVmaW5lIE5GQ19DTURfU0NSQU1CTEVSX0VOQUJMRQlCSVQoMTkpCj4gICNkZWZp bmUgTkZDX0NNRF9TQ1JBTUJMRVJfRElTQUJMRQkwCj4gKyNkZWZpbmUgTkZDX0NNRF9TSE9SVE1P REVfRU5BQkxFCTEKPiAgI2RlZmluZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAgI2Rl ZmluZSBORkNfQ01EX1JCX0lOVAkJQklUKDE0KQo+ICAjZGVmaW5lIE5GQ19DTURfUkJfSU5UX05P X1BJTgkoKDB4YiA8PCAxMCkgfCBCSVQoMTgpIHwgQklUKDE2KSkKPiBAQCAtNzgsNiArNzksOCBA QAo+ICAjZGVmaW5lIERNQV9ESVIoZGlyKQkJKChkaXIpID8gTkZDX0NNRF9OMk0gOiBORkNfQ01E X00yTikKPiAgI2RlZmluZSBETUFfQUREUl9BTElHTgkJOAo+ICAKPiArI2RlZmluZSBORkNfU0hP UlRfTU9ERV9FQ0NfU1oJMzg0Cj4gKwo+ICAjZGVmaW5lIEVDQ19DSEVDS19SRVRVUk5fRkYJKC0x KQo+ICAKPiAgI2RlZmluZSBOQU5EX0NFMAkJKDB4ZSA8PCAxMCkKPiBAQCAtMTI1LDYgKzEyOCw4 IEBAIHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwIHsKPiAgCXUzMiB0d2I7Cj4gIAl1MzIgdGFk bDsKPiAgCXUzMiB0YmVyc19tYXg7Cj4gKwl1MzIgYm9vdF9wYWdlczsKPiArCXUzMiBib290X3Bh Z2Vfc3RlcDsKPiAgCj4gIAl1MzIgYmNoX21vZGU7Cj4gIAl1OCAqZGF0YV9idWY7Cj4gQEAgLTI5 OCwyOCArMzAzLDQ5IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfc2VlZChzdHJ1Y3QgbWVz b25fbmZjICpuZmMsIHUzMiBzZWVkKQo+ICAJICAgICAgIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVH X0NNRCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVj dCBuYW5kX2NoaXAgKm5hbmQsIGludCByYXcsIGJvb2wgZGlyLAo+IC0JCQkJIGludCBzY3JhbWJs ZXIpCj4gK3N0YXRpYyBpbnQgbWVzb25fbmZjX3BhZ2VfaXNfYm9vdChzdHJ1Y3QgbmFuZF9jaGlw ICpuYW5kLCBpbnQgcGFnZSkKCm1lc29uX25mY19pc19ib290X3BhZ2UoKSBpcyBlYXNpZXIgdG8g cmVhZAoKPiArewo+ICsJY29uc3Qgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2No aXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ICsKPiArCXJldHVybiAobmFuZC0+b3B0aW9ucyAm IE5BTkRfSVNfQk9PVF9NRURJVU0pICYmCj4gKwkgICAgICAgIShwYWdlICUgbWVzb25fY2hpcC0+ Ym9vdF9wYWdlX3N0ZXApICYmCgpJIHdvdWxkIGRlZGljYXRlIGFsbCB0aGUgc3BhY2UgYmVsb3cg LT5ib290X3BhZ2VzIHRvIHRoZSBib290cm9tLCBubz8KVXNpbmcgc3BhY2UgaW4gYmV0d2VlbiBz b3VuZHMgc2lsbHkuCgo+ICsJICAgICAgIChwYWdlIDwgbWVzb25fY2hpcC0+Ym9vdF9wYWdlcyk7 Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQsIGJvb2wgcmF3LCBib29sIGRpciwgaW50IHBhZ2UpCj4gIHsKPiArCWNvbnN0 IHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVzb25fbmFuZChu YW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAlz dHJ1Y3QgbWVzb25fbmZjICpuZmMgPSBuYW5kX2dldF9jb250cm9sbGVyX2RhdGEobXRkX3RvX25h bmQobXRkKSk7Cj4gLQlzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCAqbWVzb25fY2hpcCA9IHRv X21lc29uX25hbmQobmFuZCk7Cj4gLQl1MzIgYmNoID0gbWVzb25fY2hpcC0+YmNoX21vZGUsIGNt ZDsKPiAgCWludCBsZW4gPSBtdGQtPndyaXRlc2l6ZSwgcGFnZXNpemUsIHBhZ2VzOwo+ICsJaW50 IHNjcmFtYmxlcjsKPiArCXUzMiBjbWQ7Cj4gIAo+IC0JcGFnZXNpemUgPSBuYW5kLT5lY2Muc2l6 ZTsKPiArCWlmIChuYW5kLT5vcHRpb25zICYgTkFORF9ORUVEX1NDUkFNQkxJTkcpCj4gKwkJc2Ny YW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxFOwo+ICsJZWxzZQo+ICsJCXNjcmFtYmxl ciA9IE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEU7CgpUaGF0IGlzIGEgc2VwYXJhdGUgZmVhdHVy ZT8KCj4gIAo+ICAJaWYgKHJhdykgewo+ICAJCWxlbiA9IG10ZC0+d3JpdGVzaXplICsgbXRkLT5v b2JzaXplOwo+ICAJCWNtZCA9IGxlbiB8IHNjcmFtYmxlciB8IERNQV9ESVIoZGlyKTsKPiAtCQl3 cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQpOwo+IC0JCXJldHVybjsKPiAt CX0KPiArCX0gZWxzZSBpZiAobWVzb25fbmZjX3BhZ2VfaXNfYm9vdChuYW5kLCBwYWdlKSkgewo+ ICsJCXBhZ2VzaXplID0gTkZDX1NIT1JUX01PREVfRUNDX1NaID4+IDM7Cj4gKwkJcGFnZXMgPSBt dGQtPndyaXRlc2l6ZSAvIDUxMjsKPiArCj4gKwkJc2NyYW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJM RVJfRU5BQkxFOwo+ICsJCWNtZCA9IENNRFJXR0VOKERNQV9ESVIoZGlyKSwgc2NyYW1ibGVyLCBO RkNfRUNDX0JDSDhfMUssCj4gKwkJCSAgICAgICBORkNfQ01EX1NIT1JUTU9ERV9FTkFCTEUsIHBh Z2VzaXplLCBwYWdlcyk7Cj4gKwl9IGVsc2Ugewo+ICsJCXBhZ2VzaXplID0gbmFuZC0+ZWNjLnNp emUgPj4gMzsKPiArCQlwYWdlcyA9IGxlbiAvIG5hbmQtPmVjYy5zaXplOwo+ICAKPiAtCXBhZ2Vz ID0gbGVuIC8gbmFuZC0+ZWNjLnNpemU7Cj4gKwkJY21kID0gQ01EUldHRU4oRE1BX0RJUihkaXIp LCBzY3JhbWJsZXIsIG1lc29uX2NoaXAtPmJjaF9tb2RlLAo+ICsJCQkgICAgICAgTkZDX0NNRF9T SE9SVE1PREVfRElTQUJMRSwgcGFnZXNpemUsIHBhZ2VzKTsKPiArCX0KPiAgCj4gLQljbWQgPSBD TURSV0dFTihETUFfRElSKGRpciksIHNjcmFtYmxlciwgYmNoLAo+IC0JCSAgICAgICBORkNfQ01E X1NIT1JUTU9ERV9ESVNBQkxFLCBwYWdlc2l6ZSwgcGFnZXMpOwo+ICsJaWYgKHNjcmFtYmxlciA9 PSBORkNfQ01EX1NDUkFNQkxFUl9FTkFCTEUpCj4gKwkJbWVzb25fbmZjX2NtZF9zZWVkKG5mYywg cGFnZSk7Cj4gIAo+ICAJd3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsK PiAgfQo+IEBAIC03NDMsMTUgKzc2OSw3IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3dyaXRlX3Bh Z2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiBy ZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NSQU1CTElORykgewo+ IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29uX25mY19jbWRfYWNj ZXNzKG5hbmQsIHJhdywgRElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0VO QUJMRSk7Cj4gLQl9IGVsc2Ugewo+IC0JCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywg RElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEUpOwo+IC0JfQo+ IC0KCk9rIEkgZ2V0IGl0LCB0aGUgZmVhdHVyZSBhbHJlYWR5IGV4aXN0IGJ1dCBpcyBoYW5kbGVk IGRpZmZlcmVudGx5LgpQbGVhc2Ugc3BsaXQgdGhpcyBwYXRjaDoKLSBpbXByb3ZlIHNjcmFtYmxl ciBoYW5kbGluZyB0byBmYWNpbGl0YXRlIGJvb3QgcGFnZSBzdXBwb3J0Ci0gYWRkIGJvb3QgcGFn ZXMgc3VwcG9ydAoKPiArCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSV1JJVEUs IHBhZ2UpOwo+ICAJY21kID0gbmZjLT5wYXJhbS5jaGlwX3NlbGVjdCB8IE5GQ19DTURfQ0xFIHwg TkFORF9DTURfUEFHRVBST0c7Cj4gIAl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JF R19DTUQpOwo+ICAJbWVzb25fbmZjX3F1ZXVlX3JiKG5hbmQsIFBTRUNfVE9fTVNFQyhzZHItPnRQ Uk9HX21heCksIGZhbHNlKTsKPiBAQCAtODI5LDE1ICs4NDcsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NS QU1CTElORykgewo+IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29u X25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSUkVBRCwKPiAtCQkJCSAgICAgTkZDX0NNRF9T Q1JBTUJMRVJfRU5BQkxFKTsKPiAtCX0gZWxzZSB7Cj4gLQkJbWVzb25fbmZjX2NtZF9hY2Nlc3Mo bmFuZCwgcmF3LCBESVJSRUFELAo+IC0JCQkJICAgICBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxF KTsKPiAtCX0KPiAtCj4gKwltZXNvbl9uZmNfY21kX2FjY2VzcyhuYW5kLCByYXcsIERJUlJFQUQs IHBhZ2UpOwo+ICAJcmV0ID0gbWVzb25fbmZjX3dhaXRfZG1hX2ZpbmlzaChuZmMpOwo+ICAJbWVz b25fbmZjX2NoZWNrX2VjY19wYWdlc192YWxpZChuZmMsIG5hbmQsIHJhdyk7Cj4gIAo+IEBAIC0x NDM2LDYgKzE0NDYsMjYgQEAgbWVzb25fbmZjX25hbmRfY2hpcF9pbml0KHN0cnVjdCBkZXZpY2Ug KmRldiwKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlpZiAobmFuZC0+b3B0 aW9ucyAmIE5BTkRfSVNfQk9PVF9NRURJVU0pIHsKPiArCQlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFk X3UzMihucCwgImFtbG9naWMsYm9vdC1wYWdlcyIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJv b3RfcGFnZXMpOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2VycihkZXYsICJjb3VsZCBub3Qg cmV0cmlldmUgJ2FtbG9naWMsYm9vdC1wYWdlcycgcHJvcGVydHk6ICVkIiwKPiArCQkJCXJldCk7 Cj4gKwkJCW5hbmRfY2xlYW51cChuYW5kKTsKPiArCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwo+ ICsJCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAiYW1sb2dpYyxib290LXBhZ2Utc3Rl cCIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJvb3RfcGFnZV9zdGVwKTsKPiArCQlpZiAocmV0 KSB7Cj4gKwkJCWRldl9lcnIoZGV2LCAiY291bGQgbm90IHJldHJpZXZlICdhbWxvZ2ljLGJvb3Qt cGFnZS1zdGVwJyBwcm9wZXJ0eTogJWQiLAo+ICsJCQkJcmV0KTsKPiArCQkJbmFuZF9jbGVhbnVw KG5hbmQpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0KPiArCj4gIAlyZXQgPSBtdGRf ZGV2aWNlX3JlZ2lzdGVyKG10ZCwgTlVMTCwgMCk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2Vy cihkZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIgTVREIGRldmljZTogJWRcbiIsIHJldCk7CgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3695DC10F16 for ; Mon, 6 May 2024 13:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TgxR4pobC7q5UTaFziQVroPp38BoBA6/dRgJG1fU36k=; b=wlhnOh5fjoMkpE n8NCtX6rFfy94/ddRM4UVC2h1tshhoUwGh6iESUqHSwIinS1roh1akHiH65u5TXuc4L4btGWBvwhG VlajbEplvM2Z47Z0o6oFhysQz9fjhcSeJZDFrEdMLSZ7V4Zcq0bYoQL/2ipdHD6fXOrgT5BBBHwbB f2QGn6ZI9tclKMelx2qpBCUzkHHtiTqZOkbpPZpK0Qnl6PmQ+M8xYJCARzZ1196fwsLbYADIbDOHe 8U1WlmsBi/0D781xbpkLbVZi+rDVjDdHkQPjphJd0wvH7YNEWMBIcnesTrrxyTh87r7vQUlrITRTK tf1TZ9R2fEG11ta2JJCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymc-00000007Y5A-2lDy; Mon, 06 May 2024 13:53:34 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s3ymZ-00000007Y4F-09Jn; Mon, 06 May 2024 13:53:33 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id CFD9C60002; Mon, 6 May 2024 13:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715003606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rl4J4sIVm+WsZbjOlT+E1mrylIFIWJ8bHbGao9o7iXw=; b=oo8780SlEJkCVOPPXFOPXAqPxufjs+dTIjDui17WFF/ls4iGGmMYvS8ZmJlz0Ph+EhTCmV 9Dmitav+5z38uU64tHCsETTex1QgZnE2ipeEHFHy1cpMaMnQuqDDt//UKA6dS8B01odvtH shs2EgcW1RgDT71l3ESfZnostdVzXOtWK/uSZ1GOEt5wjWudIuWCy8Xe2wUIeZbWzz5q4x RTt5L43U1Bxoobv7ifVBN1iSOXKbgXAYMlLFjNWqhRrrZYKYrs8dHNukALuVTWi0/hwKHN QCg9mcVvrd8QYy8kGZkskUKV7wSveAf/nw85zKkyHHkZYrhf56GUTdDGxUzFJA== Date: Mon, 6 May 2024 15:53:22 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [PATCH v5 2/2] mtd: rawnand: meson: support R/W mode for boot ROM Message-ID: <20240506155322.002346d0@xps-13> In-Reply-To: <20240416085101.740458-3-avkrasnov@salutedevices.com> References: <20240416085101.740458-1-avkrasnov@salutedevices.com> <20240416085101.740458-3-avkrasnov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240506_065331_395315_D7194AC3 X-CRM114-Status: GOOD ( 25.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQXJzZW5peSwKCmF2a3Jhc25vdkBzYWx1dGVkZXZpY2VzLmNvbSB3cm90ZSBvbiBUdWUsIDE2 IEFwciAyMDI0IDExOjUxOjAxICswMzAwOgoKPiBCb290IFJPTSBjb2RlIG9uIE1lc29uIHJlcXVp cmVzIHRoYXQgc29tZSBwYWdlcyBvbiBOQU5EIG11c3QgYmUgd3JpdHRlbgo+IGluIHNwZWNpYWwg bW9kZTogInNob3J0IiBFQ0MgbW9kZSB3aGVyZSBlYWNoIGJsb2NrIGlzIDM4NCBieXRlcyBhbmQK PiBzY3JhbWJsaW5nIG1vZGUgaXMgb24uIFN1Y2ggcGFnZXMgbG9jYXRlZCB3aXRoIHRoZSBzcGVj aWZpZWQgaW50ZXJ2YWwKPiB3aXRoaW4gc3BlY2lmaWVkIG9mZnNldC4gQm90aCBpbnRlcnZhbCBh bmQgb2Zmc2V0IGFyZSBsb2NhdGVkIGluIHRoZQo+IGRldmljZSB0cmVlIGFuZCB1c2VkIGJ5IGRy aXZlciBpZiAnbmFuZC1pcy1ib290LW1lZGl1bScgaXMgc2V0IGZvcgo+IE5BTkQgY2hpcC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBBcnNlbml5IEtyYXNub3YgPGF2a3Jhc25vdkBzYWx1dGVkZXZpY2Vz LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbWVzb25fbmFuZC5jIHwgODggKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNTkgaW5zZXJ0 aW9ucygrKSwgMjkgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25h bmQvcmF3L21lc29uX25hbmQuYyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ IGluZGV4IDAwY2UwZTViYjk3MC4uOWVlMTEyNDNiMjU3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv bXRkL25hbmQvcmF3L21lc29uX25hbmQuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvcmF3L21l c29uX25hbmQuYwo+IEBAIC0zNSw2ICszNSw3IEBACj4gICNkZWZpbmUgTkZDX0NNRF9SQgkJQklU KDIwKQo+ICAjZGVmaW5lIE5GQ19DTURfU0NSQU1CTEVSX0VOQUJMRQlCSVQoMTkpCj4gICNkZWZp bmUgTkZDX0NNRF9TQ1JBTUJMRVJfRElTQUJMRQkwCj4gKyNkZWZpbmUgTkZDX0NNRF9TSE9SVE1P REVfRU5BQkxFCTEKPiAgI2RlZmluZSBORkNfQ01EX1NIT1JUTU9ERV9ESVNBQkxFCTAKPiAgI2Rl ZmluZSBORkNfQ01EX1JCX0lOVAkJQklUKDE0KQo+ICAjZGVmaW5lIE5GQ19DTURfUkJfSU5UX05P X1BJTgkoKDB4YiA8PCAxMCkgfCBCSVQoMTgpIHwgQklUKDE2KSkKPiBAQCAtNzgsNiArNzksOCBA QAo+ICAjZGVmaW5lIERNQV9ESVIoZGlyKQkJKChkaXIpID8gTkZDX0NNRF9OMk0gOiBORkNfQ01E X00yTikKPiAgI2RlZmluZSBETUFfQUREUl9BTElHTgkJOAo+ICAKPiArI2RlZmluZSBORkNfU0hP UlRfTU9ERV9FQ0NfU1oJMzg0Cj4gKwo+ICAjZGVmaW5lIEVDQ19DSEVDS19SRVRVUk5fRkYJKC0x KQo+ICAKPiAgI2RlZmluZSBOQU5EX0NFMAkJKDB4ZSA8PCAxMCkKPiBAQCAtMTI1LDYgKzEyOCw4 IEBAIHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwIHsKPiAgCXUzMiB0d2I7Cj4gIAl1MzIgdGFk bDsKPiAgCXUzMiB0YmVyc19tYXg7Cj4gKwl1MzIgYm9vdF9wYWdlczsKPiArCXUzMiBib290X3Bh Z2Vfc3RlcDsKPiAgCj4gIAl1MzIgYmNoX21vZGU7Cj4gIAl1OCAqZGF0YV9idWY7Cj4gQEAgLTI5 OCwyOCArMzAzLDQ5IEBAIHN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfc2VlZChzdHJ1Y3QgbWVz b25fbmZjICpuZmMsIHUzMiBzZWVkKQo+ICAJICAgICAgIG5mYy0+cmVnX2Jhc2UgKyBORkNfUkVH X0NNRCk7Cj4gIH0KPiAgCj4gLXN0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVj dCBuYW5kX2NoaXAgKm5hbmQsIGludCByYXcsIGJvb2wgZGlyLAo+IC0JCQkJIGludCBzY3JhbWJs ZXIpCj4gK3N0YXRpYyBpbnQgbWVzb25fbmZjX3BhZ2VfaXNfYm9vdChzdHJ1Y3QgbmFuZF9jaGlw ICpuYW5kLCBpbnQgcGFnZSkKCm1lc29uX25mY19pc19ib290X3BhZ2UoKSBpcyBlYXNpZXIgdG8g cmVhZAoKPiArewo+ICsJY29uc3Qgc3RydWN0IG1lc29uX25mY19uYW5kX2NoaXAgKm1lc29uX2No aXAgPSB0b19tZXNvbl9uYW5kKG5hbmQpOwo+ICsKPiArCXJldHVybiAobmFuZC0+b3B0aW9ucyAm IE5BTkRfSVNfQk9PVF9NRURJVU0pICYmCj4gKwkgICAgICAgIShwYWdlICUgbWVzb25fY2hpcC0+ Ym9vdF9wYWdlX3N0ZXApICYmCgpJIHdvdWxkIGRlZGljYXRlIGFsbCB0aGUgc3BhY2UgYmVsb3cg LT5ib290X3BhZ2VzIHRvIHRoZSBib290cm9tLCBubz8KVXNpbmcgc3BhY2UgaW4gYmV0d2VlbiBz b3VuZHMgc2lsbHkuCgo+ICsJICAgICAgIChwYWdlIDwgbWVzb25fY2hpcC0+Ym9vdF9wYWdlcyk7 Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIG1lc29uX25mY19jbWRfYWNjZXNzKHN0cnVjdCBuYW5k X2NoaXAgKm5hbmQsIGJvb2wgcmF3LCBib29sIGRpciwgaW50IHBhZ2UpCj4gIHsKPiArCWNvbnN0 IHN0cnVjdCBtZXNvbl9uZmNfbmFuZF9jaGlwICptZXNvbl9jaGlwID0gdG9fbWVzb25fbmFuZChu YW5kKTsKPiAgCXN0cnVjdCBtdGRfaW5mbyAqbXRkID0gbmFuZF90b19tdGQobmFuZCk7Cj4gIAlz dHJ1Y3QgbWVzb25fbmZjICpuZmMgPSBuYW5kX2dldF9jb250cm9sbGVyX2RhdGEobXRkX3RvX25h bmQobXRkKSk7Cj4gLQlzdHJ1Y3QgbWVzb25fbmZjX25hbmRfY2hpcCAqbWVzb25fY2hpcCA9IHRv X21lc29uX25hbmQobmFuZCk7Cj4gLQl1MzIgYmNoID0gbWVzb25fY2hpcC0+YmNoX21vZGUsIGNt ZDsKPiAgCWludCBsZW4gPSBtdGQtPndyaXRlc2l6ZSwgcGFnZXNpemUsIHBhZ2VzOwo+ICsJaW50 IHNjcmFtYmxlcjsKPiArCXUzMiBjbWQ7Cj4gIAo+IC0JcGFnZXNpemUgPSBuYW5kLT5lY2Muc2l6 ZTsKPiArCWlmIChuYW5kLT5vcHRpb25zICYgTkFORF9ORUVEX1NDUkFNQkxJTkcpCj4gKwkJc2Ny YW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJMRVJfRU5BQkxFOwo+ICsJZWxzZQo+ICsJCXNjcmFtYmxl ciA9IE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEU7CgpUaGF0IGlzIGEgc2VwYXJhdGUgZmVhdHVy ZT8KCj4gIAo+ICAJaWYgKHJhdykgewo+ICAJCWxlbiA9IG10ZC0+d3JpdGVzaXplICsgbXRkLT5v b2JzaXplOwo+ICAJCWNtZCA9IGxlbiB8IHNjcmFtYmxlciB8IERNQV9ESVIoZGlyKTsKPiAtCQl3 cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JFR19DTUQpOwo+IC0JCXJldHVybjsKPiAt CX0KPiArCX0gZWxzZSBpZiAobWVzb25fbmZjX3BhZ2VfaXNfYm9vdChuYW5kLCBwYWdlKSkgewo+ ICsJCXBhZ2VzaXplID0gTkZDX1NIT1JUX01PREVfRUNDX1NaID4+IDM7Cj4gKwkJcGFnZXMgPSBt dGQtPndyaXRlc2l6ZSAvIDUxMjsKPiArCj4gKwkJc2NyYW1ibGVyID0gTkZDX0NNRF9TQ1JBTUJM RVJfRU5BQkxFOwo+ICsJCWNtZCA9IENNRFJXR0VOKERNQV9ESVIoZGlyKSwgc2NyYW1ibGVyLCBO RkNfRUNDX0JDSDhfMUssCj4gKwkJCSAgICAgICBORkNfQ01EX1NIT1JUTU9ERV9FTkFCTEUsIHBh Z2VzaXplLCBwYWdlcyk7Cj4gKwl9IGVsc2Ugewo+ICsJCXBhZ2VzaXplID0gbmFuZC0+ZWNjLnNp emUgPj4gMzsKPiArCQlwYWdlcyA9IGxlbiAvIG5hbmQtPmVjYy5zaXplOwo+ICAKPiAtCXBhZ2Vz ID0gbGVuIC8gbmFuZC0+ZWNjLnNpemU7Cj4gKwkJY21kID0gQ01EUldHRU4oRE1BX0RJUihkaXIp LCBzY3JhbWJsZXIsIG1lc29uX2NoaXAtPmJjaF9tb2RlLAo+ICsJCQkgICAgICAgTkZDX0NNRF9T SE9SVE1PREVfRElTQUJMRSwgcGFnZXNpemUsIHBhZ2VzKTsKPiArCX0KPiAgCj4gLQljbWQgPSBD TURSV0dFTihETUFfRElSKGRpciksIHNjcmFtYmxlciwgYmNoLAo+IC0JCSAgICAgICBORkNfQ01E X1NIT1JUTU9ERV9ESVNBQkxFLCBwYWdlc2l6ZSwgcGFnZXMpOwo+ICsJaWYgKHNjcmFtYmxlciA9 PSBORkNfQ01EX1NDUkFNQkxFUl9FTkFCTEUpCj4gKwkJbWVzb25fbmZjX2NtZF9zZWVkKG5mYywg cGFnZSk7Cj4gIAo+ICAJd3JpdGVsKGNtZCwgbmZjLT5yZWdfYmFzZSArIE5GQ19SRUdfQ01EKTsK PiAgfQo+IEBAIC03NDMsMTUgKzc2OSw3IEBAIHN0YXRpYyBpbnQgbWVzb25fbmZjX3dyaXRlX3Bh Z2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ICAJCXJldHVybiBy ZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NSQU1CTElORykgewo+ IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29uX25mY19jbWRfYWNj ZXNzKG5hbmQsIHJhdywgRElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0VO QUJMRSk7Cj4gLQl9IGVsc2Ugewo+IC0JCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywg RElSV1JJVEUsCj4gLQkJCQkgICAgIE5GQ19DTURfU0NSQU1CTEVSX0RJU0FCTEUpOwo+IC0JfQo+ IC0KCk9rIEkgZ2V0IGl0LCB0aGUgZmVhdHVyZSBhbHJlYWR5IGV4aXN0IGJ1dCBpcyBoYW5kbGVk IGRpZmZlcmVudGx5LgpQbGVhc2Ugc3BsaXQgdGhpcyBwYXRjaDoKLSBpbXByb3ZlIHNjcmFtYmxl ciBoYW5kbGluZyB0byBmYWNpbGl0YXRlIGJvb3QgcGFnZSBzdXBwb3J0Ci0gYWRkIGJvb3QgcGFn ZXMgc3VwcG9ydAoKPiArCW1lc29uX25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSV1JJVEUs IHBhZ2UpOwo+ICAJY21kID0gbmZjLT5wYXJhbS5jaGlwX3NlbGVjdCB8IE5GQ19DTURfQ0xFIHwg TkFORF9DTURfUEFHRVBST0c7Cj4gIAl3cml0ZWwoY21kLCBuZmMtPnJlZ19iYXNlICsgTkZDX1JF R19DTUQpOwo+ICAJbWVzb25fbmZjX3F1ZXVlX3JiKG5hbmQsIFBTRUNfVE9fTVNFQyhzZHItPnRQ Uk9HX21heCksIGZhbHNlKTsKPiBAQCAtODI5LDE1ICs4NDcsNyBAQCBzdGF0aWMgaW50IG1lc29u X25mY19yZWFkX3BhZ2Vfc3ViKHN0cnVjdCBuYW5kX2NoaXAgKm5hbmQsCj4gIAlpZiAocmV0KQo+ ICAJCXJldHVybiByZXQ7Cj4gIAo+IC0JaWYgKG5hbmQtPm9wdGlvbnMgJiBOQU5EX05FRURfU0NS QU1CTElORykgewo+IC0JCW1lc29uX25mY19jbWRfc2VlZChuZmMsIHBhZ2UpOwo+IC0JCW1lc29u X25mY19jbWRfYWNjZXNzKG5hbmQsIHJhdywgRElSUkVBRCwKPiAtCQkJCSAgICAgTkZDX0NNRF9T Q1JBTUJMRVJfRU5BQkxFKTsKPiAtCX0gZWxzZSB7Cj4gLQkJbWVzb25fbmZjX2NtZF9hY2Nlc3Mo bmFuZCwgcmF3LCBESVJSRUFELAo+IC0JCQkJICAgICBORkNfQ01EX1NDUkFNQkxFUl9ESVNBQkxF KTsKPiAtCX0KPiAtCj4gKwltZXNvbl9uZmNfY21kX2FjY2VzcyhuYW5kLCByYXcsIERJUlJFQUQs IHBhZ2UpOwo+ICAJcmV0ID0gbWVzb25fbmZjX3dhaXRfZG1hX2ZpbmlzaChuZmMpOwo+ICAJbWVz b25fbmZjX2NoZWNrX2VjY19wYWdlc192YWxpZChuZmMsIG5hbmQsIHJhdyk7Cj4gIAo+IEBAIC0x NDM2LDYgKzE0NDYsMjYgQEAgbWVzb25fbmZjX25hbmRfY2hpcF9pbml0KHN0cnVjdCBkZXZpY2Ug KmRldiwKPiAgCWlmIChyZXQpCj4gIAkJcmV0dXJuIHJldDsKPiAgCj4gKwlpZiAobmFuZC0+b3B0 aW9ucyAmIE5BTkRfSVNfQk9PVF9NRURJVU0pIHsKPiArCQlyZXQgPSBvZl9wcm9wZXJ0eV9yZWFk X3UzMihucCwgImFtbG9naWMsYm9vdC1wYWdlcyIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJv b3RfcGFnZXMpOwo+ICsJCWlmIChyZXQpIHsKPiArCQkJZGV2X2VycihkZXYsICJjb3VsZCBub3Qg cmV0cmlldmUgJ2FtbG9naWMsYm9vdC1wYWdlcycgcHJvcGVydHk6ICVkIiwKPiArCQkJCXJldCk7 Cj4gKwkJCW5hbmRfY2xlYW51cChuYW5kKTsKPiArCQkJcmV0dXJuIHJldDsKPiArCQl9Cj4gKwo+ ICsJCXJldCA9IG9mX3Byb3BlcnR5X3JlYWRfdTMyKG5wLCAiYW1sb2dpYyxib290LXBhZ2Utc3Rl cCIsCj4gKwkJCQkJICAgJm1lc29uX2NoaXAtPmJvb3RfcGFnZV9zdGVwKTsKPiArCQlpZiAocmV0 KSB7Cj4gKwkJCWRldl9lcnIoZGV2LCAiY291bGQgbm90IHJldHJpZXZlICdhbWxvZ2ljLGJvb3Qt cGFnZS1zdGVwJyBwcm9wZXJ0eTogJWQiLAo+ICsJCQkJcmV0KTsKPiArCQkJbmFuZF9jbGVhbnVw KG5hbmQpOwo+ICsJCQlyZXR1cm4gcmV0Owo+ICsJCX0KPiArCX0KPiArCj4gIAlyZXQgPSBtdGRf ZGV2aWNlX3JlZ2lzdGVyKG10ZCwgTlVMTCwgMCk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2Vy cihkZXYsICJmYWlsZWQgdG8gcmVnaXN0ZXIgTVREIGRldmljZTogJWRcbiIsIHJldCk7CgoKVGhh bmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADB587FBC3; Mon, 6 May 2024 13:53:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715003616; cv=none; b=ncQ8lENaX7MF1ScYi20KmQa//gfXf880Q+2VtEFZp3I9Z0p7/slesIKse2Z0ZiXveXotVzqyWmaf/SECc1tJvR2KjV5CoH/dOJuPJo5FbYa+Q9JNssLLj2hwz7yTELuWH1y+zK+ACPMEnLikhFCd9dAFmiPPMo6qBDj6hQAYibY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715003616; c=relaxed/simple; bh=ZBw308vScpWpI6OOmAtYussqcW3H4nJ0DvHxVE73cic=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bsP11WrkoKYxTSZuklYd+dCNvlubj8jO1JjItW9n/hrEStWcale1nCarOzkUJPz9JSu8MQIBBhtINw8XfaUVBVLJN6CU+dBsX7fRdKfQe4YZ4HbdE14Ocx6GLuwhbWzE99/Xx/XgxiWlOqxKtsoGhbYXIWTmsBKXsXVh/qSXXX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=oo8780Sl; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="oo8780Sl" Received: by mail.gandi.net (Postfix) with ESMTPSA id CFD9C60002; Mon, 6 May 2024 13:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715003606; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rl4J4sIVm+WsZbjOlT+E1mrylIFIWJ8bHbGao9o7iXw=; b=oo8780SlEJkCVOPPXFOPXAqPxufjs+dTIjDui17WFF/ls4iGGmMYvS8ZmJlz0Ph+EhTCmV 9Dmitav+5z38uU64tHCsETTex1QgZnE2ipeEHFHy1cpMaMnQuqDDt//UKA6dS8B01odvtH shs2EgcW1RgDT71l3ESfZnostdVzXOtWK/uSZ1GOEt5wjWudIuWCy8Xe2wUIeZbWzz5q4x RTt5L43U1Bxoobv7ifVBN1iSOXKbgXAYMlLFjNWqhRrrZYKYrs8dHNukALuVTWi0/hwKHN QCg9mcVvrd8QYy8kGZkskUKV7wSveAf/nw85zKkyHHkZYrhf56GUTdDGxUzFJA== Date: Mon, 6 May 2024 15:53:22 +0200 From: Miquel Raynal To: Arseniy Krasnov Cc: Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , , , , , , , Subject: Re: [PATCH v5 2/2] mtd: rawnand: meson: support R/W mode for boot ROM Message-ID: <20240506155322.002346d0@xps-13> In-Reply-To: <20240416085101.740458-3-avkrasnov@salutedevices.com> References: <20240416085101.740458-1-avkrasnov@salutedevices.com> <20240416085101.740458-3-avkrasnov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Arseniy, avkrasnov@salutedevices.com wrote on Tue, 16 Apr 2024 11:51:01 +0300: > Boot ROM code on Meson requires that some pages on NAND must be written > in special mode: "short" ECC mode where each block is 384 bytes and > scrambling mode is on. Such pages located with the specified interval > within specified offset. Both interval and offset are located in the > device tree and used by driver if 'nand-is-boot-medium' is set for > NAND chip. >=20 > Signed-off-by: Arseniy Krasnov > --- > drivers/mtd/nand/raw/meson_nand.c | 88 +++++++++++++++++++++---------- > 1 file changed, 59 insertions(+), 29 deletions(-) >=20 > diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/mes= on_nand.c > index 00ce0e5bb970..9ee11243b257 100644 > --- a/drivers/mtd/nand/raw/meson_nand.c > +++ b/drivers/mtd/nand/raw/meson_nand.c > @@ -35,6 +35,7 @@ > #define NFC_CMD_RB BIT(20) > #define NFC_CMD_SCRAMBLER_ENABLE BIT(19) > #define NFC_CMD_SCRAMBLER_DISABLE 0 > +#define NFC_CMD_SHORTMODE_ENABLE 1 > #define NFC_CMD_SHORTMODE_DISABLE 0 > #define NFC_CMD_RB_INT BIT(14) > #define NFC_CMD_RB_INT_NO_PIN ((0xb << 10) | BIT(18) | BIT(16)) > @@ -78,6 +79,8 @@ > #define DMA_DIR(dir) ((dir) ? NFC_CMD_N2M : NFC_CMD_M2N) > #define DMA_ADDR_ALIGN 8 > =20 > +#define NFC_SHORT_MODE_ECC_SZ 384 > + > #define ECC_CHECK_RETURN_FF (-1) > =20 > #define NAND_CE0 (0xe << 10) > @@ -125,6 +128,8 @@ struct meson_nfc_nand_chip { > u32 twb; > u32 tadl; > u32 tbers_max; > + u32 boot_pages; > + u32 boot_page_step; > =20 > u32 bch_mode; > u8 *data_buf; > @@ -298,28 +303,49 @@ static void meson_nfc_cmd_seed(struct meson_nfc *nf= c, u32 seed) > nfc->reg_base + NFC_REG_CMD); > } > =20 > -static void meson_nfc_cmd_access(struct nand_chip *nand, int raw, bool d= ir, > - int scrambler) > +static int meson_nfc_page_is_boot(struct nand_chip *nand, int page) meson_nfc_is_boot_page() is easier to read > +{ > + const struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > + > + return (nand->options & NAND_IS_BOOT_MEDIUM) && > + !(page % meson_chip->boot_page_step) && I would dedicate all the space below ->boot_pages to the bootrom, no? Using space in between sounds silly. > + (page < meson_chip->boot_pages); > +} > + > +static void meson_nfc_cmd_access(struct nand_chip *nand, bool raw, bool = dir, int page) > { > + const struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > struct mtd_info *mtd =3D nand_to_mtd(nand); > struct meson_nfc *nfc =3D nand_get_controller_data(mtd_to_nand(mtd)); > - struct meson_nfc_nand_chip *meson_chip =3D to_meson_nand(nand); > - u32 bch =3D meson_chip->bch_mode, cmd; > int len =3D mtd->writesize, pagesize, pages; > + int scrambler; > + u32 cmd; > =20 > - pagesize =3D nand->ecc.size; > + if (nand->options & NAND_NEED_SCRAMBLING) > + scrambler =3D NFC_CMD_SCRAMBLER_ENABLE; > + else > + scrambler =3D NFC_CMD_SCRAMBLER_DISABLE; That is a separate feature? > =20 > if (raw) { > len =3D mtd->writesize + mtd->oobsize; > cmd =3D len | scrambler | DMA_DIR(dir); > - writel(cmd, nfc->reg_base + NFC_REG_CMD); > - return; > - } > + } else if (meson_nfc_page_is_boot(nand, page)) { > + pagesize =3D NFC_SHORT_MODE_ECC_SZ >> 3; > + pages =3D mtd->writesize / 512; > + > + scrambler =3D NFC_CMD_SCRAMBLER_ENABLE; > + cmd =3D CMDRWGEN(DMA_DIR(dir), scrambler, NFC_ECC_BCH8_1K, > + NFC_CMD_SHORTMODE_ENABLE, pagesize, pages); > + } else { > + pagesize =3D nand->ecc.size >> 3; > + pages =3D len / nand->ecc.size; > =20 > - pages =3D len / nand->ecc.size; > + cmd =3D CMDRWGEN(DMA_DIR(dir), scrambler, meson_chip->bch_mode, > + NFC_CMD_SHORTMODE_DISABLE, pagesize, pages); > + } > =20 > - cmd =3D CMDRWGEN(DMA_DIR(dir), scrambler, bch, > - NFC_CMD_SHORTMODE_DISABLE, pagesize, pages); > + if (scrambler =3D=3D NFC_CMD_SCRAMBLER_ENABLE) > + meson_nfc_cmd_seed(nfc, page); > =20 > writel(cmd, nfc->reg_base + NFC_REG_CMD); > } > @@ -743,15 +769,7 @@ static int meson_nfc_write_page_sub(struct nand_chip= *nand, > if (ret) > return ret; > =20 > - if (nand->options & NAND_NEED_SCRAMBLING) { > - meson_nfc_cmd_seed(nfc, page); > - meson_nfc_cmd_access(nand, raw, DIRWRITE, > - NFC_CMD_SCRAMBLER_ENABLE); > - } else { > - meson_nfc_cmd_access(nand, raw, DIRWRITE, > - NFC_CMD_SCRAMBLER_DISABLE); > - } > - Ok I get it, the feature already exist but is handled differently. Please split this patch: - improve scrambler handling to facilitate boot page support - add boot pages support > + meson_nfc_cmd_access(nand, raw, DIRWRITE, page); > cmd =3D nfc->param.chip_select | NFC_CMD_CLE | NAND_CMD_PAGEPROG; > writel(cmd, nfc->reg_base + NFC_REG_CMD); > meson_nfc_queue_rb(nand, PSEC_TO_MSEC(sdr->tPROG_max), false); > @@ -829,15 +847,7 @@ static int meson_nfc_read_page_sub(struct nand_chip = *nand, > if (ret) > return ret; > =20 > - if (nand->options & NAND_NEED_SCRAMBLING) { > - meson_nfc_cmd_seed(nfc, page); > - meson_nfc_cmd_access(nand, raw, DIRREAD, > - NFC_CMD_SCRAMBLER_ENABLE); > - } else { > - meson_nfc_cmd_access(nand, raw, DIRREAD, > - NFC_CMD_SCRAMBLER_DISABLE); > - } > - > + meson_nfc_cmd_access(nand, raw, DIRREAD, page); > ret =3D meson_nfc_wait_dma_finish(nfc); > meson_nfc_check_ecc_pages_valid(nfc, nand, raw); > =20 > @@ -1436,6 +1446,26 @@ meson_nfc_nand_chip_init(struct device *dev, > if (ret) > return ret; > =20 > + if (nand->options & NAND_IS_BOOT_MEDIUM) { > + ret =3D of_property_read_u32(np, "amlogic,boot-pages", > + &meson_chip->boot_pages); > + if (ret) { > + dev_err(dev, "could not retrieve 'amlogic,boot-pages' property: %d", > + ret); > + nand_cleanup(nand); > + return ret; > + } > + > + ret =3D of_property_read_u32(np, "amlogic,boot-page-step", > + &meson_chip->boot_page_step); > + if (ret) { > + dev_err(dev, "could not retrieve 'amlogic,boot-page-step' property: %= d", > + ret); > + nand_cleanup(nand); > + return ret; > + } > + } > + > ret =3D mtd_device_register(mtd, NULL, 0); > if (ret) { > dev_err(dev, "failed to register MTD device: %d\n", ret); Thanks, Miqu=C3=A8l