All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [linyunsheng:page_frag_cache_v3_test_0506 8/11] net/rxrpc/conn_object.c:345:35: error: incompatible type for argument 1 of 'page_frag_cache_drain'
Date: Tue, 7 May 2024 05:57:30 +0800	[thread overview]
Message-ID: <202405070500.1HOSOdIZ-lkp@intel.com> (raw)

tree:   https://github.com/gestionlin/linux.git page_frag_cache_v3_test_0506
head:   99acbf369a16aae2fe03c509c811029881a1ea4d
commit: 15e685b00ff333b0a5355b5617391bd9b029d953 [8/11] mm: page_frag: avoid caller accessing 'page_frag_cache' directly
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240507/202405070500.1HOSOdIZ-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240507/202405070500.1HOSOdIZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405070500.1HOSOdIZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/rxrpc/conn_object.c: In function 'rxrpc_clean_up_connection':
>> net/rxrpc/conn_object.c:345:35: error: incompatible type for argument 1 of 'page_frag_cache_drain'
     345 |         page_frag_cache_drain(conn->tx_data_alloc);
         |                               ~~~~^~~~~~~~~~~~~~~
         |                                   |
         |                                   struct page_frag_cache
   In file included from include/linux/skbuff.h:34,
                    from net/rxrpc/conn_object.c:13:
   include/linux/page_frag_cache.h:36:52: note: expected 'struct page_frag_cache *' but argument is of type 'struct page_frag_cache'
      36 | void page_frag_cache_drain(struct page_frag_cache *nc);
         |                            ~~~~~~~~~~~~~~~~~~~~~~~~^~


vim +/page_frag_cache_drain +345 net/rxrpc/conn_object.c

   305	
   306	/*
   307	 * Clean up a dead connection.
   308	 */
   309	static void rxrpc_clean_up_connection(struct work_struct *work)
   310	{
   311		struct rxrpc_connection *conn =
   312			container_of(work, struct rxrpc_connection, destructor);
   313		struct rxrpc_net *rxnet = conn->rxnet;
   314	
   315		ASSERT(!conn->channels[0].call &&
   316		       !conn->channels[1].call &&
   317		       !conn->channels[2].call &&
   318		       !conn->channels[3].call);
   319		ASSERT(list_empty(&conn->cache_link));
   320	
   321		del_timer_sync(&conn->timer);
   322		cancel_work_sync(&conn->processor); /* Processing may restart the timer */
   323		del_timer_sync(&conn->timer);
   324	
   325		write_lock(&rxnet->conn_lock);
   326		list_del_init(&conn->proc_link);
   327		write_unlock(&rxnet->conn_lock);
   328	
   329		rxrpc_purge_queue(&conn->rx_queue);
   330	
   331		rxrpc_kill_client_conn(conn);
   332	
   333		conn->security->clear(conn);
   334		key_put(conn->key);
   335		rxrpc_put_bundle(conn->bundle, rxrpc_bundle_put_conn);
   336		rxrpc_put_peer(conn->peer, rxrpc_peer_put_conn);
   337		rxrpc_put_local(conn->local, rxrpc_local_put_kill_conn);
   338	
   339		/* Drain the Rx queue.  Note that even though we've unpublished, an
   340		 * incoming packet could still be being added to our Rx queue, so we
   341		 * will need to drain it again in the RCU cleanup handler.
   342		 */
   343		rxrpc_purge_queue(&conn->rx_queue);
   344	
 > 345		page_frag_cache_drain(conn->tx_data_alloc);
   346		call_rcu(&conn->rcu, rxrpc_rcu_free_connection);
   347	}
   348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-06 21:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405070500.1HOSOdIZ-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=linyunsheng@huawei.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.