All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Khem Raj <raj.khem@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sched_stress: Use time_t instead of long for type
Date: Tue, 7 May 2024 09:28:20 +0200	[thread overview]
Message-ID: <20240507072820.GA90516@pevik> (raw)
In-Reply-To: <CAMKF1sr_s8qnm3++7gea+UuShkB6KYQOz2t2ooCcbNaBjxv8vA@mail.gmail.com>

> On Mon, May 6, 2024 at 2:00 PM Petr Vorel <pvorel@suse.cz> wrote:

> > Hi Khem,

> > > This ensures it works across different architectures
> > > Fixes

> > > | sched_driver.c:744:43: error: passing argument 1 of 'ctime' from
> > incompatible pointer type [-Wincompatible-pointer-types]
> > > |   744 |         printf("\nend time = %s\n", ctime(&end_time));
> > > |       |                                           ^~~~~~~~~

> > > With gcc-14

> > This was actually problem on musl, right?


> This is with 32 bit x86 using 64bit time_r this time :) we have umpteen
> ways to build systems with yocto

Thanks for info! I wonder if this is the only place where it's needed.

I'm not sure how much is sched_driver.c relevant nowadays. If yes,
it would be worth to at least fix other warnings, remove ia64 support and
#if 0.

Kind regards,
Petr

> > Anyway, thanks for the fix, merged.

> > Kind regards,
> > Petr


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2024-05-07  7:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 19:03 [LTP] [PATCH] sched_stress: Use time_t instead of long for type Khem Raj
2024-05-06 21:00 ` Petr Vorel
2024-05-06 23:15   ` Khem Raj
2024-05-07  7:28     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240507072820.GA90516@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.