Re: [Buildroot] [PATCH 1/1] package/mdadm: fix uclibc and musl build

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/mdadm: fix uclibc and musl build
Date: Tue, 7 May 2024 09:12:40 +0200	[thread overview]
Message-ID: <20240507091240.39efce59@windsurf> (raw)
In-Reply-To: <20240506210348.1285002-1-fontaine.fabrice@gmail.com>

On Mon,  6 May 2024 23:03:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fix following uclibc build failure raised since bump to version 4.3 in
> commit 99e9ff08d0705279532ca0cf3de22ea54660cbdc and
> https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=577fd10486d8d1472a6b559066f344ac30a3a391:
> 
> Create.c: In function 'write_zeroes_fork':
> Create.c:155:35: error: 'FALLOC_FL_ZERO_RANGE' undeclared (first use in this function)
>   155 |                 if (fallocate(fd, FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE,
>       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> as well as the following musl build failure:
> 
> util.c: In function 'get_md_name':
> util.c:1031:29: error: 'NAME_MAX' undeclared (first use in this function); did you mean 'MD_NAME_MAX'?
>  1031 |         static char devname[NAME_MAX];
>       |                             ^~~~~~~~
>       |                             MD_NAME_MAX
> util.c:1031:29: note: each undeclared identifier is reported only once for each function it appears in
> /home/buildroot/instance-0/output-1/host/bin/x86_64-linux-gcc  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -g0  -DNO_LIBUDEV -DSendmail=\""/usr/sbin/sendmail -t"\" -DCONFFILE=\"/etc/mdadm.conf\" -DCONFFILE2=\"/etc/mdadm/mdadm.conf\" -DMAP_DIR=\"/run/mdadm\" -DMAP_FILE=\"map\" -DMDMON_DIR=\"/run/mdadm\" -DFAILED_SLOTS_DIR=\"/run/mdadm/failed-slots\" -DNO_COROSYNC -DNO_DLM    -DUSE_PTHREADS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DBINDIR=\"/sbin\"  -o Monitor.o -c Monitor.c
> /home/buildroot/instance-0/output-1/host/bin/x86_64-linux-gcc  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -g0  -DNO_LIBUDEV -DSendmail=\""/usr/sbin/sendmail -t"\" -DCONFFILE=\"/etc/mdadm.conf\" -DCONFFILE2=\"/etc/mdadm/mdadm.conf\" -DMAP_DIR=\"/run/mdadm\" -DMAP_FILE=\"map\" -DMDMON_DIR=\"/run/mdadm\" -DFAILED_SLOTS_DIR=\"/run/mdadm/failed-slots\" -DNO_COROSYNC -DNO_DLM    -DUSE_PTHREADS -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DBINDIR=\"/sbin\"  -o dlink.o -c dlink.c
> Create.c: In function 'write_zeroes_fork':
> Create.c:155:35: error: 'FALLOC_FL_ZERO_RANGE' undeclared (first use in this function)
>   155 |                 if (fallocate(fd, FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE,
>       |                                   ^~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 99e9ff08d0705279532ca0cf3de22ea54660cbdc
>  - http://autobuild.buildroot.org/results/0e04bcdb591ca5642053e1f7e31384f06581e989
>  - http://autobuild.buildroot.org/results/c77ee2615e9d473e93d95c778648c7e897b7f234
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  ...ts-h-include-for-NAME_MAX-definition.patch | 32 ++++++++++++++
>  .../0003-Create.c-fix-uclibc-build.patch      | 42 +++++++++++++++++++
>  2 files changed, 74 insertions(+)
>  create mode 100644 package/mdadm/0002-util-c-add-limits-h-include-for-NAME_MAX-definition.patch
>  create mode 100644 package/mdadm/0003-Create.c-fix-uclibc-build.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot