From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 322F213C831 for ; Tue, 7 May 2024 08:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715069070; cv=none; b=QX1WfQIiQCck0cKAf23TfxDe6LhGXpIZjaXHlv+Ih8aFxrxHh4f2ggB2QbjBUkNC+eovEji3Qyh9VI+HLn98J/PBzAgLHWBkIFzWMmQ0uknm9or0Bm737o8bDCp1SBjhfZQdHetlplYDqeh0h0Z5eVS+/PYXKv3mH9TM+8T+V2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715069070; c=relaxed/simple; bh=0ykBxAOHnnyFYoBMTLFf57HmlIaOOKJXi3ApXDLq7OI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bX9AZvELaE5DpXa48gcI2mJ6Z0/ED6Eg0VapT5Cpzy7hBd23jWwiJjuiDPVNx6A19Yf8EBJIYlw8RHwYEG0biwNnEN8aUNBKmrf0EgWLpZlDEZYm1WV3ZA+qRoVD3zt0qd0WXJTqGNAAwEutPyqyiiRCtxiexSzx+e1BE4uTn6s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=DBdTuImE; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="DBdTuImE" Received: by mail.gandi.net (Postfix) with ESMTPSA id DDC2060002; Tue, 7 May 2024 08:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715069065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zsjTpPdQhp8xGYXA1tswPY/6gILWdgf1jxKsPkJpD10=; b=DBdTuImErvsqqyGScDzRjFP6Ovas2ZBQNaI3ew3vfdC+96+QHodwGpMNmeBcjkuS8qn+cb M2ELFwQoWEKVoK/tD2bfRNBtlzQiOMDxjAXfxkqAmtgdy0isoav5SA+rA8pAgv6dvTg6pS ijCrywnACX7Nyj2c0DG9hZQPLp965b8+JbK9BzdMyYvTOqeHFdKcWSDY4HjXrS0qAvIP69 maeaj3TuseAdMJtr9YGK0D0+aEUBisgJ++0osrV46VsRW776IqCjrRUXu+untSJgFGL/Y0 j6K0ui2o+/kLLdBQ/EabG0R/CeoLbcWzY64vuZCETVXIbRZL48IhC3StsbUXog== Date: Tue, 7 May 2024 10:04:24 +0200 From: Miquel Raynal To: Frank Li Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] i3c: master: svc: fix invalidate IBI type and miss call client IBI handler Message-ID: <20240507100424.611181f1@xps-13> In-Reply-To: <20240506164009.21375-3-Frank.Li@nxp.com> References: <20240506164009.21375-1-Frank.Li@nxp.com> <20240506164009.21375-3-Frank.Li@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Frank, Frank.Li@nxp.com wrote on Mon, 6 May 2024 12:40:09 -0400: > In an In-Band Interrupt (IBI) handle, the code logic is as follows: >=20 > 1: writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI | SVC_I3C_MCTRL_IBIRESP_AUTO, > master->regs + SVC_I3C_MCTRL); >=20 > 2: ret =3D readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val, > SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); > ... > 3: ibitype =3D SVC_I3C_MSTATUS_IBITYPE(status); > ibiaddr =3D SVC_I3C_MSTATUS_IBIADDR(status); >=20 > SVC_I3C_MSTATUS_IBIWON may be set before step 1. Thus, step 2 will return > immediately, and the I3C controller has not sent out the 9th SCL yet. > Consequently, ibitype and ibiaddr are 0, resulting in an unknown IBI type > occurrence and missing call I3C client driver's IBI handler. >=20 > A typical case is that SVC_I3C_MSTATUS_IBIWON is set when an IBI occurs > during the controller send start frame in svc_i3c_master_xfer(). >=20 > Clear SVC_I3C_MSTATUS_IBIWON before issue SVC_I3C_MCTRL_REQUEST_AUTO_IBI > to fix this issue. >=20 > Cc: stable@vger.kernel.org > Fixes: 5e5e3c92e748 ("i3c: master: svc: fix wrong data return when IBI ha= ppen during start frame") > Signed-off-by: Frank Li > --- >=20 > Notes: > Change from v1 to v2 > - improve comments. >=20 > drivers/i3c/master/svc-i3c-master.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc= -i3c-master.c > index 94e4954509558..032fe032ec433 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -415,6 +415,19 @@ static void svc_i3c_master_ibi_work(struct work_stru= ct *work) > int ret; > =20 > mutex_lock(&master->lock); > + /* > + * IBIWON may be set before SVC_I3C_MCTRL_REQUEST_AUTO_IBI, causing > + * readl_relaxed_poll_timeout() to return immediately. Consequently, > + * ibitype will be 0 since it was last updated only after the 8th SCL > + * cycle, leading to missed client IBI handlers. > + * > + * A typical scenario is when IBIWON occurs and bus arbitration is lost > + * at svc_i3c_master_priv_xfers(). > + * > + * Clear SVC_I3C_MINT_IBIWON before sending SVC_I3C_MCTRL_REQUEST_AUTO_= IBI. > + */ Thanks a lot. Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8765EC10F1A for ; Tue, 7 May 2024 08:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C1z0CW2zX3HoN5ubxvxU1jx8UmLTmuWAFJorsuqJ/24=; b=tjzdOzqHYM/JkY WmXc0labDeOeT8EmitO0ybN/ogAKHgvm5LcXqbTnGNgBFXWYjJOgg8zSG1YiinUmPMnnctGxaDyg1 Nz71sH4vh+n1jFuoE43QKQua+bmeZOmX9cdMmGBo0y4AV8pJIVoWwO7Z1ZhXhXaHcnQSM3dHlVp3f rfzCYZ3WUaHFdhXA6YBI/23uORiTxMI1kQWm1hZXx1PgpvxsGL8b7HFJ2j1QfKe4JO3dvtEmACkxP sdquaXPPy9lvOfesafm6Znb9LUQXI0ojXNyNifSyy7gfbepnlhsVEAFJBBi1GQnAQgKmR/M5BWMAs AP4zOIJCZ6jL+ofQ22vw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4FoN-0000000A4Y0-065r; Tue, 07 May 2024 08:04:31 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4FoK-0000000A4Wz-1z7a for linux-i3c@lists.infradead.org; Tue, 07 May 2024 08:04:30 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id DDC2060002; Tue, 7 May 2024 08:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715069065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zsjTpPdQhp8xGYXA1tswPY/6gILWdgf1jxKsPkJpD10=; b=DBdTuImErvsqqyGScDzRjFP6Ovas2ZBQNaI3ew3vfdC+96+QHodwGpMNmeBcjkuS8qn+cb M2ELFwQoWEKVoK/tD2bfRNBtlzQiOMDxjAXfxkqAmtgdy0isoav5SA+rA8pAgv6dvTg6pS ijCrywnACX7Nyj2c0DG9hZQPLp965b8+JbK9BzdMyYvTOqeHFdKcWSDY4HjXrS0qAvIP69 maeaj3TuseAdMJtr9YGK0D0+aEUBisgJ++0osrV46VsRW776IqCjrRUXu+untSJgFGL/Y0 j6K0ui2o+/kLLdBQ/EabG0R/CeoLbcWzY64vuZCETVXIbRZL48IhC3StsbUXog== Date: Tue, 7 May 2024 10:04:24 +0200 From: Miquel Raynal To: Frank Li Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] i3c: master: svc: fix invalidate IBI type and miss call client IBI handler Message-ID: <20240507100424.611181f1@xps-13> In-Reply-To: <20240506164009.21375-3-Frank.Li@nxp.com> References: <20240506164009.21375-1-Frank.Li@nxp.com> <20240506164009.21375-3-Frank.Li@nxp.com> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240507_010428_821351_1B34261C X-CRM114-Status: GOOD ( 17.24 ) X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=archiver.kernel.org@lists.infradead.org SGkgRnJhbmssCgpGcmFuay5MaUBueHAuY29tIHdyb3RlIG9uIE1vbiwgIDYgTWF5IDIwMjQgMTI6 NDA6MDkgLTA0MDA6Cgo+IEluIGFuIEluLUJhbmQgSW50ZXJydXB0IChJQkkpIGhhbmRsZSwgdGhl IGNvZGUgbG9naWMgaXMgYXMgZm9sbG93czoKPiAKPiAxOiB3cml0ZWwoU1ZDX0kzQ19NQ1RSTF9S RVFVRVNUX0FVVE9fSUJJIHwgU1ZDX0kzQ19NQ1RSTF9JQklSRVNQX0FVVE8sCj4gCSAgbWFzdGVy LT5yZWdzICsgU1ZDX0kzQ19NQ1RSTCk7Cj4gCj4gMjogcmV0ID0gcmVhZGxfcmVsYXhlZF9wb2xs X3RpbWVvdXQobWFzdGVyLT5yZWdzICsgU1ZDX0kzQ19NU1RBVFVTLCB2YWwsCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgU1ZDX0kzQ19NU1RBVFVTX0lCSVdPTih2YWwpLCAw LCAxMDAwKTsKPiAJLi4uCj4gMzogaWJpdHlwZSA9IFNWQ19JM0NfTVNUQVRVU19JQklUWVBFKHN0 YXR1cyk7Cj4gICAgaWJpYWRkciA9IFNWQ19JM0NfTVNUQVRVU19JQklBRERSKHN0YXR1cyk7Cj4g Cj4gU1ZDX0kzQ19NU1RBVFVTX0lCSVdPTiBtYXkgYmUgc2V0IGJlZm9yZSBzdGVwIDEuIFRodXMs IHN0ZXAgMiB3aWxsIHJldHVybgo+IGltbWVkaWF0ZWx5LCBhbmQgdGhlIEkzQyBjb250cm9sbGVy IGhhcyBub3Qgc2VudCBvdXQgdGhlIDl0aCBTQ0wgeWV0Lgo+IENvbnNlcXVlbnRseSwgaWJpdHlw ZSBhbmQgaWJpYWRkciBhcmUgMCwgcmVzdWx0aW5nIGluIGFuIHVua25vd24gSUJJIHR5cGUKPiBv Y2N1cnJlbmNlIGFuZCBtaXNzaW5nIGNhbGwgSTNDIGNsaWVudCBkcml2ZXIncyBJQkkgaGFuZGxl ci4KPiAKPiBBIHR5cGljYWwgY2FzZSBpcyB0aGF0IFNWQ19JM0NfTVNUQVRVU19JQklXT04gaXMg c2V0IHdoZW4gYW4gSUJJIG9jY3Vycwo+IGR1cmluZyB0aGUgY29udHJvbGxlciBzZW5kIHN0YXJ0 IGZyYW1lIGluIHN2Y19pM2NfbWFzdGVyX3hmZXIoKS4KPiAKPiBDbGVhciBTVkNfSTNDX01TVEFU VVNfSUJJV09OIGJlZm9yZSBpc3N1ZSBTVkNfSTNDX01DVFJMX1JFUVVFU1RfQVVUT19JQkkKPiB0 byBmaXggdGhpcyBpc3N1ZS4KPiAKPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+IEZpeGVz OiA1ZTVlM2M5MmU3NDggKCJpM2M6IG1hc3Rlcjogc3ZjOiBmaXggd3JvbmcgZGF0YSByZXR1cm4g d2hlbiBJQkkgaGFwcGVuIGR1cmluZyBzdGFydCBmcmFtZSIpCj4gU2lnbmVkLW9mZi1ieTogRnJh bmsgTGkgPEZyYW5rLkxpQG54cC5jb20+Cj4gLS0tCj4gCj4gTm90ZXM6Cj4gICAgIENoYW5nZSBm cm9tIHYxIHRvIHYyCj4gICAgIC0gaW1wcm92ZSBjb21tZW50cy4KPiAKPiAgZHJpdmVycy9pM2Mv bWFzdGVyL3N2Yy1pM2MtbWFzdGVyLmMgfCAxNiArKysrKysrKysrKysrLS0tCj4gIDEgZmlsZSBj aGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjLWkzYy1tYXN0ZXIuYyBiL2RyaXZlcnMvaTNjL21hc3Rl ci9zdmMtaTNjLW1hc3Rlci5jCj4gaW5kZXggOTRlNDk1NDUwOTU1OC4uMDMyZmUwMzJlYzQzMyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2kzYy9tYXN0ZXIvc3ZjLWkzYy1tYXN0ZXIuYwo+ICsrKyBi L2RyaXZlcnMvaTNjL21hc3Rlci9zdmMtaTNjLW1hc3Rlci5jCj4gQEAgLTQxNSw2ICs0MTUsMTkg QEAgc3RhdGljIHZvaWQgc3ZjX2kzY19tYXN0ZXJfaWJpX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0 ICp3b3JrKQo+ICAJaW50IHJldDsKPiAgCj4gIAltdXRleF9sb2NrKCZtYXN0ZXItPmxvY2spOwo+ ICsJLyoKPiArCSAqIElCSVdPTiBtYXkgYmUgc2V0IGJlZm9yZSBTVkNfSTNDX01DVFJMX1JFUVVF U1RfQVVUT19JQkksIGNhdXNpbmcKPiArCSAqIHJlYWRsX3JlbGF4ZWRfcG9sbF90aW1lb3V0KCkg dG8gcmV0dXJuIGltbWVkaWF0ZWx5LiBDb25zZXF1ZW50bHksCj4gKwkgKiBpYml0eXBlIHdpbGwg YmUgMCBzaW5jZSBpdCB3YXMgbGFzdCB1cGRhdGVkIG9ubHkgYWZ0ZXIgdGhlIDh0aCBTQ0wKPiAr CSAqIGN5Y2xlLCBsZWFkaW5nIHRvIG1pc3NlZCBjbGllbnQgSUJJIGhhbmRsZXJzLgo+ICsJICoK PiArCSAqIEEgdHlwaWNhbCBzY2VuYXJpbyBpcyB3aGVuIElCSVdPTiBvY2N1cnMgYW5kIGJ1cyBh cmJpdHJhdGlvbiBpcyBsb3N0Cj4gKwkgKiBhdCBzdmNfaTNjX21hc3Rlcl9wcml2X3hmZXJzKCku Cj4gKwkgKgo+ICsJICogQ2xlYXIgU1ZDX0kzQ19NSU5UX0lCSVdPTiBiZWZvcmUgc2VuZGluZyBT VkNfSTNDX01DVFJMX1JFUVVFU1RfQVVUT19JQkkuCj4gKwkgKi8KClRoYW5rcyBhIGxvdC4KClJl dmlld2VkLWJ5OiBNaXF1ZWwgUmF5bmFsIDxtaXF1ZWwucmF5bmFsQGJvb3RsaW4uY29tPgoKVGhh bmtzLApNaXF1w6hsCgotLSAKbGludXgtaTNjIG1haWxpbmcgbGlzdApsaW51eC1pM2NAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWkzYwo=