From: Simon Horman <horms@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"jiri@resnulli.us" <jiri@resnulli.us>,
Ping-Ke Shih <pkshih@realtek.com>,
Larry Chiu <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v17 02/13] rtase: Implement the .ndo_open function
Date: Wed, 8 May 2024 09:36:43 +0100 [thread overview]
Message-ID: <20240508083643.GN15955@kernel.org> (raw)
In-Reply-To: <745b2ee9e81f4904920e0e4fe6e4df89@realtek.com>
On Mon, May 06, 2024 at 02:45:11AM +0000, Justin Lai wrote:
...
> > > +
> > > + /* request other interrupts to handle multiqueue */
> > > + for (i = 1; i < tp->int_nums; i++) {
> > > + ivec = &tp->int_vector[i];
> > > + snprintf(ivec->name, sizeof(ivec->name),
> > > + "%s_int%i", tp->dev->name, i);
> >
> > nit: This line could trivially be split into two lines,
> > each less than 80 columns wide.
> >
> I will check if there are other similar issues and make corrections.
Thanks.
FWIIW, checkpatch.pl --max-line-length=80 can be helpful here.
next prev parent reply other threads:[~2024-05-08 8:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-02 9:18 [PATCH net-next v17 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 01/13] rtase: Add pci table supported in this module Justin Lai
2024-05-03 9:33 ` Simon Horman
2024-05-06 11:32 ` Justin Lai
2024-05-08 8:39 ` Simon Horman
2024-05-02 9:18 ` [PATCH net-next v17 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-05-03 8:52 ` Simon Horman
2024-05-03 10:19 ` Justin Lai
2024-05-03 11:03 ` Simon Horman
2024-05-06 2:39 ` Justin Lai
2024-05-06 2:45 ` Justin Lai
2024-05-08 8:36 ` Simon Horman [this message]
2024-05-02 9:18 ` [PATCH net-next v17 03/13] rtase: Implement the rtase_down function Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 05/13] rtase: Implement hardware configuration function Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 07/13] rtase: Implement a function to receive packets Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 08/13] rtase: Implement net_device_ops Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 10/13] rtase: Implement ethtool function Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-05-03 8:35 ` Simon Horman
2024-05-06 2:59 ` Justin Lai
2024-05-07 9:44 ` Justin Lai
2024-05-08 8:40 ` Simon Horman
2024-05-04 13:39 ` kernel test robot
2024-05-04 18:01 ` kernel test robot
2024-05-06 11:39 ` Justin Lai
2024-05-02 9:18 ` [PATCH net-next v17 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
2024-05-02 10:23 ` [PATCH net-next v17 00/13] Add Realtek automotive PCIe driver Simon Horman
2024-05-06 2:55 ` Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508083643.GN15955@kernel.org \
--to=horms@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.