From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 695CA28FF; Wed, 8 May 2024 08:44:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715157866; cv=none; b=b8xCOs874SPc1BG2WNu38nz4XU/cYLuPoK+gkj2AYYmdv0FmzqPEgz6IgaJXPZW4WL8kdCQWGwM7gHZJSFvaHN4LMr5VNbmqAtBP7nGlXkRLwZ/gzVjEH0ZYRc4qnhdihzkvR72HRHyn4fXQP9QMclZc2ICt59Ye6tZLxlcjynM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715157866; c=relaxed/simple; bh=T5zecpj4li0OuIWBMVUt5WCfBkgXJbSbJgxIbR51vqs=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=La1w5TDiLltcmAQE43yxxfhXJPAckEpNr+ViF9hOiTk9gRzmZ78dSc82r9S4EjKtuHWSAX6wrawM7J0uJiKvVlpvPI2+zjKWeNwy/Nhp+nBRB3J3mTMlHBUYq+EZLbu01Lal4drbd9mWhz3WCb/c+jLn+4oq+I9cLKBBmk4rWS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VZ7sK1b83z6K6Kl; Wed, 8 May 2024 16:41:09 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 44CD0140B54; Wed, 8 May 2024 16:44:14 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 8 May 2024 09:44:13 +0100 Date: Wed, 8 May 2024 09:44:11 +0100 From: Jonathan Cameron To: "Rafael J. Wysocki" CC: Thomas Gleixner , Peter Zijlstra , , , , , , , , , Russell King , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Marc Zyngier , Hanjun Guo , "Gavin Shan" , Ingo Molnar , Borislav Petkov , Dave Hansen , , , Subject: Re: [PATCH v9 06/19] ACPI: processor: Move checks and availability of acpi_processor earlier Message-ID: <20240508094411.00001b92@Huawei.com> In-Reply-To: References: <20240430142434.10471-1-Jonathan.Cameron@huawei.com> <20240430142434.10471-7-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) On Tue, 7 May 2024 21:04:26 +0200 "Rafael J. Wysocki" wrote: > On Tue, Apr 30, 2024 at 4:27=E2=80=AFPM Jonathan Cameron > wrote: > > > > Make the per_cpu(processors, cpu) entries available earlier so that > > they are available in arch_register_cpu() as ARM64 will need access > > to the acpi_handle to distinguish between acpi_processor_add() > > and earlier registration attempts (which will fail as _STA cannot > > be checked). > > > > Reorder the remove flow to clear this per_cpu() after > > arch_unregister_cpu() has completed, allowing it to be used in > > there as well. > > > > Note that on x86 for the CPU hotplug case, the pr->id prior to > > acpi_map_cpu() may be invalid. Thus the per_cpu() structures > > must be initialized after that call or after checking the ID > > is valid (not hotplug path). > > > > Signed-off-by: Jonathan Cameron =20 >=20 > Acked-by: Rafael J. Wysocki >=20 > One nit below. Thanks. Given timing, this is looking like 6.11 material. I'll tidy this up and post a v10 in a couple of weeks (so around rc1 time). Maybe we'll pick up some more tags for the ARM specific bits in the meantime. Thanks for all your help! Jonathan >=20 > > --- > > v9: Add back a blank line accidentally removed in code move. > > Fix up error returns so that the new cleanup in processor_add() > > is triggered on detection of the bios bug. > > Combined with the previous 2 patches, should solve the leak > > that Gavin identified. > > --- > > drivers/acpi/acpi_processor.c | 80 +++++++++++++++++++++-------------- > > 1 file changed, 49 insertions(+), 31 deletions(-) > > > > diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processo= r.c > > index 16e36e55a560..4a79b42d649e 100644 > > --- a/drivers/acpi/acpi_processor.c > > +++ b/drivers/acpi/acpi_processor.c > > @@ -183,8 +183,38 @@ static void __init acpi_pcc_cpufreq_init(void) {} > > #endif /* CONFIG_X86 */ > > > > /* Initialization */ > > +static DEFINE_PER_CPU(void *, processor_device_array); > > + > > +static bool acpi_processor_set_per_cpu(struct acpi_processor *pr, > > + struct acpi_device *device) > > +{ > > + BUG_ON(pr->id >=3D nr_cpu_ids); > > + > > + /* > > + * Buggy BIOS check. > > + * ACPI id of processors can be reported wrongly by the BIOS. > > + * Don't trust it blindly > > + */ > > + if (per_cpu(processor_device_array, pr->id) !=3D NULL && > > + per_cpu(processor_device_array, pr->id) !=3D device) { > > + dev_warn(&device->dev, > > + "BIOS reported wrong ACPI id %d for the proces= sor\n", > > + pr->id); > > + return false; > > + } > > + /* > > + * processor_device_array is not cleared on errors to allow bug= gy BIOS > > + * checks. > > + */ > > + per_cpu(processor_device_array, pr->id) =3D device; > > + per_cpu(processors, pr->id) =3D pr; > > + > > + return true; > > +} > > + > > #ifdef CONFIG_ACPI_HOTPLUG_CPU > > -static int acpi_processor_hotadd_init(struct acpi_processor *pr) > > +static int acpi_processor_hotadd_init(struct acpi_processor *pr, > > + struct acpi_device *device) > > { > > int ret; > > > > @@ -198,8 +228,16 @@ static int acpi_processor_hotadd_init(struct acpi_= processor *pr) > > if (ret) > > goto out; > > > > + if (!acpi_processor_set_per_cpu(pr, device)) { > > + ret =3D -EINVAL; > > + acpi_unmap_cpu(pr->id); > > + goto out; > > + } > > + > > ret =3D arch_register_cpu(pr->id); > > if (ret) { > > + /* Leave the processor device array in place to detect = buggy bios */ > > + per_cpu(processors, pr->id) =3D NULL; > > acpi_unmap_cpu(pr->id); > > goto out; > > } > > @@ -217,7 +255,8 @@ static int acpi_processor_hotadd_init(struct acpi_p= rocessor *pr) > > return ret; > > } > > #else > > -static inline int acpi_processor_hotadd_init(struct acpi_processor *pr) > > +static inline int acpi_processor_hotadd_init(struct acpi_processor *pr, > > + struct acpi_device *device) > > { > > return -ENODEV; > > } > > @@ -316,10 +355,13 @@ static int acpi_processor_get_info(struct acpi_de= vice *device) > > * because cpuid <-> apicid mapping is persistent now. > > */ > > if (invalid_logical_cpuid(pr->id) || !cpu_present(pr->id)) { > > - int ret =3D acpi_processor_hotadd_init(pr); > > + int ret =3D acpi_processor_hotadd_init(pr, device); > > > > if (ret) > > return ret; > > + } else { > > + if (!acpi_processor_set_per_cpu(pr, device)) > > + return -EINVAL; > > } =20 >=20 > This looks a bit odd. >=20 > I would make acpi_processor_set_per_cpu() return 0 on success and > -EINVAL on failure and the above would become >=20 > if (invalid_logical_cpuid(pr->id) || !cpu_present(pr->id)) > ret =3D acpi_processor_hotadd_init(pr, device); > else > ret =3D acpi_processor_set_per_cpu(pr, device); >=20 > if (ret) > return ret; >=20 > (and of course ret needs to be defined at the beginning of the function). >=20 > > > > /* > > @@ -365,8 +407,6 @@ static int acpi_processor_get_info(struct acpi_devi= ce *device) > > * (cpu_data(cpu)) values, like CPU feature flags, family, model, etc. > > * Such things have to be put in and set up by the processor driver's = .probe(). > > */ > > -static DEFINE_PER_CPU(void *, processor_device_array); > > - > > static int acpi_processor_add(struct acpi_device *device, > > const struct acpi_device_id *id) > > { > > @@ -395,28 +435,6 @@ static int acpi_processor_add(struct acpi_device *= device, > > if (result) /* Processor is not physically present or unavailab= le */ > > goto err_clear_driver_data; > > > > - BUG_ON(pr->id >=3D nr_cpu_ids); > > - > > - /* > > - * Buggy BIOS check. > > - * ACPI id of processors can be reported wrongly by the BIOS. > > - * Don't trust it blindly > > - */ > > - if (per_cpu(processor_device_array, pr->id) !=3D NULL && > > - per_cpu(processor_device_array, pr->id) !=3D device) { > > - dev_warn(&device->dev, > > - "BIOS reported wrong ACPI id %d for the process= or\n", > > - pr->id); > > - /* Give up, but do not abort the namespace scan. */ > > - goto err_clear_driver_data; > > - } > > - /* > > - * processor_device_array is not cleared on errors to allow bug= gy BIOS > > - * checks. > > - */ > > - per_cpu(processor_device_array, pr->id) =3D device; > > - per_cpu(processors, pr->id) =3D pr; > > - > > dev =3D get_cpu_device(pr->id); > > if (!dev) { > > result =3D -ENODEV; > > @@ -470,10 +488,6 @@ static void acpi_processor_remove(struct acpi_devi= ce *device) > > device_release_driver(pr->dev); > > acpi_unbind_one(pr->dev); > > > > - /* Clean up. */ > > - per_cpu(processor_device_array, pr->id) =3D NULL; > > - per_cpu(processors, pr->id) =3D NULL; > > - > > cpu_maps_update_begin(); > > cpus_write_lock(); > > > > @@ -481,6 +495,10 @@ static void acpi_processor_remove(struct acpi_devi= ce *device) > > arch_unregister_cpu(pr->id); > > acpi_unmap_cpu(pr->id); > > > > + /* Clean up. */ > > + per_cpu(processor_device_array, pr->id) =3D NULL; > > + per_cpu(processors, pr->id) =3D NULL; > > + > > cpus_write_unlock(); > > cpu_maps_update_done(); > > > > -- > > 2.39.2 > > =20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2378C04FFE for ; Wed, 8 May 2024 08:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mxj6QsDOEdgUTeKo/qK+Wn8sjPLdwGH40XC8oMphN+I=; b=OHBA9D2IZ4bSTI jyZmLaf+lxIYDDwOhwhCcmwdQ8EXd2EchYjOXd83okNoHx15tzR1JhrumfXSSxMcfCMqYo0sDWYC4 Oxsx2pupegsFBDQACnAHCkvrfYLYhDaydZJ3Nwmp8IkRxAzLlck+nitAdklETysTCsH/HhKgw3cPi K+nXTI48AWMoDy8O8bu7YuNEaSioIzpwLJIa9Gn7lqcsmmfa6e5HkeE3Y4XYfLYrEnRb4YWg+oIod tW2qPrMfDmVZN1nC6I5ShATNK5mfqH3UWd3zCegPp1lVWCcFCwSlHvabHubxEMIJadSJh1zEU6alo JhezH+UvljcfuyRGw+bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4cuf-0000000Efku-1YSq; Wed, 08 May 2024 08:44:33 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4cuc-0000000Efif-14qH for linux-arm-kernel@lists.infradead.org; Wed, 08 May 2024 08:44:32 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4VZ7sK1b83z6K6Kl; Wed, 8 May 2024 16:41:09 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 44CD0140B54; Wed, 8 May 2024 16:44:14 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 8 May 2024 09:44:13 +0100 Date: Wed, 8 May 2024 09:44:11 +0100 From: Jonathan Cameron To: "Rafael J. Wysocki" CC: Thomas Gleixner , Peter Zijlstra , , , , , , , , , Russell King , Miguel Luis , James Morse , Salil Mehta , Jean-Philippe Brucker , Catalin Marinas , Will Deacon , Marc Zyngier , Hanjun Guo , "Gavin Shan" , Ingo Molnar , Borislav Petkov , Dave Hansen , , , Subject: Re: [PATCH v9 06/19] ACPI: processor: Move checks and availability of acpi_processor earlier Message-ID: <20240508094411.00001b92@Huawei.com> In-Reply-To: References: <20240430142434.10471-1-Jonathan.Cameron@huawei.com> <20240430142434.10471-7-Jonathan.Cameron@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_014430_597523_7F5075F4 X-CRM114-Status: GOOD ( 39.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCA3IE1heSAyMDI0IDIxOjA0OjI2ICswMjAwCiJSYWZhZWwgSi4gV3lzb2NraSIgPHJh ZmFlbEBrZXJuZWwub3JnPiB3cm90ZToKCj4gT24gVHVlLCBBcHIgMzAsIDIwMjQgYXQgNDoyN+KA r1BNIEpvbmF0aGFuIENhbWVyb24KPiA8Sm9uYXRoYW4uQ2FtZXJvbkBodWF3ZWkuY29tPiB3cm90 ZToKPiA+Cj4gPiBNYWtlIHRoZSBwZXJfY3B1KHByb2Nlc3NvcnMsIGNwdSkgZW50cmllcyBhdmFp bGFibGUgZWFybGllciBzbyB0aGF0Cj4gPiB0aGV5IGFyZSBhdmFpbGFibGUgaW4gYXJjaF9yZWdp c3Rlcl9jcHUoKSBhcyBBUk02NCB3aWxsIG5lZWQgYWNjZXNzCj4gPiB0byB0aGUgYWNwaV9oYW5k bGUgdG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiBhY3BpX3Byb2Nlc3Nvcl9hZGQoKQo+ID4gYW5kIGVh cmxpZXIgcmVnaXN0cmF0aW9uIGF0dGVtcHRzICh3aGljaCB3aWxsIGZhaWwgYXMgX1NUQSBjYW5u b3QKPiA+IGJlIGNoZWNrZWQpLgo+ID4KPiA+IFJlb3JkZXIgdGhlIHJlbW92ZSBmbG93IHRvIGNs ZWFyIHRoaXMgcGVyX2NwdSgpIGFmdGVyCj4gPiBhcmNoX3VucmVnaXN0ZXJfY3B1KCkgaGFzIGNv bXBsZXRlZCwgYWxsb3dpbmcgaXQgdG8gYmUgdXNlZCBpbgo+ID4gdGhlcmUgYXMgd2VsbC4KPiA+ Cj4gPiBOb3RlIHRoYXQgb24geDg2IGZvciB0aGUgQ1BVIGhvdHBsdWcgY2FzZSwgdGhlIHByLT5p ZCBwcmlvciB0bwo+ID4gYWNwaV9tYXBfY3B1KCkgbWF5IGJlIGludmFsaWQuIFRodXMgdGhlIHBl cl9jcHUoKSBzdHJ1Y3R1cmVzCj4gPiBtdXN0IGJlIGluaXRpYWxpemVkIGFmdGVyIHRoYXQgY2Fs bCBvciBhZnRlciBjaGVja2luZyB0aGUgSUQKPiA+IGlzIHZhbGlkIChub3QgaG90cGx1ZyBwYXRo KS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBKb25hdGhhbiBDYW1lcm9uIDxKb25hdGhhbi5DYW1l cm9uQGh1YXdlaS5jb20+ICAKPiAKPiBBY2tlZC1ieTogUmFmYWVsIEouIFd5c29ja2kgPHJhZmFl bC5qLnd5c29ja2lAaW50ZWwuY29tPgo+IAo+IE9uZSBuaXQgYmVsb3cuCgpUaGFua3MuICBHaXZl biB0aW1pbmcsIHRoaXMgaXMgbG9va2luZyBsaWtlIDYuMTEgbWF0ZXJpYWwuCkknbGwgdGlkeSB0 aGlzIHVwIGFuZCBwb3N0IGEgdjEwIGluIGEgY291cGxlIG9mIHdlZWtzIChzbyBhcm91bmQKcmMx IHRpbWUpLiBNYXliZSB3ZSdsbCBwaWNrIHVwIHNvbWUgbW9yZSB0YWdzIGZvciB0aGUgQVJNCnNw ZWNpZmljIGJpdHMgaW4gdGhlIG1lYW50aW1lLgoKVGhhbmtzIGZvciBhbGwgeW91ciBoZWxwIQoK Sm9uYXRoYW4KCj4gCj4gPiAtLS0KPiA+IHY5OiBBZGQgYmFjayBhIGJsYW5rIGxpbmUgYWNjaWRl bnRhbGx5IHJlbW92ZWQgaW4gY29kZSBtb3ZlLgo+ID4gICAgIEZpeCB1cCBlcnJvciByZXR1cm5z IHNvIHRoYXQgdGhlIG5ldyBjbGVhbnVwIGluIHByb2Nlc3Nvcl9hZGQoKQo+ID4gICAgIGlzIHRy aWdnZXJlZCBvbiBkZXRlY3Rpb24gb2YgdGhlIGJpb3MgYnVnLgo+ID4gICAgIENvbWJpbmVkIHdp dGggdGhlIHByZXZpb3VzIDIgcGF0Y2hlcywgc2hvdWxkIHNvbHZlIHRoZSBsZWFrCj4gPiAgICAg dGhhdCBHYXZpbiBpZGVudGlmaWVkLgo+ID4gLS0tCj4gPiAgZHJpdmVycy9hY3BpL2FjcGlfcHJv Y2Vzc29yLmMgfCA4MCArKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ID4gIDEg ZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCAzMSBkZWxldGlvbnMoLSkKPiA+Cj4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9hY3BpL2FjcGlfcHJvY2Vzc29yLmMgYi9kcml2ZXJzL2FjcGkv YWNwaV9wcm9jZXNzb3IuYwo+ID4gaW5kZXggMTZlMzZlNTVhNTYwLi40YTc5YjQyZDY0OWUgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2FjcGkvYWNwaV9wcm9jZXNzb3IuYwo+ID4gKysrIGIvZHJp dmVycy9hY3BpL2FjcGlfcHJvY2Vzc29yLmMKPiA+IEBAIC0xODMsOCArMTgzLDM4IEBAIHN0YXRp YyB2b2lkIF9faW5pdCBhY3BpX3BjY19jcHVmcmVxX2luaXQodm9pZCkge30KPiA+ICAjZW5kaWYg LyogQ09ORklHX1g4NiAqLwo+ID4KPiA+ICAvKiBJbml0aWFsaXphdGlvbiAqLwo+ID4gK3N0YXRp YyBERUZJTkVfUEVSX0NQVSh2b2lkICosIHByb2Nlc3Nvcl9kZXZpY2VfYXJyYXkpOwo+ID4gKwo+ ID4gK3N0YXRpYyBib29sIGFjcGlfcHJvY2Vzc29yX3NldF9wZXJfY3B1KHN0cnVjdCBhY3BpX3By b2Nlc3NvciAqcHIsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBz dHJ1Y3QgYWNwaV9kZXZpY2UgKmRldmljZSkKPiA+ICt7Cj4gPiArICAgICAgIEJVR19PTihwci0+ aWQgPj0gbnJfY3B1X2lkcyk7Cj4gPiArCj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIEJ1 Z2d5IEJJT1MgY2hlY2suCj4gPiArICAgICAgICAqIEFDUEkgaWQgb2YgcHJvY2Vzc29ycyBjYW4g YmUgcmVwb3J0ZWQgd3JvbmdseSBieSB0aGUgQklPUy4KPiA+ICsgICAgICAgICogRG9uJ3QgdHJ1 c3QgaXQgYmxpbmRseQo+ID4gKyAgICAgICAgKi8KPiA+ICsgICAgICAgaWYgKHBlcl9jcHUocHJv Y2Vzc29yX2RldmljZV9hcnJheSwgcHItPmlkKSAhPSBOVUxMICYmCj4gPiArICAgICAgICAgICBw ZXJfY3B1KHByb2Nlc3Nvcl9kZXZpY2VfYXJyYXksIHByLT5pZCkgIT0gZGV2aWNlKSB7Cj4gPiAr ICAgICAgICAgICAgICAgZGV2X3dhcm4oJmRldmljZS0+ZGV2LAo+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICJCSU9TIHJlcG9ydGVkIHdyb25nIEFDUEkgaWQgJWQgZm9yIHRoZSBwcm9jZXNz b3JcbiIsCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgcHItPmlkKTsKPiA+ICsgICAgICAg ICAgICAgICByZXR1cm4gZmFsc2U7Cj4gPiArICAgICAgIH0KPiA+ICsgICAgICAgLyoKPiA+ICsg ICAgICAgICogcHJvY2Vzc29yX2RldmljZV9hcnJheSBpcyBub3QgY2xlYXJlZCBvbiBlcnJvcnMg dG8gYWxsb3cgYnVnZ3kgQklPUwo+ID4gKyAgICAgICAgKiBjaGVja3MuCj4gPiArICAgICAgICAq Lwo+ID4gKyAgICAgICBwZXJfY3B1KHByb2Nlc3Nvcl9kZXZpY2VfYXJyYXksIHByLT5pZCkgPSBk ZXZpY2U7Cj4gPiArICAgICAgIHBlcl9jcHUocHJvY2Vzc29ycywgcHItPmlkKSA9IHByOwo+ID4g Kwo+ID4gKyAgICAgICByZXR1cm4gdHJ1ZTsKPiA+ICt9Cj4gPiArCj4gPiAgI2lmZGVmIENPTkZJ R19BQ1BJX0hPVFBMVUdfQ1BVCj4gPiAtc3RhdGljIGludCBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRf aW5pdChzdHJ1Y3QgYWNwaV9wcm9jZXNzb3IgKnByKQo+ID4gK3N0YXRpYyBpbnQgYWNwaV9wcm9j ZXNzb3JfaG90YWRkX2luaXQoc3RydWN0IGFjcGlfcHJvY2Vzc29yICpwciwKPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGFjcGlfZGV2aWNlICpkZXZpY2Up Cj4gPiAgewo+ID4gICAgICAgICBpbnQgcmV0Owo+ID4KPiA+IEBAIC0xOTgsOCArMjI4LDE2IEBA IHN0YXRpYyBpbnQgYWNwaV9wcm9jZXNzb3JfaG90YWRkX2luaXQoc3RydWN0IGFjcGlfcHJvY2Vz c29yICpwcikKPiA+ICAgICAgICAgaWYgKHJldCkKPiA+ICAgICAgICAgICAgICAgICBnb3RvIG91 dDsKPiA+Cj4gPiArICAgICAgIGlmICghYWNwaV9wcm9jZXNzb3Jfc2V0X3Blcl9jcHUocHIsIGRl dmljZSkpIHsKPiA+ICsgICAgICAgICAgICAgICByZXQgPSAtRUlOVkFMOwo+ID4gKyAgICAgICAg ICAgICAgIGFjcGlfdW5tYXBfY3B1KHByLT5pZCk7Cj4gPiArICAgICAgICAgICAgICAgZ290byBv dXQ7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICAgICAgICAgcmV0ID0gYXJjaF9yZWdpc3Rlcl9j cHUocHItPmlkKTsKPiA+ICAgICAgICAgaWYgKHJldCkgewo+ID4gKyAgICAgICAgICAgICAgIC8q IExlYXZlIHRoZSBwcm9jZXNzb3IgZGV2aWNlIGFycmF5IGluIHBsYWNlIHRvIGRldGVjdCBidWdn eSBiaW9zICovCj4gPiArICAgICAgICAgICAgICAgcGVyX2NwdShwcm9jZXNzb3JzLCBwci0+aWQp ID0gTlVMTDsKPiA+ICAgICAgICAgICAgICAgICBhY3BpX3VubWFwX2NwdShwci0+aWQpOwo+ID4g ICAgICAgICAgICAgICAgIGdvdG8gb3V0Owo+ID4gICAgICAgICB9Cj4gPiBAQCAtMjE3LDcgKzI1 NSw4IEBAIHN0YXRpYyBpbnQgYWNwaV9wcm9jZXNzb3JfaG90YWRkX2luaXQoc3RydWN0IGFjcGlf cHJvY2Vzc29yICpwcikKPiA+ICAgICAgICAgcmV0dXJuIHJldDsKPiA+ICB9Cj4gPiAgI2Vsc2UK PiA+IC1zdGF0aWMgaW5saW5lIGludCBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdChzdHJ1Y3Qg YWNwaV9wcm9jZXNzb3IgKnByKQo+ID4gK3N0YXRpYyBpbmxpbmUgaW50IGFjcGlfcHJvY2Vzc29y X2hvdGFkZF9pbml0KHN0cnVjdCBhY3BpX3Byb2Nlc3NvciAqcHIsCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgYWNwaV9kZXZpY2UgKmRldmlj ZSkKPiA+ICB7Cj4gPiAgICAgICAgIHJldHVybiAtRU5PREVWOwo+ID4gIH0KPiA+IEBAIC0zMTYs MTAgKzM1NSwxMyBAQCBzdGF0aWMgaW50IGFjcGlfcHJvY2Vzc29yX2dldF9pbmZvKHN0cnVjdCBh Y3BpX2RldmljZSAqZGV2aWNlKQo+ID4gICAgICAgICAgKiAgYmVjYXVzZSBjcHVpZCA8LT4gYXBp Y2lkIG1hcHBpbmcgaXMgcGVyc2lzdGVudCBub3cuCj4gPiAgICAgICAgICAqLwo+ID4gICAgICAg ICBpZiAoaW52YWxpZF9sb2dpY2FsX2NwdWlkKHByLT5pZCkgfHwgIWNwdV9wcmVzZW50KHByLT5p ZCkpIHsKPiA+IC0gICAgICAgICAgICAgICBpbnQgcmV0ID0gYWNwaV9wcm9jZXNzb3JfaG90YWRk X2luaXQocHIpOwo+ID4gKyAgICAgICAgICAgICAgIGludCByZXQgPSBhY3BpX3Byb2Nlc3Nvcl9o b3RhZGRfaW5pdChwciwgZGV2aWNlKTsKPiA+Cj4gPiAgICAgICAgICAgICAgICAgaWYgKHJldCkK PiA+ICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiArICAgICAgIH0gZWxz ZSB7Cj4gPiArICAgICAgICAgICAgICAgaWYgKCFhY3BpX3Byb2Nlc3Nvcl9zZXRfcGVyX2NwdShw ciwgZGV2aWNlKSkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ ID4gICAgICAgICB9ICAKPiAKPiBUaGlzIGxvb2tzIGEgYml0IG9kZC4KPiAKPiBJIHdvdWxkIG1h a2UgYWNwaV9wcm9jZXNzb3Jfc2V0X3Blcl9jcHUoKSByZXR1cm4gMCBvbiBzdWNjZXNzIGFuZAo+ IC1FSU5WQUwgb24gZmFpbHVyZSBhbmQgdGhlIGFib3ZlIHdvdWxkIGJlY29tZQo+IAo+IGlmIChp bnZhbGlkX2xvZ2ljYWxfY3B1aWQocHItPmlkKSB8fCAhY3B1X3ByZXNlbnQocHItPmlkKSkKPiAg ICAgICAgICByZXQgPSBhY3BpX3Byb2Nlc3Nvcl9ob3RhZGRfaW5pdChwciwgZGV2aWNlKTsKPiBl bHNlCj4gICAgICAgICByZXQgPSBhY3BpX3Byb2Nlc3Nvcl9zZXRfcGVyX2NwdShwciwgZGV2aWNl KTsKPiAKPiBpZiAocmV0KQo+ICAgICAgICAgcmV0dXJuIHJldDsKPiAKPiAoYW5kIG9mIGNvdXJz ZSByZXQgbmVlZHMgdG8gYmUgZGVmaW5lZCBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBmdW5jdGlv bikuCj4gCj4gPgo+ID4gICAgICAgICAvKgo+ID4gQEAgLTM2NSw4ICs0MDcsNiBAQCBzdGF0aWMg aW50IGFjcGlfcHJvY2Vzc29yX2dldF9pbmZvKHN0cnVjdCBhY3BpX2RldmljZSAqZGV2aWNlKQo+ ID4gICAqIChjcHVfZGF0YShjcHUpKSB2YWx1ZXMsIGxpa2UgQ1BVIGZlYXR1cmUgZmxhZ3MsIGZh bWlseSwgbW9kZWwsIGV0Yy4KPiA+ICAgKiBTdWNoIHRoaW5ncyBoYXZlIHRvIGJlIHB1dCBpbiBh bmQgc2V0IHVwIGJ5IHRoZSBwcm9jZXNzb3IgZHJpdmVyJ3MgLnByb2JlKCkuCj4gPiAgICovCj4g PiAtc3RhdGljIERFRklORV9QRVJfQ1BVKHZvaWQgKiwgcHJvY2Vzc29yX2RldmljZV9hcnJheSk7 Cj4gPiAtCj4gPiAgc3RhdGljIGludCBhY3BpX3Byb2Nlc3Nvcl9hZGQoc3RydWN0IGFjcGlfZGV2 aWNlICpkZXZpY2UsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y29uc3Qgc3RydWN0IGFjcGlfZGV2aWNlX2lkICppZCkKPiA+ICB7Cj4gPiBAQCAtMzk1LDI4ICs0 MzUsNiBAQCBzdGF0aWMgaW50IGFjcGlfcHJvY2Vzc29yX2FkZChzdHJ1Y3QgYWNwaV9kZXZpY2Ug KmRldmljZSwKPiA+ICAgICAgICAgaWYgKHJlc3VsdCkgLyogUHJvY2Vzc29yIGlzIG5vdCBwaHlz aWNhbGx5IHByZXNlbnQgb3IgdW5hdmFpbGFibGUgKi8KPiA+ICAgICAgICAgICAgICAgICBnb3Rv IGVycl9jbGVhcl9kcml2ZXJfZGF0YTsKPiA+Cj4gPiAtICAgICAgIEJVR19PTihwci0+aWQgPj0g bnJfY3B1X2lkcyk7Cj4gPiAtCj4gPiAtICAgICAgIC8qCj4gPiAtICAgICAgICAqIEJ1Z2d5IEJJ T1MgY2hlY2suCj4gPiAtICAgICAgICAqIEFDUEkgaWQgb2YgcHJvY2Vzc29ycyBjYW4gYmUgcmVw b3J0ZWQgd3JvbmdseSBieSB0aGUgQklPUy4KPiA+IC0gICAgICAgICogRG9uJ3QgdHJ1c3QgaXQg YmxpbmRseQo+ID4gLSAgICAgICAgKi8KPiA+IC0gICAgICAgaWYgKHBlcl9jcHUocHJvY2Vzc29y X2RldmljZV9hcnJheSwgcHItPmlkKSAhPSBOVUxMICYmCj4gPiAtICAgICAgICAgICBwZXJfY3B1 KHByb2Nlc3Nvcl9kZXZpY2VfYXJyYXksIHByLT5pZCkgIT0gZGV2aWNlKSB7Cj4gPiAtICAgICAg ICAgICAgICAgZGV2X3dhcm4oJmRldmljZS0+ZGV2LAo+ID4gLSAgICAgICAgICAgICAgICAgICAg ICAgIkJJT1MgcmVwb3J0ZWQgd3JvbmcgQUNQSSBpZCAlZCBmb3IgdGhlIHByb2Nlc3NvclxuIiwK PiA+IC0gICAgICAgICAgICAgICAgICAgICAgIHByLT5pZCk7Cj4gPiAtICAgICAgICAgICAgICAg LyogR2l2ZSB1cCwgYnV0IGRvIG5vdCBhYm9ydCB0aGUgbmFtZXNwYWNlIHNjYW4uICovCj4gPiAt ICAgICAgICAgICAgICAgZ290byBlcnJfY2xlYXJfZHJpdmVyX2RhdGE7Cj4gPiAtICAgICAgIH0K PiA+IC0gICAgICAgLyoKPiA+IC0gICAgICAgICogcHJvY2Vzc29yX2RldmljZV9hcnJheSBpcyBu b3QgY2xlYXJlZCBvbiBlcnJvcnMgdG8gYWxsb3cgYnVnZ3kgQklPUwo+ID4gLSAgICAgICAgKiBj aGVja3MuCj4gPiAtICAgICAgICAqLwo+ID4gLSAgICAgICBwZXJfY3B1KHByb2Nlc3Nvcl9kZXZp Y2VfYXJyYXksIHByLT5pZCkgPSBkZXZpY2U7Cj4gPiAtICAgICAgIHBlcl9jcHUocHJvY2Vzc29y cywgcHItPmlkKSA9IHByOwo+ID4gLQo+ID4gICAgICAgICBkZXYgPSBnZXRfY3B1X2RldmljZShw ci0+aWQpOwo+ID4gICAgICAgICBpZiAoIWRldikgewo+ID4gICAgICAgICAgICAgICAgIHJlc3Vs dCA9IC1FTk9ERVY7Cj4gPiBAQCAtNDcwLDEwICs0ODgsNiBAQCBzdGF0aWMgdm9pZCBhY3BpX3By b2Nlc3Nvcl9yZW1vdmUoc3RydWN0IGFjcGlfZGV2aWNlICpkZXZpY2UpCj4gPiAgICAgICAgIGRl dmljZV9yZWxlYXNlX2RyaXZlcihwci0+ZGV2KTsKPiA+ICAgICAgICAgYWNwaV91bmJpbmRfb25l KHByLT5kZXYpOwo+ID4KPiA+IC0gICAgICAgLyogQ2xlYW4gdXAuICovCj4gPiAtICAgICAgIHBl cl9jcHUocHJvY2Vzc29yX2RldmljZV9hcnJheSwgcHItPmlkKSA9IE5VTEw7Cj4gPiAtICAgICAg IHBlcl9jcHUocHJvY2Vzc29ycywgcHItPmlkKSA9IE5VTEw7Cj4gPiAtCj4gPiAgICAgICAgIGNw dV9tYXBzX3VwZGF0ZV9iZWdpbigpOwo+ID4gICAgICAgICBjcHVzX3dyaXRlX2xvY2soKTsKPiA+ Cj4gPiBAQCAtNDgxLDYgKzQ5NSwxMCBAQCBzdGF0aWMgdm9pZCBhY3BpX3Byb2Nlc3Nvcl9yZW1v dmUoc3RydWN0IGFjcGlfZGV2aWNlICpkZXZpY2UpCj4gPiAgICAgICAgIGFyY2hfdW5yZWdpc3Rl cl9jcHUocHItPmlkKTsKPiA+ICAgICAgICAgYWNwaV91bm1hcF9jcHUocHItPmlkKTsKPiA+Cj4g PiArICAgICAgIC8qIENsZWFuIHVwLiAqLwo+ID4gKyAgICAgICBwZXJfY3B1KHByb2Nlc3Nvcl9k ZXZpY2VfYXJyYXksIHByLT5pZCkgPSBOVUxMOwo+ID4gKyAgICAgICBwZXJfY3B1KHByb2Nlc3Nv cnMsIHByLT5pZCkgPSBOVUxMOwo+ID4gKwo+ID4gICAgICAgICBjcHVzX3dyaXRlX3VubG9jaygp Owo+ID4gICAgICAgICBjcHVfbWFwc191cGRhdGVfZG9uZSgpOwo+ID4KPiA+IC0tCj4gPiAyLjM5 LjIKPiA+ICAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==