From: Simon Horman <horms@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Remi Denis-Courmont <courmisch@gmail.com>
Subject: Re: [PATCH v2 net-next] phonet: no longer hold RTNL in route_dumpit()
Date: Wed, 8 May 2024 13:40:46 +0100 [thread overview]
Message-ID: <20240508124046.GD1736038@kernel.org> (raw)
In-Reply-To: <20240507121748.416287-1-edumazet@google.com>
On Tue, May 07, 2024 at 12:17:48PM +0000, Eric Dumazet wrote:
> route_dumpit() already relies on RCU, RTNL is not needed.
>
> Also change return value at the end of a dump.
> This allows NLMSG_DONE to be appended to the current
> skb at the end of a dump, saving a couple of recvmsg()
> system calls.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Remi Denis-Courmont <courmisch@gmail.com>
> ---
> v2: break;; -> break; (Jakub)
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-05-08 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 12:17 [PATCH v2 net-next] phonet: no longer hold RTNL in route_dumpit() Eric Dumazet
2024-05-08 12:40 ` Simon Horman [this message]
2024-05-09 2:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240508124046.GD1736038@kernel.org \
--to=horms@kernel.org \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.