All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI: Make pcie_bandwidth_capable() static
Date: Wed, 8 May 2024 11:21:59 -0500	[thread overview]
Message-ID: <20240508162159.GA1769860@bhelgaas> (raw)
In-Reply-To: <20240507121758.13849-1-ilpo.jarvinen@linux.intel.com>

On Tue, May 07, 2024 at 03:17:58PM +0300, Ilpo Järvinen wrote:
> pcie_bandwidth_capable() is only used within pci.c, make it static.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Applied to pci/misc for v6.10, thanks!

> ---
>  drivers/pci/pci.c | 4 ++--
>  drivers/pci/pci.h | 2 --
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index e5f243dd4288..23fb5d6c25b0 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -6065,8 +6065,8 @@ EXPORT_SYMBOL(pcie_get_width_cap);
>   * and width, multiplying them, and applying encoding overhead.  The result
>   * is in Mb/s, i.e., megabits/second of raw bandwidth.
>   */
> -u32 pcie_bandwidth_capable(struct pci_dev *dev, enum pci_bus_speed *speed,
> -			   enum pcie_link_width *width)
> +static u32 pcie_bandwidth_capable(struct pci_dev *dev, enum pci_bus_speed *speed,
> +				  enum pcie_link_width *width)
>  {
>  	*speed = pcie_get_speed_cap(dev);
>  	*width = pcie_get_width_cap(dev);
> diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h
> index 17fed1846847..fd44565c4756 100644
> --- a/drivers/pci/pci.h
> +++ b/drivers/pci/pci.h
> @@ -293,8 +293,6 @@ void pci_bus_put(struct pci_bus *bus);
>  const char *pci_speed_string(enum pci_bus_speed speed);
>  enum pci_bus_speed pcie_get_speed_cap(struct pci_dev *dev);
>  enum pcie_link_width pcie_get_width_cap(struct pci_dev *dev);
> -u32 pcie_bandwidth_capable(struct pci_dev *dev, enum pci_bus_speed *speed,
> -			   enum pcie_link_width *width);
>  void __pcie_print_link_status(struct pci_dev *dev, bool verbose);
>  void pcie_report_downtraining(struct pci_dev *dev);
>  void pcie_update_link_speed(struct pci_bus *bus, u16 link_status);
> -- 
> 2.39.2
> 

      reply	other threads:[~2024-05-08 16:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-07 12:17 [PATCH 1/1] PCI: Make pcie_bandwidth_capable() static Ilpo Järvinen
2024-05-08 16:21 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240508162159.GA1769860@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.