From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27EA8C04FFE for ; Wed, 8 May 2024 20:17:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=blx7G0yR3BpUKBgsvZxIJPfTNB/LIdR6xC+S6ZS9kQY=; b=Vb1jtwkMrud1juajr7dLz7SHQJ nRnZzhnR/7EOT3j2ZiD6zeMZt+7lG7LZfB1Rr8uYatp+c2anwtiogg940M/DGtqDRHsAlNfbd6HiM w57NFtaDy1KgdZhl1ZlzbiOaKYNAi/cgHMKw19YkLGeZOyub5IJlP0Zn8Uz0QN/LswB1eEYpjb5Yd 8/9iPGkengdc+QjPh+pf+9Av98TrifN+Y8YPGawwSy0BoucZTiUNcT6SwGWevrQyokLxnTNGzwsoZ BDGQz/f37S7z3j8AxTXrMNXnBwboKR1sEtZ5nDqZjI87tlcwCqc3D3o41QOJq/Pjcc+mFw9au9SzX qlMA0PGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4niz-0000000GrRQ-1Htd; Wed, 08 May 2024 20:17:13 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4nit-0000000GrP0-1gtM; Wed, 08 May 2024 20:17:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 56189CE1A66; Wed, 8 May 2024 20:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13308C113CC; Wed, 8 May 2024 20:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715199424; bh=AeePNuL7SFwUOG4gPSg8rwAm8IPCSABF4FYA1EDT90I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OSZyA/tB5lOjpS4LC/9SY0EU+oSR2ADLqzy+2Oxxm/z6SO+lSeYqArptx9zIchIXk UiNicWJF1t0rqW+/75aVsY9qju7Ua4/12VQZiJiUlaEiH4nP7dtm6m8nHPMJVkL/e7 dT4l7ucoWkMp4DEZQmkg02x4F/I3bajuOdqHxt96PxG7vcQGPSxmIVSWWk4UWM2Npy 5j8C7jHMtngGG50t8cy9/OfatYDYYOm8fCYKK5P4uKlv6Q2FcvJcfql94ojXTASiir Unt1u5D51eAHSMTj76PGlYkMWXCG+OJIRRO2EgobbMJJ0WcJKSBDeElVhnooiXnVGX evN2ku1af2CsA== Date: Wed, 8 May 2024 21:16:54 +0100 From: Simon Horman To: Allen Cc: "Russell King (Oracle)" , Allen Pais , netdev@vger.kernel.org, jes@trained-monkey.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kda@linux-powerpc.org, cai.huoqing@linux.dev, dougmill@linux.ibm.com, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, nnac123@linux.ibm.com, tlfalcon@linux.ibm.com, cooldavid@cooldavid.org, marcin.s.wojtas@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, borisp@nvidia.com, bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, louis.peens@corigine.com, richardcochran@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acenic@sunsite.dk, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, oss-drivers@corigine.com, linux-net-drivers@amd.com Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue Message-ID: <20240508201654.GA2248333@kernel.org> References: <20240507190111.16710-1-apais@linux.microsoft.com> <20240507190111.16710-2-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_131707_870968_21411692 X-CRM114-Status: GOOD ( 29.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2024 at 12:27:10PM -0700, Allen wrote: > On Tue, May 7, 2024 at 12:23 PM Russell King (Oracle) > wrote: > > > > On Tue, May 07, 2024 at 07:01:11PM +0000, Allen Pais wrote: > > > The only generic interface to execute asynchronously in the BH context is > > > tasklet; however, it's marked deprecated and has some design flaws. To > > > replace tasklets, BH workqueue support was recently added. A BH workqueue > > > behaves similarly to regular workqueues except that the queued work items > > > are executed in the BH context. > > > > > > This patch converts drivers/ethernet/* from tasklet to BH workqueue. > > > > I doubt you're going to get many comments on this patch, being so large > > and spread across all drivers. I'm not going to bother trying to edit > > this down to something more sensible, I'll just plonk my comment here. > > > > For the mvpp2 driver, you're only updating a comment - and looking at > > it, the comment no longer reflects the code. It doesn't make use of > > tasklets at all. That makes the comment wrong whether or not it's > > updated. So I suggest rather than doing a search and replace for > > "tasklet" to "BH blahblah" (sorry, I don't remember what you replaced > > it with) just get rid of that bit of the comment. > > > > Thank you Russell. > > I will get rid of the comment. If it helps, I can create a patch for each > driver. We did that in the past, with this series, I thought it would be > easier to apply one patch. Hi Allen and Russell, My 2c worth: * In general non bug-fix patches for networking code should be targeted at net-next. This means that they should include net-next in the subject, and be based on that tree. Subject: [PATCH net-next] ... * This series does not appear to apply to net-next * This series appears to depend on code which is not present in net-next. f.e. disable_work_sync * The Infiniband patches should probably be submitted separately to the relevant maintainers * As this patch seems to involve many non-trivial changes it seems to me that it would be best to break it up somehow. To allow proper review. * Patch-sets for net-next should be limited to 15 patches, so perhaps multiple sequential batches would be a way forwards. Link: https://docs.kernel.org/process/maintainer-netdev.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99539C04FFE for ; Wed, 8 May 2024 20:17:58 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OSZyA/tB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VZRKJ5KGDz3cTP for ; Thu, 9 May 2024 06:17:56 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OSZyA/tB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=horms@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VZRJT18QTz3cCn for ; Thu, 9 May 2024 06:17:13 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 56189CE1A66; Wed, 8 May 2024 20:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13308C113CC; Wed, 8 May 2024 20:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715199424; bh=AeePNuL7SFwUOG4gPSg8rwAm8IPCSABF4FYA1EDT90I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OSZyA/tB5lOjpS4LC/9SY0EU+oSR2ADLqzy+2Oxxm/z6SO+lSeYqArptx9zIchIXk UiNicWJF1t0rqW+/75aVsY9qju7Ua4/12VQZiJiUlaEiH4nP7dtm6m8nHPMJVkL/e7 dT4l7ucoWkMp4DEZQmkg02x4F/I3bajuOdqHxt96PxG7vcQGPSxmIVSWWk4UWM2Npy 5j8C7jHMtngGG50t8cy9/OfatYDYYOm8fCYKK5P4uKlv6Q2FcvJcfql94ojXTASiir Unt1u5D51eAHSMTj76PGlYkMWXCG+OJIRRO2EgobbMJJ0WcJKSBDeElVhnooiXnVGX evN2ku1af2CsA== Date: Wed, 8 May 2024 21:16:54 +0100 From: Simon Horman To: Allen Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue Message-ID: <20240508201654.GA2248333@kernel.org> References: <20240507190111.16710-1-apais@linux.microsoft.com> <20240507190111.16710-2-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: marcin.s.wojtas@gmail.com, kda@linux-powerpc.org, edumazet@google.com, linux-acenic@sunsite.dk, louis.peens@corigine.com, angelogioacchino.delregno@collabora.com, borisp@nvidia.com, cooldavid@cooldavid.org, "Russell King \(Oracle\)" , aneesh.kumar@kernel.org, tlfalcon@linux.ibm.com, naveen.n.rao@linux.ibm.com, kuba@kernel.org, pabeni@redhat.com, lorenzo@kernel.org, Mark-MC.Lee@mediatek.com, jes@trained-monkey.org, nnac123@linux.ibm.com, richardcochran@gmail.com, sean.wang@mediatek.com, npiggin@gmail.com, linux-net-drivers@amd.com, cai.huoqing@linux.dev, matthias.bgg@gmail.com, Allen Pais , linux-arm-kernel@lists.infradead.org, mlindner@marvell.com, netdev@vger.kernel.org, oss-drivers@corigine.com, dougmill@linux.ibm.com, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, stephen@networkplumber.org, linux-rdma@vger.kernel.org, bryan.whitehead@microchip.com, linux-mediatek@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net, nbd@nbd.name Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, May 07, 2024 at 12:27:10PM -0700, Allen wrote: > On Tue, May 7, 2024 at 12:23 PM Russell King (Oracle) > wrote: > > > > On Tue, May 07, 2024 at 07:01:11PM +0000, Allen Pais wrote: > > > The only generic interface to execute asynchronously in the BH context is > > > tasklet; however, it's marked deprecated and has some design flaws. To > > > replace tasklets, BH workqueue support was recently added. A BH workqueue > > > behaves similarly to regular workqueues except that the queued work items > > > are executed in the BH context. > > > > > > This patch converts drivers/ethernet/* from tasklet to BH workqueue. > > > > I doubt you're going to get many comments on this patch, being so large > > and spread across all drivers. I'm not going to bother trying to edit > > this down to something more sensible, I'll just plonk my comment here. > > > > For the mvpp2 driver, you're only updating a comment - and looking at > > it, the comment no longer reflects the code. It doesn't make use of > > tasklets at all. That makes the comment wrong whether or not it's > > updated. So I suggest rather than doing a search and replace for > > "tasklet" to "BH blahblah" (sorry, I don't remember what you replaced > > it with) just get rid of that bit of the comment. > > > > Thank you Russell. > > I will get rid of the comment. If it helps, I can create a patch for each > driver. We did that in the past, with this series, I thought it would be > easier to apply one patch. Hi Allen and Russell, My 2c worth: * In general non bug-fix patches for networking code should be targeted at net-next. This means that they should include net-next in the subject, and be based on that tree. Subject: [PATCH net-next] ... * This series does not appear to apply to net-next * This series appears to depend on code which is not present in net-next. f.e. disable_work_sync * The Infiniband patches should probably be submitted separately to the relevant maintainers * As this patch seems to involve many non-trivial changes it seems to me that it would be best to break it up somehow. To allow proper review. * Patch-sets for net-next should be limited to 15 patches, so perhaps multiple sequential batches would be a way forwards. Link: https://docs.kernel.org/process/maintainer-netdev.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C1ABC04FFE for ; Wed, 8 May 2024 20:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yccdevw36xB1WZ4P2W8RoihG9Q/ClynB5SO23s7zLnc=; b=Xkj60WhH+a+obW xMO20hOHBwpBflGk1sSLFjfHru9i98fDzOfsxV+PmSGNc0L0E4inxZ3pNd6/REYEdUiEwi7OQHQp2 HuojkBo+5aPU/1S7+a6kaiDyh0DfXD8wqbP/376hw/yiyyoCpIb427PMyjJkWZ+M2UxHC+2cIO0nA ZXsuY4VixG7/DjA8zqfiF612DYtkn5jRCT+BYIFHq2baO2y+UBW8pFwWCYZTrtiaRkODlawKMGlji PknftMNJKXl97IEJuV7F5FQTfiCml6UIHDZ52JPEHWii5r+zDYPFX3836af+n2D8GqWzqUwlj3FTK fvutol99/WJIKzJ1vBDg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4niw-0000000GrQl-47vE; Wed, 08 May 2024 20:17:10 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s4nit-0000000GrP0-1gtM; Wed, 08 May 2024 20:17:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 56189CE1A66; Wed, 8 May 2024 20:17:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13308C113CC; Wed, 8 May 2024 20:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715199424; bh=AeePNuL7SFwUOG4gPSg8rwAm8IPCSABF4FYA1EDT90I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OSZyA/tB5lOjpS4LC/9SY0EU+oSR2ADLqzy+2Oxxm/z6SO+lSeYqArptx9zIchIXk UiNicWJF1t0rqW+/75aVsY9qju7Ua4/12VQZiJiUlaEiH4nP7dtm6m8nHPMJVkL/e7 dT4l7ucoWkMp4DEZQmkg02x4F/I3bajuOdqHxt96PxG7vcQGPSxmIVSWWk4UWM2Npy 5j8C7jHMtngGG50t8cy9/OfatYDYYOm8fCYKK5P4uKlv6Q2FcvJcfql94ojXTASiir Unt1u5D51eAHSMTj76PGlYkMWXCG+OJIRRO2EgobbMJJ0WcJKSBDeElVhnooiXnVGX evN2ku1af2CsA== Date: Wed, 8 May 2024 21:16:54 +0100 From: Simon Horman To: Allen Cc: "Russell King (Oracle)" , Allen Pais , netdev@vger.kernel.org, jes@trained-monkey.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kda@linux-powerpc.org, cai.huoqing@linux.dev, dougmill@linux.ibm.com, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, nnac123@linux.ibm.com, tlfalcon@linux.ibm.com, cooldavid@cooldavid.org, marcin.s.wojtas@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, borisp@nvidia.com, bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, louis.peens@corigine.com, richardcochran@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acenic@sunsite.dk, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mediatek@lists.infradead.org, oss-drivers@corigine.com, linux-net-drivers@amd.com Subject: Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue Message-ID: <20240508201654.GA2248333@kernel.org> References: <20240507190111.16710-1-apais@linux.microsoft.com> <20240507190111.16710-2-apais@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240508_131707_870968_21411692 X-CRM114-Status: GOOD ( 29.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBNYXkgMDcsIDIwMjQgYXQgMTI6Mjc6MTBQTSAtMDcwMCwgQWxsZW4gd3JvdGU6Cj4g T24gVHVlLCBNYXkgNywgMjAyNCBhdCAxMjoyM+KAr1BNIFJ1c3NlbGwgS2luZyAoT3JhY2xlKQo+ IDxsaW51eEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgo+ID4KPiA+IE9uIFR1ZSwgTWF5IDA3LCAy MDI0IGF0IDA3OjAxOjExUE0gKzAwMDAsIEFsbGVuIFBhaXMgd3JvdGU6Cj4gPiA+IFRoZSBvbmx5 IGdlbmVyaWMgaW50ZXJmYWNlIHRvIGV4ZWN1dGUgYXN5bmNocm9ub3VzbHkgaW4gdGhlIEJIIGNv bnRleHQgaXMKPiA+ID4gdGFza2xldDsgaG93ZXZlciwgaXQncyBtYXJrZWQgZGVwcmVjYXRlZCBh bmQgaGFzIHNvbWUgZGVzaWduIGZsYXdzLiBUbwo+ID4gPiByZXBsYWNlIHRhc2tsZXRzLCBCSCB3 b3JrcXVldWUgc3VwcG9ydCB3YXMgcmVjZW50bHkgYWRkZWQuIEEgQkggd29ya3F1ZXVlCj4gPiA+ IGJlaGF2ZXMgc2ltaWxhcmx5IHRvIHJlZ3VsYXIgd29ya3F1ZXVlcyBleGNlcHQgdGhhdCB0aGUg cXVldWVkIHdvcmsgaXRlbXMKPiA+ID4gYXJlIGV4ZWN1dGVkIGluIHRoZSBCSCBjb250ZXh0Lgo+ ID4gPgo+ID4gPiBUaGlzIHBhdGNoIGNvbnZlcnRzIGRyaXZlcnMvZXRoZXJuZXQvKiBmcm9tIHRh c2tsZXQgdG8gQkggd29ya3F1ZXVlLgo+ID4KPiA+IEkgZG91YnQgeW91J3JlIGdvaW5nIHRvIGdl dCBtYW55IGNvbW1lbnRzIG9uIHRoaXMgcGF0Y2gsIGJlaW5nIHNvIGxhcmdlCj4gPiBhbmQgc3By ZWFkIGFjcm9zcyBhbGwgZHJpdmVycy4gSSdtIG5vdCBnb2luZyB0byBib3RoZXIgdHJ5aW5nIHRv IGVkaXQKPiA+IHRoaXMgZG93biB0byBzb21ldGhpbmcgbW9yZSBzZW5zaWJsZSwgSSdsbCBqdXN0 IHBsb25rIG15IGNvbW1lbnQgaGVyZS4KPiA+Cj4gPiBGb3IgdGhlIG12cHAyIGRyaXZlciwgeW91 J3JlIG9ubHkgdXBkYXRpbmcgYSBjb21tZW50IC0gYW5kIGxvb2tpbmcgYXQKPiA+IGl0LCB0aGUg Y29tbWVudCBubyBsb25nZXIgcmVmbGVjdHMgdGhlIGNvZGUuIEl0IGRvZXNuJ3QgbWFrZSB1c2Ug b2YKPiA+IHRhc2tsZXRzIGF0IGFsbC4gVGhhdCBtYWtlcyB0aGUgY29tbWVudCB3cm9uZyB3aGV0 aGVyIG9yIG5vdCBpdCdzCj4gPiB1cGRhdGVkLiBTbyBJIHN1Z2dlc3QgcmF0aGVyIHRoYW4gZG9p bmcgYSBzZWFyY2ggYW5kIHJlcGxhY2UgZm9yCj4gPiAidGFza2xldCIgdG8gIkJIIGJsYWhibGFo IiAoc29ycnksIEkgZG9uJ3QgcmVtZW1iZXIgd2hhdCB5b3UgcmVwbGFjZWQKPiA+IGl0IHdpdGgp IGp1c3QgZ2V0IHJpZCBvZiB0aGF0IGJpdCBvZiB0aGUgY29tbWVudC4KPiA+Cj4gCj4gIFRoYW5r IHlvdSBSdXNzZWxsLgo+IAo+ICBJIHdpbGwgZ2V0IHJpZCBvZiB0aGUgY29tbWVudC4gSWYgaXQg aGVscHMsIEkgY2FuIGNyZWF0ZSBhIHBhdGNoIGZvciBlYWNoCj4gZHJpdmVyLiBXZSBkaWQgdGhh dCBpbiB0aGUgcGFzdCwgd2l0aCB0aGlzIHNlcmllcywgSSB0aG91Z2h0IGl0IHdvdWxkIGJlCj4g ZWFzaWVyIHRvIGFwcGx5IG9uZSBwYXRjaC4KCkhpIEFsbGVuIGFuZCBSdXNzZWxsLAoKTXkgMmMg d29ydGg6CgoqIEluIGdlbmVyYWwgbm9uIGJ1Zy1maXggcGF0Y2hlcyBmb3IgbmV0d29ya2luZyBj b2RlIHNob3VsZCBiZSB0YXJnZXRlZCBhdAogIG5ldC1uZXh0LiBUaGlzIG1lYW5zIHRoYXQgdGhl eSBzaG91bGQgaW5jbHVkZSBuZXQtbmV4dCBpbiB0aGUgc3ViamVjdCwKICBhbmQgYmUgYmFzZWQg b24gdGhhdCB0cmVlLgoKICBTdWJqZWN0OiBbUEFUQ0ggbmV0LW5leHRdIC4uLgoKKiBUaGlzIHNl cmllcyBkb2VzIG5vdCBhcHBlYXIgdG8gYXBwbHkgdG8gbmV0LW5leHQKCiogVGhpcyBzZXJpZXMg YXBwZWFycyB0byBkZXBlbmQgb24gY29kZSB3aGljaCBpcyBub3QgcHJlc2VudCBpbiBuZXQtbmV4 dC4KICBmLmUuIGRpc2FibGVfd29ya19zeW5jCgoqIFRoZSBJbmZpbmliYW5kIHBhdGNoZXMgc2hv dWxkIHByb2JhYmx5IGJlIHN1Ym1pdHRlZCBzZXBhcmF0ZWx5CiAgdG8gdGhlIHJlbGV2YW50IG1h aW50YWluZXJzCgoqIEFzIHRoaXMgcGF0Y2ggc2VlbXMgdG8gaW52b2x2ZSBtYW55IG5vbi10cml2 aWFsIGNoYW5nZXMKICBpdCBzZWVtcyB0byBtZSB0aGF0IGl0IHdvdWxkIGJlIGJlc3QgdG8gYnJl YWsgaXQgdXAgc29tZWhvdy4KICBUbyBhbGxvdyBwcm9wZXIgcmV2aWV3LgoKKiBQYXRjaC1zZXRz IGZvciBuZXQtbmV4dCBzaG91bGQgYmUgbGltaXRlZCB0byAxNSBwYXRjaGVzLAogIHNvIHBlcmhh cHMgbXVsdGlwbGUgc2VxdWVudGlhbCBiYXRjaGVzIHdvdWxkIGJlIGEgd2F5IGZvcndhcmRzLgoK TGluazogaHR0cHM6Ly9kb2NzLmtlcm5lbC5vcmcvcHJvY2Vzcy9tYWludGFpbmVyLW5ldGRldi5o dG1sCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==