From: Christoph Hellwig <hch@lst.de>
To: Steven Price <steven.price@arm.com>
Cc: Alexander Lobakin <aleksander.lobakin@intel.com>,
Christoph Hellwig <hch@lst.de>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Magnus Karlsson <magnus.karlsson@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/7] dma: avoid redundant calls for sync operations
Date: Thu, 9 May 2024 15:49:24 +0200 [thread overview]
Message-ID: <20240509134924.GA13607@lst.de> (raw)
In-Reply-To: <010686f5-3049-46a1-8230-7752a1b433ff@arm.com>
On Thu, May 09, 2024 at 02:43:52PM +0100, Steven Price wrote:
> The specific drivers are "rockchip-drm" and "rk_gmac-dwmac". Is it a
> requirement that all drivers engaging in DMA should call dma_set_mask()
> - and therefore this has uncovered a bug in those drivers. Or is the
> assumption that all drivers call dma_set_mask() faulty?
That was the assumption behind the code, but the assumption is wrong.
Alex is working on a fix.
next prev parent reply other threads:[~2024-05-09 13:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 11:20 [PATCH v6 0/7] dma: skip calling no-op sync ops when possible Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 1/7] dma: compile-out DMA sync op calls when not used Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 2/7] dma: avoid redundant calls for sync operations Alexander Lobakin
2024-05-09 11:41 ` Marek Szyprowski
2024-05-09 11:44 ` Alexander Lobakin
2024-05-09 11:59 ` Alexander Lobakin
2024-05-09 12:02 ` Christoph Hellwig
2024-05-09 12:01 ` Christoph Hellwig
2024-05-09 13:43 ` Steven Price
2024-05-09 13:49 ` Christoph Hellwig [this message]
2024-05-09 14:33 ` Robin Murphy
2024-05-09 14:43 ` Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 3/7] iommu/dma: avoid expensive indirect " Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 4/7] page_pool: make sure frag API fields don't span between cachelines Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 5/7] page_pool: don't use driver-set flags field directly Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 6/7] page_pool: check for DMA sync shortcut earlier Alexander Lobakin
2024-05-07 11:20 ` [PATCH v6 7/7] xsk: use generic DMA sync shortcut instead of a custom one Alexander Lobakin
2024-05-07 11:30 ` [PATCH v6 0/7] dma: skip calling no-op sync ops when possible Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509134924.GA13607@lst.de \
--to=hch@lst.de \
--cc=aleksander.lobakin@intel.com \
--cc=bpf@vger.kernel.org \
--cc=edumazet@google.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=steven.price@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.