All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: William Tu <witu@nvidia.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH RFC net-next] net: cache the __dev_alloc_name()
Date: Thu, 9 May 2024 14:11:19 +0800	[thread overview]
Message-ID: <202405091354.2Bdd0B0X-lkp@intel.com> (raw)
In-Reply-To: <20240506203207.1307971-1-witu@nvidia.com>

Hi William,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on linus/master v6.9-rc7]
[cannot apply to net-next/main horms-ipvs/master next-20240508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/William-Tu/net-cache-the-__dev_alloc_name/20240507-043305
base:   net/main
patch link:    https://lore.kernel.org/r/20240506203207.1307971-1-witu%40nvidia.com
patch subject: [PATCH RFC net-next] net: cache the __dev_alloc_name()
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20240509/202405091354.2Bdd0B0X-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240509/202405091354.2Bdd0B0X-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405091354.2Bdd0B0X-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> net/core/dev.c:295:13: warning: 'netdev_name_pat_in_use' defined but not used [-Wunused-function]
     295 | static bool netdev_name_pat_in_use(struct net *net, const char *pat) // eth%d
         |             ^~~~~~~~~~~~~~~~~~~~~~
>> net/core/dev.c:277:13: warning: 'netdev_name_pat_node_del' defined but not used [-Wunused-function]
     277 | static void netdev_name_pat_node_del(struct netdev_name_pat_node *pat_node)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~
>> net/core/dev.c:264:13: warning: 'netdev_name_pat_node_free' defined but not used [-Wunused-function]
     264 | static void netdev_name_pat_node_free(struct netdev_name_pat_node *pat_node)
         |             ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/netdev_name_pat_in_use +295 net/core/dev.c

   263	
 > 264	static void netdev_name_pat_node_free(struct netdev_name_pat_node *pat_node)
   265	{
   266		bitmap_free(pat_node->inuse);
   267		kfree(pat_node);
   268	}
   269	
   270	static void netdev_name_pat_node_add(struct net *net,
   271					     struct netdev_name_pat_node *pat_node)
   272	{
   273		hlist_add_head(&pat_node->hlist,
   274			       dev_name_pat_hash(net, pat_node->name_pat));
   275	}
   276	
 > 277	static void netdev_name_pat_node_del(struct netdev_name_pat_node *pat_node)
   278	{
   279		hlist_del_rcu(&pat_node->hlist);
   280	}
   281	
   282	static struct netdev_name_pat_node *
   283	netdev_name_pat_node_lookup(struct net *net, const char *pat)
   284	{
   285		struct hlist_head *head = dev_name_pat_hash(net, pat);
   286		struct netdev_name_pat_node *pat_node;
   287	
   288		hlist_for_each_entry(pat_node, head, hlist) {
   289			if (!strcmp(pat_node->name_pat, pat))
   290				return pat_node;
   291		}
   292		return NULL;
   293	}
   294	
 > 295	static bool netdev_name_pat_in_use(struct net *net, const char *pat) // eth%d
   296	{
   297		return netdev_name_pat_node_lookup(net, pat);
   298	}
   299	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2024-05-09  6:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-06 20:32 [PATCH RFC net-next] net: cache the __dev_alloc_name() William Tu
2024-05-07  7:26 ` Paolo Abeni
2024-05-07 18:55   ` William Tu
2024-05-09  7:46     ` Paolo Abeni
2024-05-09 13:06       ` William Tu
2024-05-08  4:24 ` Stephen Hemminger
2024-05-09  3:27   ` William Tu
2024-05-10 21:30     ` William Tu
2024-05-09  6:11 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405091354.2Bdd0B0X-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=witu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.