From: Martin KaFai Lau <martin.lau@linux.dev>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
kernel-team@meta.com
Subject: [PATCH bpf-next 00/10] selftests/bpf: Retire bpf_tcp_helpers.h
Date: Thu, 9 May 2024 10:50:16 -0700 [thread overview]
Message-ID: <20240509175026.3423614-1-martin.lau@linux.dev> (raw)
From: Martin KaFai Lau <martin.lau@kernel.org>
The earlier commit 8e6d9ae2e09f ("selftests/bpf: Use bpf_tracing.h instead of bpf_tcp_helpers.h")
removed the bpf_tcp_helpers.h usages from the non networking tests.
This patch set is a continuation of this effort to retire
the bpf_tcp_helpers.h from the networking tests (mostly tcp-cc related).
The main usage of the bpf_tcp_helpers.h is the partial kernel
socket definitions (e.g. sock, tcp_sock). New fields are kept adding
back to those partial socket definitions while everything is available
in the vmlinux.h. The recent bpf_cc_cubic.c test tried to extend
bpf_tcp_helpers.c but eventually used the vmlinux.h instead. To avoid
this unnecessary detour for new tests and have one consistent way
of using the kernel sockets, this patch set retires the bpf_tcp_helpers.h
usages and consolidates the tests to use vmlinux.h instead.
Martin KaFai Lau (10):
selftests/bpf: Remove bpf_tracing_net.h usages from two networking
tests
selftests/bpf: Replace the bpf_tcp_helpers.h usage with
bpf_tracing_net.h in some obvious tests
selftests/bpf: Add a few tcp helper functions and macros to
bpf_tracing_net.h
selftests/bpf: Reuse the tcp_sk() from the bpf_tracing_net.h
selftests/bpf: Sanitize the SEC and inline usages in the bpf-tcp-cc
tests
selftests/bpf: Rename tcp-cc private struct in bpf_cubic and bpf_dctcp
selftests/bpf: Use bpf_tracing_net.h in bpf_cubic
selftests/bpf: Use bpf_tracing_net.h in bpf_dctcp
selftests/bpf: Remove bpf_tcp_helpers.h usage in other misc bpf tcp-cc
tests
selftests/bpf: Retire bpf_tcp_helpers.h
tools/testing/selftests/bpf/bpf_tcp_helpers.h | 241 ------------------
.../selftests/bpf/progs/bpf_cc_cubic.c | 39 ++-
tools/testing/selftests/bpf/progs/bpf_cubic.c | 73 +++---
tools/testing/selftests/bpf/progs/bpf_dctcp.c | 62 +++--
.../selftests/bpf/progs/bpf_dctcp_release.c | 10 +-
.../selftests/bpf/progs/bpf_tcp_nogpl.c | 8 +-
.../selftests/bpf/progs/bpf_tracing_net.h | 42 +++
.../selftests/bpf/progs/connect4_prog.c | 21 +-
.../testing/selftests/bpf/progs/fib_lookup.c | 2 +-
.../testing/selftests/bpf/progs/mptcp_sock.c | 4 +-
.../selftests/bpf/progs/sockopt_qos_to_cc.c | 16 +-
.../bpf/progs/tcp_ca_incompl_cong_ops.c | 12 +-
.../selftests/bpf/progs/tcp_ca_kfunc.c | 22 +-
.../bpf/progs/tcp_ca_unsupp_cong_op.c | 2 +-
.../selftests/bpf/progs/tcp_ca_update.c | 18 +-
.../bpf/progs/tcp_ca_write_sk_pacing.c | 20 +-
.../bpf/progs/test_btf_skc_cls_ingress.c | 16 +-
.../selftests/bpf/progs/test_lwt_redirect.c | 2 +-
.../selftests/bpf/progs/test_sock_fields.c | 6 +-
.../selftests/bpf/progs/test_tcpbpf_kern.c | 13 +-
20 files changed, 190 insertions(+), 439 deletions(-)
delete mode 100644 tools/testing/selftests/bpf/bpf_tcp_helpers.h
--
2.43.0
next reply other threads:[~2024-05-09 17:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 17:50 Martin KaFai Lau [this message]
2024-05-09 17:50 ` [PATCH bpf-next 01/10] selftests/bpf: Remove bpf_tracing_net.h usages from two networking tests Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 02/10] selftests/bpf: Add a few tcp helper functions and macros to bpf_tracing_net.h Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 03/10] selftests/bpf: Reuse the tcp_sk() from the bpf_tracing_net.h Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 04/10] selftests/bpf: Sanitize the SEC and inline usages in the bpf-tcp-cc tests Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 05/10] selftests/bpf: Rename tcp-cc private struct in bpf_cubic and bpf_dctcp Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 06/10] selftests/bpf: Use bpf_tracing_net.h in bpf_cubic Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 07/10] selftests/bpf: Use bpf_tracing_net.h in bpf_dctcp Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 08/10] selftests/bpf: Remove bpf_tcp_helpers.h usages from other misc bpf tcp-cc tests Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 09/10] selftests/bpf: Remove the bpf_tcp_helpers.h usages from other non " Martin KaFai Lau
2024-05-09 17:50 ` [PATCH bpf-next 10/10] selftests/bpf: Retire bpf_tcp_helpers.h Martin KaFai Lau
2024-05-09 18:24 ` [PATCH bpf-next 00/10] " Alexei Starovoitov
2024-05-09 18:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509175026.3423614-1-martin.lau@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.