From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>,
Asaf Kahlon <asafka7@gmail.com>,
James Hilliard <james.hilliard1@gmail.com>,
buildroot@buildroot.org, Vincent Fazio <vfazio@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/python-remi: fix pep517 build
Date: Thu, 9 May 2024 18:46:48 +0200 [thread overview]
Message-ID: <20240509184648.5a3719f4@windsurf> (raw)
In-Reply-To: <CAPi7W828vTKG5W6=e9RvFMLC=0gge42GnQTNrr4m4qs2yNGfmQ@mail.gmail.com>
Hello,
Would be good to get some input from Python experts here. James? Vincent?
On Sun, 7 Apr 2024 21:58:45 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> > If the package _does_ build without setuptools_scm, it means that the
> > setup.cfg is wrong. So an upstream patch to fix that would be better..
>
> From my understanding, upstream uses setuptools_scm to retrieve version since
> https://github.com/rawpython/remi/pull/404/commits/f27630721d2bbcfbce515dc2e6be3167f6a06a34
>
> So setuptools_scm is not "strictly" needed.
>
> I used --skip-dependency-check because it is already done in 6 other
> packages since commit 8937db8dd595e0988751e5dbb568e870b07b39cc
But isn't it super crappy to skip the dependency checks? I mean the #1
issue that Buildroot tries to deal with are dependencies of packages.
So if we ask them to then skip their dependency checks, how will we
make sure that all necessary dependencies are installed?
I understand that setuptools_scm may not be strictly needed, but by
passing --skip-dependency-check, don't we also skip checking other
important/mandatory dependencies?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2024-05-09 16:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 11:54 [Buildroot] [PATCH 1/1] package/python-remi: fix pep517 build Fabrice Fontaine
2024-04-07 19:33 ` Arnout Vandecappelle via buildroot
2024-04-07 19:58 ` Fabrice Fontaine
2024-05-09 16:46 ` Thomas Petazzoni via buildroot [this message]
2024-05-09 20:54 ` Arnout Vandecappelle via buildroot
2024-05-09 21:14 ` Thomas Petazzoni via buildroot
2024-05-09 21:28 ` James Hilliard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509184648.5a3719f4@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=fontaine.fabrice@gmail.com \
--cc=gwenhael.goavec-merou@trabucayre.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vfazio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.