From: Jakub Kicinski <kuba@kernel.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: Markus Elfring <Markus.Elfring@web.de>,
Jeroen de Borst <jeroendb@google.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Harshitha Ramamurthy <hramamurthy@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Willem de Bruijn <willemb@google.com>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
John Fraker <jfraker@google.com>, Paolo Abeni <pabeni@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Shailend Chand <shailend@google.com>,
rushilg@google.com
Subject: Re: [PATCH net-next 5/5] gve: Add flow steering ethtool support
Date: Thu, 9 May 2024 20:16:11 -0700 [thread overview]
Message-ID: <20240509201611.053027de@kernel.org> (raw)
In-Reply-To: <CAG-FcCNGsP3FnB6HzrcQxX4kKEHzimYaQnFcBK63z_kFTEQKgw@mail.gmail.com>
On Thu, 9 May 2024 17:19:00 -0700 Ziwei Xiao wrote:
> > How do you think about to increase the application of scope-based resource management
> > at such source code places?
> >
> Is the suggestion to combine dev_hold(netdev) together with
> rtnl_unlock()? If so, I think there might be different usages for
> using rtnl_unlock. For example, some drivers will call rtnl_unlock
> after dev_close(netdev). Please correct me if I'm wrong. Thank you!
We are rather cautious about adoption of the scope-based resource
management in networking. Don't let Markus lead you astray.
next prev parent reply other threads:[~2024-05-10 3:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 22:59 [PATCH net-next 0/5] gve: Add flow steering support Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 1/5] gve: Add adminq mutex lock Ziwei Xiao
2024-05-08 12:07 ` Markus Elfring
2024-05-07 22:59 ` [PATCH net-next 2/5] gve: Add adminq extended command Ziwei Xiao
2024-05-08 12:17 ` Markus Elfring
2024-05-11 14:32 ` Simon Horman
2024-05-07 22:59 ` [PATCH net-next 3/5] gve: Add flow steering device option Ziwei Xiao
2024-05-08 5:32 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-08 5:34 ` [PATCH net-next 2/5] gve: Add adminq extended command David Wei
2024-05-10 0:17 ` Ziwei Xiao
2024-05-07 22:59 ` [PATCH net-next 4/5] gve: Add flow steering adminq commands Ziwei Xiao
2024-05-08 6:24 ` David Wei
2024-05-10 0:18 ` Ziwei Xiao
2024-05-20 17:27 ` David Wei
2024-05-08 13:23 ` Markus Elfring
2024-05-08 14:24 ` kernel test robot
2024-05-07 22:59 ` [PATCH net-next 5/5] gve: Add flow steering ethtool support Ziwei Xiao
2024-05-08 14:09 ` Markus Elfring
2024-05-10 0:19 ` Ziwei Xiao
2024-05-10 3:16 ` Jakub Kicinski [this message]
2024-05-10 6:45 ` Markus Elfring
2024-05-11 14:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509201611.053027de@kernel.org \
--to=kuba@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peterz@infradead.org \
--cc=pkaligineedi@google.com \
--cc=rushilg@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.