From: kernel test robot <lkp@intel.com>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev,
Linus Walleij <linus.walleij@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1 1/1] usb: fotg210: Add missing kernel doc description
Date: Thu, 9 May 2024 22:58:23 +0800 [thread overview]
Message-ID: <202405092220.8mfNBVyo-lkp@intel.com> (raw)
In-Reply-To: <20240508150335.1378629-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
kernel test robot noticed the following build warnings:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on usb/usb-next usb/usb-linus westeri-thunderbolt/next linus/master v6.9-rc7 next-20240509]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/usb-fotg210-Add-missing-kernel-doc-description/20240508-230440
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20240508150335.1378629-1-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/1] usb: fotg210: Add missing kernel doc description
config: arc-randconfig-001-20240509 (https://download.01.org/0day-ci/archive/20240509/202405092220.8mfNBVyo-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240509/202405092220.8mfNBVyo-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405092220.8mfNBVyo-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/usb/fotg210/fotg210-core.c:102: warning: Function parameter or struct member 'fotg' not described in 'fotg210_vbus'
>> drivers/usb/fotg210/fotg210-core.c:102: warning: Excess function parameter 'fotg210' description in 'fotg210_vbus'
vim +102 drivers/usb/fotg210/fotg210-core.c
00fb05ff87bc63 Linus Walleij 2022-11-09 95
3e679bde529e89 Linus Walleij 2023-01-18 96 /**
3e679bde529e89 Linus Walleij 2023-01-18 97 * fotg210_vbus() - Called by gadget driver to enable/disable VBUS
16544cb7676b90 Andy Shevchenko 2024-05-08 98 * @fotg210: pointer to a private fotg210 object
3e679bde529e89 Linus Walleij 2023-01-18 99 * @enable: true to enable VBUS, false to disable VBUS
3e679bde529e89 Linus Walleij 2023-01-18 100 */
3e679bde529e89 Linus Walleij 2023-01-18 101 void fotg210_vbus(struct fotg210 *fotg, bool enable)
3e679bde529e89 Linus Walleij 2023-01-18 @102 {
3e679bde529e89 Linus Walleij 2023-01-18 103 u32 mask;
3e679bde529e89 Linus Walleij 2023-01-18 104 u32 val;
3e679bde529e89 Linus Walleij 2023-01-18 105 int ret;
3e679bde529e89 Linus Walleij 2023-01-18 106
3e679bde529e89 Linus Walleij 2023-01-18 107 switch (fotg->port) {
3e679bde529e89 Linus Walleij 2023-01-18 108 case GEMINI_PORT_0:
3e679bde529e89 Linus Walleij 2023-01-18 109 mask = GEMINI_MISC_USB0_VBUS_ON;
3e679bde529e89 Linus Walleij 2023-01-18 110 val = enable ? GEMINI_MISC_USB0_VBUS_ON : 0;
3e679bde529e89 Linus Walleij 2023-01-18 111 break;
3e679bde529e89 Linus Walleij 2023-01-18 112 case GEMINI_PORT_1:
3e679bde529e89 Linus Walleij 2023-01-18 113 mask = GEMINI_MISC_USB1_VBUS_ON;
3e679bde529e89 Linus Walleij 2023-01-18 114 val = enable ? GEMINI_MISC_USB1_VBUS_ON : 0;
3e679bde529e89 Linus Walleij 2023-01-18 115 break;
3e679bde529e89 Linus Walleij 2023-01-18 116 default:
3e679bde529e89 Linus Walleij 2023-01-18 117 return;
3e679bde529e89 Linus Walleij 2023-01-18 118 }
3e679bde529e89 Linus Walleij 2023-01-18 119 ret = regmap_update_bits(fotg->map, GEMINI_GLOBAL_MISC_CTRL, mask, val);
3e679bde529e89 Linus Walleij 2023-01-18 120 if (ret)
3e679bde529e89 Linus Walleij 2023-01-18 121 dev_err(fotg->dev, "failed to %s VBUS\n",
3e679bde529e89 Linus Walleij 2023-01-18 122 enable ? "enable" : "disable");
3e679bde529e89 Linus Walleij 2023-01-18 123 dev_info(fotg->dev, "%s: %s VBUS\n", __func__, enable ? "enable" : "disable");
3e679bde529e89 Linus Walleij 2023-01-18 124 }
3e679bde529e89 Linus Walleij 2023-01-18 125
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-05-09 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 15:03 [PATCH v1 1/1] usb: fotg210: Add missing kernel doc description Andy Shevchenko
2024-05-09 14:58 ` kernel test robot [this message]
2024-05-10 9:34 ` Greg Kroah-Hartman
2024-05-10 14:23 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202405092220.8mfNBVyo-lkp@intel.com \
--to=lkp@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.