From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh2-smtp.messagingengine.com (fhigh2-smtp.messagingengine.com [103.168.172.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CA5310A0D; Thu, 9 May 2024 22:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.153 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715294119; cv=none; b=rTqmxSg8RKKGWR6OruaL3eAb6RK0UeiXoj96awjovsBQKlvUvpENgRmea88R8d2JEPuO6eIRVdvs71JP3/IQd19AzpXXJ7jojZKyL0X4lEvMAr8CI/sauJyK0raD7RXuvjOXYCBMAoySiQG1ZbQakN+FRYP1cWhMnsbC4x7Vtzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715294119; c=relaxed/simple; bh=69VksyzYvuZo27GogmUOM05ZPGjnE5eMOdwwUd9qG5U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ogD3hWVknH+ce9+4RoxzLWliXDckDBsleyzpHp6aVn4HSKe7TB+HwkIGMFfTBjxcnnjAp8YZG1x+LMcApoZ0aUjSC7ryRIkaXJvnGElxDudIYRpNgV94YWIzFqmx7ExsklXwX0hyELTTT7QATogPyoi6TC77/ktM17WO1d9xLsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se; spf=pass smtp.mailfrom=ragnatech.se; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b=mfopLlbs; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=NFA+78Ha; arc=none smtp.client-ip=103.168.172.153 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ragnatech.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ragnatech.se header.i=@ragnatech.se header.b="mfopLlbs"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="NFA+78Ha" Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 6279311400CD; Thu, 9 May 2024 18:35:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 09 May 2024 18:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715294116; x=1715380516; bh=WBfwUQqqf/P+fzPqGDhmMNrHhyhweyvpE0bfa2ZNWPA=; b= mfopLlbsoipBLqafD8sUZ7U4O0o1C2W38AHxsZDuUS2s1XLD1pdAHwLdrmT2Djco ZKGqhwNNmBV9JP7KGWQ8t1QCFlwEF9cj5uZjcpKQ0m46G+iLMan+ZHyJWVIiEfG3 QFaZcnOfvB/pdfk2H96ZfI1/aON39+g6P7f31H0YTLGBj8xHtuz1rMR2uXPySnrJ UjZMMvp7RvE9eB8fOgn5VFqYYUBJgQNa4FjnJ2goFD+r1ho/NAZtcewCt9KoZUoT 2nWDLKcwAFc0WH9bJZwB0XXD983hN8tceJwOza49kPvtpuUWRql4jrH8p9rhFKLx 2yD69fP2/15GtaSR1YgXOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715294116; x= 1715380516; bh=WBfwUQqqf/P+fzPqGDhmMNrHhyhweyvpE0bfa2ZNWPA=; b=N FA+78Ha4TyvLkvdJ8IzXO9S5F2qFZrsZ5AFdVg9V64xDoCLDVIHdFKpYoxIRqqkK 0jZwkgQar+E6gz7HNRr+NBKXnLCo6h9TqwBuq6fpVUnO5gwPk6cCl3+Tb8uSzPDq HKQ3WPgePkWoRfJuyWRV5QhnC+XlgNyznPBrp7EF1LMbypBJIvOdZtzP2xTmsF2x ms/oug17Giezygqn2KofbeBQJpcsjL13C8LhinJW+w5CKMuXawOjgoHUNyk7l+dO RtSsv6MYlE8nfiUJVTsLmFJuJCfeHBrDlMXeeFNpsiCHIk1u2VFvFROBfOqhJ7HM 7FPq47DYVkIhqTgwubOAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdeffedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefpihhk lhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnugdorhgvnh gvshgrshesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpeefhfellefh ffejgfefudfggeejlefhveehieekhfeulefgtdefueehffdtvdelieenucevlhhushhtvg hrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggv rhhluhhnugdorhgvnhgvshgrshesrhgrghhnrghtvggthhdrshgv X-ME-Proxy: Feedback-ID: i80c9496c:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 May 2024 18:35:15 -0400 (EDT) Date: Fri, 10 May 2024 00:35:14 +0200 From: Niklas =?utf-8?Q?S=C3=B6derlund?= To: Jacopo Mondi Cc: Laurent Pinchart , Sakari Ailus , Kieran Bingham , Tomi Valkeinen , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Laurent Pinchart Subject: Re: [PATCH v3 02/11] media: rcar-csi2: Disable runtime_pm in probe error Message-ID: <20240509223514.GP1385281@ragnatech.se> References: <20240509161403.111789-1-jacopo.mondi@ideasonboard.com> <20240509161403.111789-3-jacopo.mondi@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-renesas-soc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240509161403.111789-3-jacopo.mondi@ideasonboard.com> Hi Jacopo, Thanks for your patch. On 2024-05-09 18:13:52 +0200, Jacopo Mondi wrote: > Disable pm_runtime in the probe() function error path. > > Fixes: 769afd212b16 ("media: rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver") > Signed-off-by: Jacopo Mondi > Reviewed-by: Laurent Pinchart Reviewed-by: Niklas Söderlund > --- > drivers/media/platform/renesas/rcar-csi2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c > index 582d5e35db0e..249e58c77176 100644 > --- a/drivers/media/platform/renesas/rcar-csi2.c > +++ b/drivers/media/platform/renesas/rcar-csi2.c > @@ -1914,12 +1914,14 @@ static int rcsi2_probe(struct platform_device *pdev) > > ret = v4l2_async_register_subdev(&priv->subdev); > if (ret < 0) > - goto error_async; > + goto error_pm_runtime; > > dev_info(priv->dev, "%d lanes found\n", priv->lanes); > > return 0; > > +error_pm_runtime: > + pm_runtime_disable(&pdev->dev); > error_async: > v4l2_async_nf_unregister(&priv->notifier); > v4l2_async_nf_cleanup(&priv->notifier); > -- > 2.44.0 > -- Kind Regards, Niklas Söderlund