From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: yegorslists--- via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/libxmlb: new package
Date: Thu, 9 May 2024 23:05:18 +0200 [thread overview]
Message-ID: <20240509230518.67b8e9b0@windsurf> (raw)
In-Reply-To: <20240424122240.136386-1-yegorslists@googlemail.com>
Hello Yegor,
On Wed, 24 Apr 2024 14:22:40 +0200
yegorslists--- via buildroot <buildroot@buildroot.org> wrote:
> From: Yegor Yefremov <yegorslists@googlemail.com>
>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
I've applied, after fixing two things, one small, one more important.
> diff --git a/package/libxmlb/Config.in b/package/libxmlb/Config.in
> new file mode 100644
> index 0000000000..702cc3d6f2
> --- /dev/null
> +++ b/package/libxmlb/Config.in
> @@ -0,0 +1,18 @@
> +config BR2_PACKAGE_LIBXMLB
> + bool "libxmlb"
> + depends on !BR2_STATIC_LIBS # glib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # glib2
> + depends on BR2_USE_MMU # glib2
> + depends on BR2_USE_WCHAR # glib2
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_LIBSOUP
You select BR2_PACKAGE_LIBSOUP here, but you have no dependency on
libsoup in the .mk file, I don't see any traces of libsoup being used
in the libxmlb code base, and it builds just fine with only libglib2 as
a dependency, so I dropped this (apparently bogus?) select of
BR2_PACKAGE_LIBSOUP.
> diff --git a/package/libxmlb/libxmlb.hash b/package/libxmlb/libxmlb.hash
> new file mode 100644
> index 0000000000..6f364d1e04
> --- /dev/null
> +++ b/package/libxmlb/libxmlb.hash
> @@ -0,0 +1,4 @@
> +# Locally computed:
> +sha256 7050a3e43c4e1f53020cfbdfcb6fd5dc664c6c240faceb5ae3c8830423918262 libxmlb-0.3.19.tar.gz
> +sha256 20c17d8b8c48a600800dfd14f95d5cb9ff47066a9641ddeab48dc54aec96e331 LICENSE
> +
This extra line in the hash file caused a check-package warning, so I dropped it.
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-05-09 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 12:22 [Buildroot] [PATCH] package/libxmlb: new package yegorslists--- via buildroot
2024-05-09 21:05 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240509230518.67b8e9b0@windsurf \
--to=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.