All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [rgushchin:memcontrol_v1.rfc 7/10] mm/memcontrol-v1.c:1475:6: sparse: sparse: symbol 'mem_cgroup_oom_notify' was not declared. Should it be static?
Date: Fri, 10 May 2024 06:59:21 +0800	[thread overview]
Message-ID: <202405100613.RXNccOGL-lkp@intel.com> (raw)

tree:   https://github.com/rgushchin/linux.git memcontrol_v1.rfc
head:   0011ac60f32b91542b15b122087bd97f41634b51
commit: aff3b6905c9323586157503a143c23c9fc5536b5 [7/10] mm: memcg: move cgroup v1 oom handling code into memcontrol-v1.c
config: i386-randconfig-061-20240510 (https://download.01.org/0day-ci/archive/20240510/202405100613.RXNccOGL-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405100613.RXNccOGL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405100613.RXNccOGL-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
   mm/memcontrol-v1.c:1174:23: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol-v1.c:1174:23: sparse:    struct task_struct [noderef] __rcu *
   mm/memcontrol-v1.c:1174:23: sparse:    struct task_struct *
   mm/memcontrol-v1.c:1386:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol-v1.c:1386:21: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol-v1.c:1386:21: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol-v1.c:1388:21: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol-v1.c:1388:21: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol-v1.c:1388:21: sparse:    struct mem_cgroup_threshold_ary *
>> mm/memcontrol-v1.c:1475:6: sparse: sparse: symbol 'mem_cgroup_oom_notify' was not declared. Should it be static?
   mm/memcontrol-v1.c:1566:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol-v1.c:1566:9: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol-v1.c:1566:9: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol-v1.c:1660:9: sparse: sparse: incompatible types in comparison expression (different address spaces):
   mm/memcontrol-v1.c:1660:9: sparse:    struct mem_cgroup_threshold_ary [noderef] __rcu *
   mm/memcontrol-v1.c:1660:9: sparse:    struct mem_cgroup_threshold_ary *
   mm/memcontrol-v1.c:482:6: sparse: sparse: context imbalance in 'folio_memcg_lock' - wrong count at exit
   mm/memcontrol-v1.c:529:17: sparse: sparse: context imbalance in '__folio_memcg_unlock' - unexpected unlock
   mm/memcontrol-v1.c: note: in included file (through include/linux/rculist.h, include/linux/cgroup.h, include/linux/memcontrol.h):
   include/linux/rcupdate.h:812:9: sparse: sparse: context imbalance in 'mem_cgroup_count_precharge_pte_range' - unexpected unlock
   include/linux/rcupdate.h:812:9: sparse: sparse: context imbalance in 'mem_cgroup_move_charge_pte_range' - unexpected unlock

vim +/mem_cgroup_oom_notify +1475 mm/memcontrol-v1.c

7436a2e299bc25 Roman Gushchin 2024-05-06  1474  
7436a2e299bc25 Roman Gushchin 2024-05-06 @1475  void mem_cgroup_oom_notify(struct mem_cgroup *memcg)
7436a2e299bc25 Roman Gushchin 2024-05-06  1476  {
7436a2e299bc25 Roman Gushchin 2024-05-06  1477  	struct mem_cgroup *iter;
7436a2e299bc25 Roman Gushchin 2024-05-06  1478  
7436a2e299bc25 Roman Gushchin 2024-05-06  1479  	for_each_mem_cgroup_tree(iter, memcg)
7436a2e299bc25 Roman Gushchin 2024-05-06  1480  		mem_cgroup_oom_notify_cb(iter);
7436a2e299bc25 Roman Gushchin 2024-05-06  1481  }
7436a2e299bc25 Roman Gushchin 2024-05-06  1482  

:::::: The code at line 1475 was first introduced by commit
:::::: 7436a2e299bc254dfe54f5de8719e37b72ae2d9a mm: memcg: move legacy memcg event code into memcontrol-v1.c

:::::: TO: Roman Gushchin <roman.gushchin@linux.dev>
:::::: CC: Roman Gushchin <roman.gushchin@linux.dev>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-05-09 22:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202405100613.RXNccOGL-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=roman.gushchin@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.