From: Greg KH <gregkh@linuxfoundation.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Jameson Thies <jthies@google.com>,
linux-usb@vger.kernel.org, pmalani@chromium.org,
bleung@google.com, abhishekpandit@chromium.org,
andersson@kernel.org, dmitry.baryshkov@linaro.org,
fabrice.gasnier@foss.st.com, hdegoede@redhat.com,
neil.armstrong@linaro.org, rajaram.regupathy@intel.com,
saranya.gopal@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] usb: typec: ucsi: Fix null pointer dereference in trace
Date: Fri, 10 May 2024 10:35:28 +0100 [thread overview]
Message-ID: <2024051010-hungrily-scholar-7d23@gregkh> (raw)
In-Reply-To: <Zjiq4PrL2ju8FOUz@kuha.fi.intel.com>
On Mon, May 06, 2024 at 01:03:12PM +0300, Heikki Krogerus wrote:
> On Fri, May 03, 2024 at 12:39:17AM +0000, Jameson Thies wrote:
> > From: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
> >
> > ucsi_register_altmode checks IS_ERR on returned pointer and treats
> > NULL as valid. When CONFIG_TYPEC_DP_ALTMODE is not enabled
> > ucsi_register_displayport returns NULL which causese a NULL pointer
> > dereference in trace. Rather than return NULL, call
> > typec_port_register_altmode to register DisplayPort alternate mode
> > as a non-controllable mode when CONFIG_TYPEC_DP_ALTMODE is not enabled.
> >
> > Reviewed-by: Jameson Thies <jthies@google.com>
> > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> You delivered the patch, so you should have used SoB instead of
> Reviewed-by tag:
> https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
Not "should", that would be "must". I can't take it like this, sorry.
greg k-h
next prev parent reply other threads:[~2024-05-10 9:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 0:39 [PATCH v3 0/4] usb: typec: ucsi: Update UCSI alternate mode Jameson Thies
2024-05-03 0:39 ` [PATCH v3 1/4] usb: typec: ucsi: Fix null pointer dereference in trace Jameson Thies
2024-05-03 1:18 ` Benson Leung
2024-05-03 15:35 ` Markus Elfring
2024-05-03 19:05 ` Jameson Thies
2024-05-04 5:12 ` [v3 " Markus Elfring
2024-05-04 7:24 ` Greg Kroah-Hartman
2024-05-06 10:03 ` [PATCH v3 " Heikki Krogerus
2024-05-10 9:35 ` Greg KH [this message]
2024-05-10 17:47 ` Jameson Thies
2024-05-03 0:39 ` [PATCH v3 2/4] usb: typec: Update sysfs when setting ops Jameson Thies
2024-05-03 0:39 ` [PATCH v3 3/4] usb: typec: ucsi: Delay alternate mode discovery Jameson Thies
2024-05-03 0:39 ` [PATCH v3 4/4] usb: typec: ucsi: Always set number of alternate modes Jameson Thies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024051010-hungrily-scholar-7d23@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=andersson@kernel.org \
--cc=bleung@google.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=fabrice.gasnier@foss.st.com \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=pmalani@chromium.org \
--cc=rajaram.regupathy@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.