From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Robert Foss" <rfoss@kernel.org>,
"laurent.pinchart" <Laurent.pinchart@ideasonboard.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Dave Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"derek.kiernan@amd.com" <derek.kiernan@amd.com>,
"dragan.cvetic@amd.com" <dragan.cvetic@amd.com>,
"Saravana Kannan" <saravanak@google.com>,
"Paul Kocialkowski" <contact@paulk.fr>,
"Herve Codina" <herve.codina@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH v2 5/5] misc: add ge-addon-connector driver
Date: Fri, 10 May 2024 12:54:23 +0200 [thread overview]
Message-ID: <20240510125423.25d4b3ed@booty> (raw)
In-Reply-To: <a1970921-f00b-411d-832d-5289f9812ba0@app.fastmail.com>
Hello Greg, Arnd,
On Fri, 10 May 2024 12:24:06 +0200
"Arnd Bergmann" <arnd@arndb.de> wrote:
> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote:
> > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote:
> >>
> >> +config GE_SUNH_CONNECTOR
> >> + tristate "GE SUNH hotplug add-on connector"
> >> + depends on OF
> >> + select OF_OVERLAY
> >> + select FW_LOADER
> >> + select NVMEM
> >> + select DRM_HOTPLUG_BRIDGE
> >
> > Can these be depends instead of select? 'select' causes dependencies
> > that are hard, if not almost impossible, to detect at times why
> > something is being enabled.
>
> I think FW_LOADER needs to be 'select' since it is normally
> a hidden symbol and gets selected by its users, all the other
> ones should be 'depends on'.
I see, makes sense.
And as you pointed that out, I realize perhaps DRM_HOTPLUG_BRIDGE could
become a hidden symbol as it's not expected to be used alone.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-05-10 10:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 7:10 [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges") Luca Ceresoli
2024-05-10 7:10 ` [PATCH v2 1/5] dt-bindings: connector: add GE SUNH hotplug addon connector Luca Ceresoli
2024-05-10 8:41 ` Rob Herring (Arm)
2024-05-10 10:37 ` Luca Ceresoli
2024-05-10 13:22 ` Rob Herring
2024-05-10 14:39 ` Luca Ceresoli
2024-05-10 16:36 ` Rob Herring
2024-05-14 16:51 ` Luca Ceresoli
2024-06-05 14:45 ` Rob Herring
2024-06-11 14:43 ` Luca Ceresoli
2024-05-10 7:10 ` [PATCH v2 2/5] drm/bridge: add bridge notifier to be notified of bridge addition and removal Luca Ceresoli
2024-05-10 7:10 ` [PATCH v2 3/5] drm/encoder: add drm_encoder_cleanup_from() Luca Ceresoli
2024-05-10 7:10 ` [PATCH v2 4/5] drm/bridge: hotplug-bridge: add driver to support hot-pluggable DSI bridges Luca Ceresoli
2024-05-10 7:10 ` [PATCH v2 5/5] misc: add ge-addon-connector driver Luca Ceresoli
2024-05-10 7:55 ` Greg Kroah-Hartman
2024-05-10 10:24 ` Arnd Bergmann
2024-05-10 10:54 ` Luca Ceresoli [this message]
2024-05-10 10:57 ` Arnd Bergmann
2024-05-10 15:32 ` Luca Ceresoli
2024-05-10 10:54 ` Luca Ceresoli
2024-05-10 11:03 ` Greg Kroah-Hartman
2024-05-10 16:44 ` [PATCH v2 0/5] Add support for GE SUNH hot-pluggable connector (was: "drm: add support for hot-pluggable bridges") Rob Herring
2024-05-14 17:11 ` Luca Ceresoli
2024-05-16 13:22 ` Daniel Vetter
2024-05-20 12:01 ` Luca Ceresoli
2024-05-21 12:01 ` Daniel Vetter
2024-06-05 14:47 ` Luca Ceresoli
2024-08-23 10:39 ` Luca Ceresoli
2024-08-27 16:37 ` Daniel Vetter
2024-09-09 13:26 ` Luca Ceresoli
2024-09-24 8:26 ` Simona Vetter
2024-09-25 10:58 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510125423.25d4b3ed@booty \
--to=luca.ceresoli@bootlin.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=contact@paulk.fr \
--cc=daniel@ffwll.ch \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.