From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38BE712C49A for ; Fri, 10 May 2024 15:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356694; cv=none; b=axl/CuyY1Ye6HbDeke3HN86zR0L2vMbz6FEZNpbbeE2vr96yVTZMEUfXxUP3YTWgHwfPqz04MUBxIBjQ6yanLYPP+x5ocGzwCYf/mbeoQlo8eQGVxLvxVGoZYbhLNanfN8ZrZ/8e+h4NVqjEbExta7i2kDcIZ1Unkc3jB5wnMxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715356694; c=relaxed/simple; bh=oBJNUO5v7HQZ0M3irO8gNKGwDMT+XiuEZJVtRaPKgX4=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=tMZ/Tch7NiqsbrYtwrvJl/HWvVlEQqFcxv2SFwKk/b43/Q8tiAguBPJotHZyJ4mfIxtS0QfEbvKXa6uSuyCnCuXmIxt4ZpNkwrlBImL3IsY7dGORZgPrBzHK2JGmoUEHFn35uVkMMdvUC99Mv67h5lfZtX4j2KV2TZHF1nhblNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DRY5ub9G; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DRY5ub9G" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715356691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+wba0z5oPamDMROFY448Q/RdTIR3VFmfJX04F+I7zH0=; b=DRY5ub9GhY8nWoE6k0/dtWhsnuyx+l7jgsAwsAafOjfpqqk/oHoK7uR77E33DAD79R/LyS QJNEdihYakcAwoYhnGYbgyJoC1r4Sj9t0hmoWzvgx8QShsMxTb0Whh48Ta+HEP/DfYn1+s UP77da0yTV8Zuz8EBmxw+9HVjsADZC0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-euwYWfgaPDmz12VLPkiHfA-1; Fri, 10 May 2024 11:58:04 -0400 X-MC-Unique: euwYWfgaPDmz12VLPkiHfA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 92759800074 for ; Fri, 10 May 2024 15:58:04 +0000 (UTC) Received: from aion.redhat.com (unknown [10.22.18.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 84E47204681F for ; Fri, 10 May 2024 15:58:04 +0000 (UTC) Received: from aion.redhat.com (localhost [IPv6:::1]) by aion.redhat.com (Postfix) with ESMTP id 270F114AB0A for ; Fri, 10 May 2024 11:58:04 -0400 (EDT) From: Scott Mayhew To: kdevops@lists.linux.dev Subject: [PATCH] nfstest: add the delegation test group Date: Fri, 10 May 2024 11:58:04 -0400 Message-ID: <20240510155804.21397-1-smayhew@redhat.com> Precedence: bulk X-Mailing-List: kdevops@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true nfstest_delegation can use a second mount with a different nfs version to trigger delegation recalls (i.e. it doesn't need to use a second client), so it can be added to the nfstest workflow easily. Note that the delegation test does show quite a few failures. For example, on a recent-ish Fedora kernel: $ grep -Eh "^[0-9]+ tests" nfstest_delegation_20240510_152*.log 689 tests (623 passed, 66 failed) 1329 tests (1287 passed, 42 failed) 1329 tests (1287 passed, 42 failed) Signed-off-by: Scott Mayhew --- playbooks/roles/nfstest/templates/delegation.sh.j2 | 13 +++++++++++++ workflows/nfstest/Kconfig | 6 ++++++ workflows/nfstest/Makefile | 3 +++ 3 files changed, 22 insertions(+) create mode 100755 playbooks/roles/nfstest/templates/delegation.sh.j2 diff --git a/playbooks/roles/nfstest/templates/delegation.sh.j2 b/playbooks/roles/nfstest/templates/delegation.sh.j2 new file mode 100755 index 0000000..ede24d4 --- /dev/null +++ b/playbooks/roles/nfstest/templates/delegation.sh.j2 @@ -0,0 +1,13 @@ +#!/bin/bash + +export PYTHONPATH="{{ nfstest_install_dir }}" +cd {{ nfstest_install_dir }}/test/ + +for vers in 4.0 4.1 4.2 +do + ./nfstest_delegation --runtest=all --createlog --nfsversion=${vers} \ + --server={{ nfstest_nfs_server_host }} \ + --export=/export/{{ nfstest_nfs_server_export }} +done + +exit 0 diff --git a/workflows/nfstest/Kconfig b/workflows/nfstest/Kconfig index a029a56..e2f57aa 100644 --- a/workflows/nfstest/Kconfig +++ b/workflows/nfstest/Kconfig @@ -54,6 +54,12 @@ config NFSTEST_TEST_GROUP_ALLOC help Provision a target node to test NFSv4.2 space reservation. +config NFSTEST_TEST_GROUP_DELEGATION + bool "Enable the nfstest_delegation testing section" + default n + help + Provision target nodes to test NFS delegations. + config NFSTEST_TEST_GROUP_DIO bool "Enable the nfstest_dio testing section" default n diff --git a/workflows/nfstest/Makefile b/workflows/nfstest/Makefile index 638ec1f..8a92496 100644 --- a/workflows/nfstest/Makefile +++ b/workflows/nfstest/Makefile @@ -23,6 +23,9 @@ NFSTEST_ARGS += nfstest_repo_commit=$(NFSTEST_REPO_COMMIT) ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_ALLOC)) NFSTEST_ENABLED_TEST_GROUPS += alloc endif +ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_DELEGATION)) +NFSTEST_ENABLED_TEST_GROUPS += delegation +endif ifeq (y,$(CONFIG_NFSTEST_TEST_GROUP_DIO)) NFSTEST_ENABLED_TEST_GROUPS += dio endif -- 2.43.0