Re: [RFC v2] Bluetooth: MGMT: Make MGMT_OP_LOAD_CONN_PARAM update existing connection

[kernel test robot <lkp@intel.com>]

Hi Luiz,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on bluetooth/master linus/master v6.9-rc7 next-20240510]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Luiz-Augusto-von-Dentz/Bluetooth-MGMT-Make-MGMT_OP_LOAD_CONN_PARAM-update-existing-connection/20240510-065108
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
patch link:    https://lore.kernel.org/r/20240509225043.1357933-1-luiz.dentz%40gmail.com
patch subject: [RFC v2] Bluetooth: MGMT: Make MGMT_OP_LOAD_CONN_PARAM update existing connection
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240510/202405101745.hjoY6Te2-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240510/202405101745.hjoY6Te2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202405101745.hjoY6Te2-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   net/bluetooth/mgmt.c: In function 'conn_update_sync':
>> net/bluetooth/mgmt.c:7881:9: error: 'conn' undeclared (first use in this function)
    7881 |         conn = hci_conn_hash_lookup_le(hdev, params->addr.bdaddr,
         |         ^~~~
   net/bluetooth/mgmt.c:7881:9: note: each undeclared identifier is reported only once for each function it appears in
>> net/bluetooth/mgmt.c:7881:58: error: 'bdaddr_t' has no member named 'bdaddr'
    7881 |         conn = hci_conn_hash_lookup_le(hdev, params->addr.bdaddr,
         |                                                          ^
>> net/bluetooth/mgmt.c:7886:9: error: expected ';' before 'return'
    7886 |         return hci_le_conn_update_sync(hdev, conn, params);
         |         ^~~~~~
   net/bluetooth/mgmt.c: In function 'load_conn_param':
>> net/bluetooth/mgmt.c:7960:27: error: 'params' undeclared (first use in this function); did you mean 'param'?
    7960 |                 if (!i && params == 1) {
         |                           ^~~~~~
         |                           param
>> net/bluetooth/mgmt.c:7992:36: error: 'struct hci_conn' has no member named 'le_supervision_timeout'; did you mean 'le_supv_timeout'?
    7992 |                              conn->le_supervision_timeout != timeout))
         |                                    ^~~~~~~~~~~~~~~~~~~~~~
         |                                    le_supv_timeout
>> net/bluetooth/mgmt.c:7994:52: error: 'hci_params' undeclared (first use in this function); did you mean 'hci_param'?
    7994 |                                                    hci_params, NULL);
         |                                                    ^~~~~~~~~~
         |                                                    hci_param
   In file included from net/bluetooth/mgmt.c:31:
   net/bluetooth/mgmt.c: At top level:
>> include/net/bluetooth/hci_core.h:1615:46: error: expected declaration specifiers or '...' before '&' token
    1615 | #define hci_dev_unlock(d)       mutex_unlock(&d->lock)
         |                                              ^
   net/bluetooth/mgmt.c:7999:9: note: in expansion of macro 'hci_dev_unlock'
    7999 |         hci_dev_unlock(hdev);
         |         ^~~~~~~~~~~~~~
>> net/bluetooth/mgmt.c:8001:9: error: expected identifier or '(' before 'return'
    8001 |         return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_LOAD_CONN_PARAM, 0,
         |         ^~~~~~
>> net/bluetooth/mgmt.c:8003:1: error: expected identifier or '(' before '}' token
    8003 | }
         | ^
   net/bluetooth/mgmt.c: In function 'load_conn_param':
>> net/bluetooth/mgmt.c:7997:9: warning: control reaches end of non-void function [-Wreturn-type]
    7997 |         }
         |         ^
--
>> net/bluetooth/hci_sync.c:6716:5: warning: no previous prototype for 'hci_le_conn_update_sync' [-Wmissing-prototypes]
    6716 | int hci_le_conn_update_sync(struct hci_dev *hdev, struct hci_conn *conn,
         |     ^~~~~~~~~~~~~~~~~~~~~~~


vim +/conn +7881 net/bluetooth/mgmt.c

  7876	
  7877	static int conn_update_sync(struct hci_dev *hdev, void *data)
  7878	{
  7879		struct hci_conn_params *params = data;
  7880	
> 7881		conn = hci_conn_hash_lookup_le(hdev, params->addr.bdaddr,
  7882					       params->addr_type);
  7883		if (!conn)
  7884			return -ECANCELED
  7885	
> 7886		return hci_le_conn_update_sync(hdev, conn, params);
  7887	}
  7888	
  7889	static int load_conn_param(struct sock *sk, struct hci_dev *hdev, void *data,
  7890				   u16 len)
  7891	{
  7892		struct mgmt_cp_load_conn_param *cp = data;
  7893		const u16 max_param_count = ((U16_MAX - sizeof(*cp)) /
  7894					     sizeof(struct mgmt_conn_param));
  7895		u16 param_count, expected_len;
  7896		int i;
  7897	
  7898		if (!lmp_le_capable(hdev))
  7899			return mgmt_cmd_status(sk, hdev->id, MGMT_OP_LOAD_CONN_PARAM,
  7900					       MGMT_STATUS_NOT_SUPPORTED);
  7901	
  7902		param_count = __le16_to_cpu(cp->param_count);
  7903		if (param_count > max_param_count) {
  7904			bt_dev_err(hdev, "load_conn_param: too big param_count value %u",
  7905				   param_count);
  7906			return mgmt_cmd_status(sk, hdev->id, MGMT_OP_LOAD_CONN_PARAM,
  7907					       MGMT_STATUS_INVALID_PARAMS);
  7908		}
  7909	
  7910		expected_len = struct_size(cp, params, param_count);
  7911		if (expected_len != len) {
  7912			bt_dev_err(hdev, "load_conn_param: expected %u bytes, got %u bytes",
  7913				   expected_len, len);
  7914			return mgmt_cmd_status(sk, hdev->id, MGMT_OP_LOAD_CONN_PARAM,
  7915					       MGMT_STATUS_INVALID_PARAMS);
  7916		}
  7917	
  7918		bt_dev_dbg(hdev, "param_count %u", param_count);
  7919	
  7920		hci_dev_lock(hdev);
  7921	
  7922		if (i > 1)
  7923			hci_conn_params_clear_disabled(hdev);
  7924	
  7925		for (i = 0; i < param_count; i++) {
  7926			struct mgmt_conn_param *param = &cp->params[i];
  7927			struct hci_conn_params *hci_param;
  7928			u16 min, max, latency, timeout;
  7929			u8 addr_type;
  7930			bool update;
  7931	
  7932			bt_dev_dbg(hdev, "Adding %pMR (type %u)", &param->addr.bdaddr,
  7933				   param->addr.type);
  7934	
  7935			if (param->addr.type == BDADDR_LE_PUBLIC) {
  7936				addr_type = ADDR_LE_DEV_PUBLIC;
  7937			} else if (param->addr.type == BDADDR_LE_RANDOM) {
  7938				addr_type = ADDR_LE_DEV_RANDOM;
  7939			} else {
  7940				bt_dev_err(hdev, "ignoring invalid connection parameters");
  7941				continue;
  7942			}
  7943	
  7944			min = le16_to_cpu(param->min_interval);
  7945			max = le16_to_cpu(param->max_interval);
  7946			latency = le16_to_cpu(param->latency);
  7947			timeout = le16_to_cpu(param->timeout);
  7948	
  7949			bt_dev_dbg(hdev, "min 0x%04x max 0x%04x latency 0x%04x timeout 0x%04x",
  7950				   min, max, latency, timeout);
  7951	
  7952			if (hci_check_conn_params(min, max, latency, timeout) < 0) {
  7953				bt_dev_err(hdev, "ignoring invalid connection parameters");
  7954				continue;
  7955			}
  7956	
  7957			/* Detect when the loading is for an existing parameter then
  7958			 * attempt to trigger the connection update procedure.
  7959			 */
> 7960			if (!i && params == 1) {
  7961				hci_param = hci_conn_params_lookup(hdev,
  7962								   &param->addr.bdaddr,
  7963								   addr_type);
  7964				if (hci_param)
  7965					update = true;
  7966				else
  7967					hci_conn_params_clear_disabled(hdev);
  7968			}
  7969	
  7970			hci_param = hci_conn_params_add(hdev, &param->addr.bdaddr,
  7971							addr_type);
  7972			if (!hci_param) {
  7973				bt_dev_err(hdev, "failed to add connection parameters");
  7974				continue;
  7975			}
  7976	
  7977			hci_param->conn_min_interval = min;
  7978			hci_param->conn_max_interval = max;
  7979			hci_param->conn_latency = latency;
  7980			hci_param->supervision_timeout = timeout;
  7981	
  7982			if (update) {
  7983				struct hci_conn *conn;
  7984	
  7985				conn = hci_conn_hash_lookup_le(hdev,
  7986							       params->addr.bdaddr,
  7987							       addr_type);
  7988				if (conn && conn->role == HCI_ROLE_MASTER &&
  7989				    (conn->le_conn_min_interval != min ||
  7990				     conn->le_conn_max_interval != max ||
  7991				     conn->le_conn_latency != latency ||
> 7992				     conn->le_supervision_timeout != timeout))
  7993					hci_cmd_sync_queue(hdev, conn_update_sync,
> 7994							   hci_params, NULL);
  7995				}
  7996			}
> 7997		}
  7998	
> 7999		hci_dev_unlock(hdev);
  8000	
> 8001		return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_LOAD_CONN_PARAM, 0,
  8002					 NULL, 0);
> 8003	}
  8004	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki