All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Brian Mayer <bleemayer@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/sbase: new package
Date: Fri, 10 May 2024 23:32:06 +0200	[thread overview]
Message-ID: <20240510233206.04122516@windsurf> (raw)
In-Reply-To: <CAB3eKoBtu8-9ch_k9k=-tHocLE8SjYanSotPOM1HOTUsU-eGOQ@mail.gmail.com>

Hello Brian,

On Tue, 26 Mar 2024 11:36:18 -0300
Brian Mayer <bleemayer@gmail.com> wrote:

> sbase is a collection of unix tools that are inherently portable across
> UNIX and UNIX-like systems.
> 
> Signed-off-by: brian <brian@myr.sh>

Aside from the wrapping issue, we also need your Signed-off-by to use
your full name, and to match (in terms of e-mail address) the Author of
the commit. Right now, there is discrepancy between:

  From: Brian Mayer <bleemayer@gmail.com>

and:

  Signed-off-by: brian <brian@myr.sh>

Could you fix this this in your v3 ?

Also, a few more comments:

- Please add an entry in the DEVELOPERS file for this new package

- Please add hashes for the license files in sbase.hash

- Make sure using utils/test-pkg that your packages builds reasonably
  fine on a selection of Buildroot configurations

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-05-10 21:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 14:36 [Buildroot] [PATCH v2] package/sbase: new package Brian Mayer
2024-03-26 14:45 ` Brian Mayer
2024-04-02 22:54   ` Brian Mayer
2024-04-03 19:42     ` Arnout Vandecappelle via buildroot
2024-05-10 21:32 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510233206.04122516@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bleemayer@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.